electron/brightray/common
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
mac clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
application_info.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
application_info.h fix: Windows Store Notifications (#13258) 2018-09-06 02:06:29 +10:00
application_info_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
application_info_win.cc fix: Windows Store Notifications (#13258) 2018-09-06 02:06:29 +10:00
content_client.cc ResourceBundle → ui::ResourceBundle 2018-06-19 11:46:59 +10:00
content_client.h [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
main_delegate.cc chore: remove unsupported DISABLE_NACL define 2018-09-12 12:09:41 -07:00
main_delegate.h [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
main_delegate_mac.mm load all pak files on macOS 2018-06-18 16:51:36 +09:00
platform_util.h Fix desktop-id notification edge case (#12216) 2018-03-12 16:02:47 +09:00
platform_util_linux.cc Fix desktop-id notification edge case (#12216) 2018-03-12 16:02:47 +09:00
switches.cc fix: notify request context shutdown on IO before cleanup (#14058) 2018-08-14 14:07:53 -07:00
switches.h fix: notify request context shutdown on IO before cleanup (#14058) 2018-08-14 14:07:53 -07:00