mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/brightray/browser
History
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583) 
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
linux [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
mac build: remove duplicate devtools sources (#14522) 2018-09-12 08:45:08 -05:00
media fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
net Introduce additional Certificate Transparency preferences 2018-09-11 20:21:32 +02:00
views fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
win fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
brightray_paths.h clang-format brightray 2018-04-17 21:46:27 -04:00
browser_client.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
browser_client.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
browser_context.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
browser_context.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
browser_main_parts.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
browser_main_parts.h fix: Improve --enable-features/--disable-features handling (#13920) 2018-08-03 10:53:54 +10:00
browser_main_parts_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
devtools_manager_delegate.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
devtools_manager_delegate.h Devtools: Remove session_id in browser 2018-06-19 11:46:59 +10:00
devtools_ui.cc format previously misses .cc files 2018-04-17 21:56:12 -04:00
devtools_ui.h
inspectable_web_contents.cc fix: use OOPIF for webview tag (#13869) 2018-08-16 15:57:40 -07:00
inspectable_web_contents.h fix: use OOPIF for webview tag (#13869) 2018-08-16 15:57:40 -07:00
inspectable_web_contents_delegate.h build: remove duplicate devtools sources (#14522) 2018-09-12 08:45:08 -05:00
inspectable_web_contents_impl.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
inspectable_web_contents_impl.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
inspectable_web_contents_view.h Require !OS_MACOSX as well as TOOLKIT_VIEWS for views code 2018-05-10 14:11:19 -07:00
inspectable_web_contents_view_delegate.cc format previously misses .cc files 2018-04-17 21:56:12 -04:00
inspectable_web_contents_view_delegate.h clang-format brightray 2018-04-17 21:46:27 -04:00
inspectable_web_contents_view_mac.h [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
inspectable_web_contents_view_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
io_thread.cc No longer save the IO message loop in net::EnsureNSSHttpIOInit 2018-09-11 20:21:32 +02:00
io_thread.h clang-format brightray 2018-04-17 21:46:27 -04:00
net_log.cc Add missing network:: for net log switches 2018-06-19 11:52:17 +10:00
net_log.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
notification.cc [chromium-style] out-of-line default constructors and destructors 2018-04-19 11:12:58 -07:00
notification.h REVIEW: Remove the notification close-closure in favour of an explicit method 2018-06-19 11:49:40 +10:00
notification_delegate.h
notification_presenter.cc REVIEW: Remove the notification close-closure in favour of an explicit method 2018-06-19 11:49:40 +10:00
notification_presenter.h REVIEW: Remove the notification close-closure in favour of an explicit method 2018-06-19 11:49:40 +10:00
platform_notification_service.cc fix: remember the render_process_id when permission requests occur on the IO thread (#13621) 2018-07-11 12:21:47 -05:00
platform_notification_service.h REVIEW: Remove the notification close-closure in favour of an explicit method 2018-06-19 11:49:40 +10:00
url_request_context_getter.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_context_getter.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
web_ui_controller_factory.cc [chromium-style] auto variable type must not deduce to a raw pointer type 2018-04-19 11:10:52 -07:00
web_ui_controller_factory.h [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
zoom_level_delegate.cc Remove base::SizeTToString 2018-06-19 11:49:40 +10:00
zoom_level_delegate.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00