mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/atom/common/native_mate_converters
History
Shelley Vohr bfcce8aa27
refactor: pass MessageBox params as a struct (#18732) 
Historically, we've been passing in all MessageBox parameters individually, which makes augmenting or improving MessageBox functionality challenging because to change or add even one argument requires a huge cascade of argument changes that leaves room for errors.

For other file dialog related APIs, we use a struct (DialogSettings), and so this PR takes a similar approach and refactors MessageBox parameters into a struct (MessageBoxSettings) which we then use to simplify argument passing and which will enable us to more quickly iterate and improve upon functionality in the future.
2019-06-14 08:26:25 -07:00
..
accelerator_converter.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
accelerator_converter.h clang-format atom files 2018-04-18 20:48:45 -04:00
blink_converter.cc blink::WebReferrerPolicy -> network::mojom::ReferrerPolicy 2019-01-22 10:32:04 -08:00
blink_converter.h blink::WebReferrerPolicy -> network::mojom::ReferrerPolicy 2019-01-22 10:32:04 -08:00
callback.cc chore: remove last instances of base::Bind (#18178) 2019-05-29 13:02:15 -07:00
callback.h chore: support converting OnceCallback to V8 (#17941) 2019-04-25 09:40:27 +09:00
content_converter.cc chore: remove last instances of base::Bind (#18178) 2019-05-29 13:02:15 -07:00
content_converter.h chore: update permission_status.h include for new path 2019-04-02 14:43:03 -07:00
file_dialog_converter.cc feat: add methods to allow customization of save dialog during will-download event (#15497) 2018-11-08 10:51:06 -04:00
file_dialog_converter.h feat: add methods to allow customization of save dialog during will-download event (#15497) 2018-11-08 10:51:06 -04:00
file_path_converter.h refactor: convert crash reporter to gin (#17952) 2019-05-01 15:19:11 -07:00
gfx_converter.cc feat: expose colorSpace to display object (#17405) 2019-03-19 15:12:03 -07:00
gfx_converter.h Add gfx:PointF support to mate::Converter 2018-06-19 11:49:45 +10:00
gurl_converter.h clang-format atom files 2018-04-18 20:48:45 -04:00
image_converter.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
image_converter.h clang-format atom files 2018-04-18 20:48:45 -04:00
map_converter.h refactor: convert crash reporter to gin (#17952) 2019-05-01 15:19:11 -07:00
message_box_converter.cc refactor: pass MessageBox params as a struct (#18732) 2019-06-14 08:26:25 -07:00
message_box_converter.h refactor: pass MessageBox params as a struct (#18732) 2019-06-14 08:26:25 -07:00
net_converter.cc feat: migrate protocol module to NetworkService (Part 12) (#18726) 2019-06-12 08:37:06 +09:00
net_converter.h feat: migrate protocol module to NetworkService (Part 2) (#17965) 2019-04-29 11:37:45 +09:00
network_converter.cc [OnionSoup] replace network::DataElement::Type with DataElementType 2019-02-14 23:59:24 +05:30
network_converter.h Create network_converter for services/network/* types 2018-06-19 11:49:42 +10:00
once_callback.h chore: support converting OnceCallback to V8 (#17941) 2019-04-25 09:40:27 +09:00
string16_converter.h refactor: convert crash reporter to gin (#17952) 2019-05-01 15:19:11 -07:00
ui_base_types_converter.h clang-format atom files 2018-04-18 20:48:45 -04:00
v8_value_converter.cc chore: bump chromium to 7dff37844cb3 (master) (#18059) 2019-04-30 17:18:22 -07:00
v8_value_converter.h fix: update deprecated v8 api usage 2019-02-14 23:59:21 +05:30
value_converter.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
value_converter.h refactor: remove instances of createDeepCopy (#13703) 2018-08-04 07:23:07 +10:00