6ff111a141
* Don't use JSON to send the result of `ipcRenderer.sendSync`.
- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
to wrap/unwrap return values to/from array, instead of
serializing/deserializing JSON.
This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).
A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory. This difference
tends increases with larger buffers.
* Don't base64 encode Buffers
* Don't allocate V8ValueConverter on the heap
* Replace hidden global.sandbox with NodeBindings::IsInitialized()
* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter
* Refactor problematic test to make it more reliable
* Add tests for NaN and Infinity
45 lines
1.3 KiB
JavaScript
45 lines
1.3 KiB
JavaScript
'use strict'
|
|
|
|
const binding = process.atomBinding('ipc')
|
|
const v8Util = process.atomBinding('v8_util')
|
|
|
|
// Created by init.js.
|
|
const ipcRenderer = v8Util.getHiddenValue(global, 'ipc')
|
|
|
|
ipcRenderer.send = function (...args) {
|
|
return binding.send('ipc-message', args)
|
|
}
|
|
|
|
ipcRenderer.sendSync = function (...args) {
|
|
return binding.sendSync('ipc-message-sync', args)[0]
|
|
}
|
|
|
|
ipcRenderer.sendToHost = function (...args) {
|
|
return binding.send('ipc-message-host', args)
|
|
}
|
|
|
|
ipcRenderer.sendTo = function (webContentsId, channel, ...args) {
|
|
if (typeof webContentsId !== 'number') {
|
|
throw new TypeError('First argument has to be webContentsId')
|
|
}
|
|
|
|
ipcRenderer.send('ELECTRON_BROWSER_SEND_TO', false, webContentsId, channel, ...args)
|
|
}
|
|
|
|
ipcRenderer.sendToAll = function (webContentsId, channel, ...args) {
|
|
if (typeof webContentsId !== 'number') {
|
|
throw new TypeError('First argument has to be webContentsId')
|
|
}
|
|
|
|
ipcRenderer.send('ELECTRON_BROWSER_SEND_TO', true, webContentsId, channel, ...args)
|
|
}
|
|
|
|
const removeAllListeners = ipcRenderer.removeAllListeners.bind(ipcRenderer)
|
|
ipcRenderer.removeAllListeners = function (...args) {
|
|
if (args.length === 0) {
|
|
throw new Error('Removing all listeners from ipcRenderer will make Electron internals stop working. Please specify a event name')
|
|
}
|
|
removeAllListeners(...args)
|
|
}
|
|
|
|
module.exports = ipcRenderer
|