![electron-roller[bot]](/assets/img/avatar_default.png)
* chore: bump chromium in DEPS to 134.0.6948.0 * chore: update can_create_window.patch https://chromium-review.googlesource.com/c/chromium/src/+/6151982 no patch code changes, but had to manually apply due to upstream context shear * chore: update proxy_config_monitor.patch no manual changes; patch applied with fuzz 2 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6126219 * chore: update build_add_electron_tracing_category.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6149256 * chore: update adjust_accessibility_ui_for_electron.patch https://chromium-review.googlesource.com/c/chromium/src/+/6105650 no patch code changes, but had to manually apply due to upstream context shear * chore: e patches all * chore: use fully-qualified path for all.gn Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6154997 * chore: do not use a variable when assigning rtc_use_h264 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6154997 * Move GlobalShortcutListenerLinux to //ui/base Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6097375 * [MPArch Guest View] Make WebPreferences queried per frame tree root Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6096390 * [Status Icons] Allow vector resources https://chromium-review.googlesource.com/c/chromium/src/+/6139403 * [Extensions] Move MatchOriginAsFallbackBehavior to Mojom Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6141793 * Remove StrongAlias::Hasher Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6132291 * Rename text-change and select-change methods and related stuff Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6148816 * [Code Health] Remove stale feature EnableWebUsbOnExtensionServiceWorker https://chromium-review.googlesource.com/c/chromium/src/+/6115161 * [Extensions Cleanup] Move creation of tab-based ports to factory method https://chromium-review.googlesource.com/c/chromium/src/+/6143725 * refactor: add StatusIconGtk::SetIcon() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6139403 copied from chrome/browser/status_icons/status_icon.cc * refactor: add TrayIconLinux::GetIcon() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6139403 * chore: update feat_allow_usage_of_sccontentsharingpicker_on_supported_platforms.patch remove unused filter_ field * chore: bump chromium in DEPS to 134.0.6950.0 * chore: bump chromium in DEPS to 134.0.6952.0 * chore: bump chromium in DEPS to 134.0.6954.0 * chore: bump chromium in DEPS to 134.0.6956.0 * chore: update Chromium patches * 6165749: Check scanout support in RenderableGpuMemoryBufferPool | https://chromium-review.googlesource.com/c/chromium/src/+/6165749 * 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | https://chromium-review.googlesource.com/c/chromium/src/+/6106730 * chore: update patches * chore: bump chromium in DEPS to 134.0.6958.0 * chore: bump chromium in DEPS to 134.0.6960.0 * chore: update chromium patches * 6168371: Remove extensions GlobalShortcutListener wrapper | https://chromium-review.googlesource.com/c/chromium/src/+/6168371 * chore: update patches * 6161637: WebUI: Leverage build_webui() in chrome://translate-internals | https://chromium-review.googlesource.com/c/chromium/src/+/6161637 * chore: bump chromium in DEPS to 134.0.6962.0 * 6177329: Remove policy.used_policy_certificates pref on ChromeOS | https://chromium-review.googlesource.com/c/chromium/src/+/6177329 * 6180524: Simplify logic in components/os_crypt/sync/BUILD.gn | https://chromium-review.googlesource.com/c/chromium/src/+/6180524 * 6144831: Enforce --disallow-v8-feature-flag-overrides in the renderer | https://chromium-review.googlesource.com/c/chromium/src/+/6144831 * chore: update patches * chore: bump chromium in DEPS to 134.0.6964.0 * 6181010: Ensure busy cursor does not show via LaunchWithoutSandbox | https://chromium-review.googlesource.com/c/chromium/src/+/6181010 * chore: update patches * chore: bump chromium in DEPS to 134.0.6966.0 * 6180598: [api] Remove Reallocate | https://chromium-review.googlesource.com/c/v8/v8/+/6180598 * 6170781: [Refactor] Move UninstallExtension to ExtensionRegistrar. | https://chromium-review.googlesource.com/c/chromium/src/+/6170781 * chore: update filenames.libcxx.gni * 6168207: cdm: Remove widevine_cdm_version.h | https://chromium-review.googlesource.com/c/chromium/src/+/6168207 * chore: bump chromium in DEPS to 134.0.6968.0 * 6030552: [macOS] Allow using vibrancy with NativeWidgetNSWindowBridge | https://chromium-review.googlesource.com/c/chromium/src/+/6030552 * fix: use explicit copy to replace realloc impl https://chromium-review.googlesource.com/c/v8/v8/+/6180598 https://issues.chromium.org/issues/331326406 As per recommendation, "File an issue with Node to explicitly copy,because they copy under the hood anyway" * fixup! 6106730: [Win] Use DXGI swapchains and DCOMP visuals in software mode | https://chromium-review.googlesource.com/c/chromium/src/+/6106730 * fix: undefine win32 StrCat https://chromium-review.googlesource.com/c/chromium/src/+/6172292 * fix: //device/vr:directx_helpers breaking the build https://chromium-review.googlesource.com/c/chromium/src/+/6064548 Upstreamed in https://chromium-review.googlesource.com/c/chromium/src/+/6186102 * fix: avoid calling ui::Layer::SetFillsBoundsOpaquely https://chromium-review.googlesource.com/c/chromium/src/+/6175787 The layer opacity is determined by the background color's alpha value * fix: build with proprietary_codecs The explicit setting of rtc_use_h264 is no longer needed since https://webrtc-review.googlesource.com/c/src/+/62380 * fix: increase empty trace file size threshold https://chromium-review.googlesource.com/c/chromium/src/+/6176642 Traces now contain a net-constants property to allow them to be converted to a net log. These contain ~1240 new properties with formatted JSON data. * fix: node tests missing resource management globals https://chromium-review.googlesource.com/c/chromium/src/+/6174695 * fixup! fix: use explicit copy to replace realloc impl * chore: disable focus handling test due to win32/ia32 regression --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: Samuel Maddock <smaddock@slack-corp.com> Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org>
158 lines
5.8 KiB
TypeScript
158 lines
5.8 KiB
TypeScript
import { app, contentTracing, TraceConfig, TraceCategoriesAndOptions } from 'electron/main';
|
|
|
|
import { expect } from 'chai';
|
|
|
|
import * as fs from 'node:fs';
|
|
import * as path from 'node:path';
|
|
import { setTimeout } from 'node:timers/promises';
|
|
|
|
import { ifdescribe } from './lib/spec-helpers';
|
|
|
|
// FIXME: The tests are skipped on linux arm/arm64
|
|
ifdescribe(!(['arm', 'arm64'].includes(process.arch)) || (process.platform !== 'linux'))('contentTracing', () => {
|
|
const record = async (options: TraceConfig | TraceCategoriesAndOptions, outputFilePath: string | undefined, recordTimeInMilliseconds = 1e1) => {
|
|
await app.whenReady();
|
|
|
|
await contentTracing.startRecording(options);
|
|
await setTimeout(recordTimeInMilliseconds);
|
|
const resultFilePath = await contentTracing.stopRecording(outputFilePath);
|
|
|
|
return resultFilePath;
|
|
};
|
|
|
|
const outputFilePath = path.join(app.getPath('temp'), 'trace.json');
|
|
beforeEach(() => {
|
|
if (fs.existsSync(outputFilePath)) {
|
|
fs.unlinkSync(outputFilePath);
|
|
}
|
|
});
|
|
|
|
describe('startRecording', function () {
|
|
if (process.platform === 'win32' && process.arch === 'arm64') {
|
|
// WOA needs more time
|
|
this.timeout(10e3);
|
|
} else {
|
|
this.timeout(5e3);
|
|
}
|
|
|
|
const getFileSizeInKiloBytes = (filePath: string) => {
|
|
const stats = fs.statSync(filePath);
|
|
const fileSizeInBytes = stats.size;
|
|
const fileSizeInKiloBytes = fileSizeInBytes / 1024;
|
|
return fileSizeInKiloBytes;
|
|
};
|
|
|
|
it('accepts an empty config', async () => {
|
|
const config = {};
|
|
await record(config, outputFilePath);
|
|
|
|
expect(fs.existsSync(outputFilePath)).to.be.true('output exists');
|
|
|
|
const fileSizeInKiloBytes = getFileSizeInKiloBytes(outputFilePath);
|
|
expect(fileSizeInKiloBytes).to.be.above(0,
|
|
`the trace output file is empty, check "${outputFilePath}"`);
|
|
});
|
|
|
|
it('accepts a trace config', async () => {
|
|
// (alexeykuzmin): All categories are excluded on purpose,
|
|
// so only metadata gets into the output file.
|
|
const config = {
|
|
excluded_categories: ['*']
|
|
};
|
|
await record(config, outputFilePath);
|
|
|
|
// If the `excluded_categories` param above is not respected, categories
|
|
// like `node,node.environment` will be included in the output.
|
|
const content = fs.readFileSync(outputFilePath).toString();
|
|
expect(content.includes('"cat":"node,node.environment"')).to.be.false();
|
|
});
|
|
|
|
it('accepts "categoryFilter" and "traceOptions" as a config', async () => {
|
|
// (alexeykuzmin): All categories are excluded on purpose,
|
|
// so only metadata gets into the output file.
|
|
const config = {
|
|
categoryFilter: '__ThisIsANonexistentCategory__',
|
|
traceOptions: ''
|
|
};
|
|
await record(config, outputFilePath);
|
|
|
|
expect(fs.existsSync(outputFilePath)).to.be.true('output exists');
|
|
|
|
// If the `categoryFilter` param above is not respected
|
|
// the file size will be above 60KB.
|
|
const fileSizeInKiloBytes = getFileSizeInKiloBytes(outputFilePath);
|
|
const expectedMaximumFileSize = 60; // Depends on a platform.
|
|
|
|
expect(fileSizeInKiloBytes).to.be.above(0,
|
|
`the trace output file is empty, check "${outputFilePath}"`);
|
|
expect(fileSizeInKiloBytes).to.be.below(expectedMaximumFileSize,
|
|
`the trace output file is suspiciously large (${fileSizeInKiloBytes}KB),
|
|
check "${outputFilePath}"`);
|
|
});
|
|
});
|
|
|
|
describe('stopRecording', function () {
|
|
if (process.platform === 'win32' && process.arch === 'arm64') {
|
|
// WOA needs more time
|
|
this.timeout(10e3);
|
|
} else {
|
|
this.timeout(5e3);
|
|
}
|
|
|
|
// FIXME(samuelmaddock): this test regularly flakes
|
|
it.skip('does not crash on empty string', async () => {
|
|
const options = {
|
|
categoryFilter: '*',
|
|
traceOptions: 'record-until-full,enable-sampling'
|
|
};
|
|
|
|
await contentTracing.startRecording(options);
|
|
const path = await contentTracing.stopRecording('');
|
|
expect(path).to.be.a('string').that.is.not.empty('result path');
|
|
expect(fs.statSync(path).isFile()).to.be.true('output exists');
|
|
});
|
|
|
|
it('calls its callback with a result file path', async () => {
|
|
const resultFilePath = await record(/* options */ {}, outputFilePath);
|
|
expect(resultFilePath).to.be.a('string').and.be.equal(outputFilePath);
|
|
});
|
|
|
|
it('creates a temporary file when an empty string is passed', async function () {
|
|
const resultFilePath = await record(/* options */ {}, /* outputFilePath */ '');
|
|
expect(resultFilePath).to.be.a('string').that.is.not.empty('result path');
|
|
});
|
|
|
|
it('creates a temporary file when no path is passed', async function () {
|
|
const resultFilePath = await record(/* options */ {}, /* outputFilePath */ undefined);
|
|
expect(resultFilePath).to.be.a('string').that.is.not.empty('result path');
|
|
});
|
|
|
|
it('rejects if no trace is happening', async () => {
|
|
await expect(contentTracing.stopRecording()).to.be.rejectedWith('Failed to stop tracing - no trace in progress');
|
|
});
|
|
});
|
|
|
|
describe('captured events', () => {
|
|
it('include V8 samples from the main process', async function () {
|
|
this.timeout(60000);
|
|
await contentTracing.startRecording({
|
|
categoryFilter: 'disabled-by-default-v8.cpu_profiler',
|
|
traceOptions: 'record-until-full'
|
|
});
|
|
{
|
|
const start = Date.now();
|
|
let n = 0;
|
|
const f = () => {};
|
|
while (Date.now() - start < 200 && n < 500) {
|
|
await setTimeout(0);
|
|
f();
|
|
n++;
|
|
}
|
|
}
|
|
const path = await contentTracing.stopRecording();
|
|
const data = fs.readFileSync(path, 'utf8');
|
|
const parsed = JSON.parse(data);
|
|
expect(parsed.traceEvents.some((x: any) => x.cat === 'disabled-by-default-v8.cpu_profiler' && x.name === 'ProfileChunk')).to.be.true();
|
|
});
|
|
});
|
|
});
|