electron/atom/browser/net
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
asar fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
about_protocol_handler.cc add about: protocol handler 2016-11-09 13:22:58 +05:30
about_protocol_handler.h add about: protocol handler 2016-11-09 13:22:58 +05:30
atom_cert_verifier.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_cert_verifier.h [chromium-style] out-of-line default constructors and destructors 2018-04-19 11:12:58 -07:00
atom_network_delegate.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_network_delegate.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_url_request.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_url_request.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_url_request_job_factory.cc Revert "[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear (#13956)" 2018-08-13 16:16:04 -07:00
atom_url_request_job_factory.h Revert "[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear (#13956)" 2018-08-13 16:16:04 -07:00
cookie_details.h Cookie Store: Extract change notifications to separate classes. 2018-06-19 11:49:40 +10:00
http_protocol_handler.cc Revert "[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear (#13956)" 2018-08-13 16:16:04 -07:00
http_protocol_handler.h Revert "[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear (#13956)" 2018-08-13 16:16:04 -07:00
js_asker.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
js_asker.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_about_job.cc Part I: Move from base::Bind to base::BindOnce and remove unneeded base::Passed (#12661) 2018-04-20 19:55:05 +09:00
url_request_about_job.h add about: protocol handler 2016-11-09 13:22:58 +05:30
url_request_async_asar_job.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_async_asar_job.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_buffer_job.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_buffer_job.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_fetch_job.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_fetch_job.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_stream_job.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_stream_job.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_string_job.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
url_request_string_job.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00