Consider an electron application that uses `execFile` to run a script that lives within the application code base: ```coffee child_process = require 'child_process' child_process.execFile __dirname + '/script.sh', (error) -> throw error if error? ``` An application like this will fail when being packaged in an `asar` with an following error: ``` Error: spawn EACCES ``` Electron overrides certain `fs` functions to make them work within an `asar` package. In the case of `execFile`, the file to be executed is extracted from the `asar` package into a temporary file and ran from there. The problem is that during the extraction, the original permissions of the file are lost. We workaround this by: 1. Extending `asar.stat` to return whether a file is executable or not, which is information that's already saved in the `asar` header. 2. Setting execution permissions on the extracted file if the above property holds true. Fixes: https://github.com/atom/electron/issues/3512
		
			
				
	
	
		
			153 lines
		
	
	
	
		
			5.1 KiB
			
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			153 lines
		
	
	
	
		
			5.1 KiB
			
		
	
	
	
		
			C++
		
	
	
	
	
	
// Copyright (c) 2014 GitHub, Inc.
 | 
						|
// Use of this source code is governed by the MIT license that can be
 | 
						|
// found in the LICENSE file.
 | 
						|
 | 
						|
#include <stddef.h>
 | 
						|
 | 
						|
#include <vector>
 | 
						|
 | 
						|
#include "atom_natives.h"  // NOLINT: This file is generated with coffee2c.
 | 
						|
#include "atom/common/asar/archive.h"
 | 
						|
#include "atom/common/native_mate_converters/callback.h"
 | 
						|
#include "atom/common/native_mate_converters/file_path_converter.h"
 | 
						|
#include "atom/common/node_includes.h"
 | 
						|
#include "native_mate/arguments.h"
 | 
						|
#include "native_mate/dictionary.h"
 | 
						|
#include "native_mate/object_template_builder.h"
 | 
						|
#include "native_mate/wrappable.h"
 | 
						|
 | 
						|
namespace {
 | 
						|
 | 
						|
class Archive : public mate::Wrappable {
 | 
						|
 public:
 | 
						|
  static v8::Local<v8::Value> Create(v8::Isolate* isolate,
 | 
						|
                                      const base::FilePath& path) {
 | 
						|
    scoped_ptr<asar::Archive> archive(new asar::Archive(path));
 | 
						|
    if (!archive->Init())
 | 
						|
      return v8::False(isolate);
 | 
						|
    return (new Archive(archive.Pass()))->GetWrapper(isolate);
 | 
						|
  }
 | 
						|
 | 
						|
 protected:
 | 
						|
  explicit Archive(scoped_ptr<asar::Archive> archive)
 | 
						|
      : archive_(archive.Pass()) {}
 | 
						|
 | 
						|
  // Reads the offset and size of file.
 | 
						|
  v8::Local<v8::Value> GetFileInfo(v8::Isolate* isolate,
 | 
						|
                                    const base::FilePath& path) {
 | 
						|
    asar::Archive::FileInfo info;
 | 
						|
    if (!archive_ || !archive_->GetFileInfo(path, &info))
 | 
						|
      return v8::False(isolate);
 | 
						|
    mate::Dictionary dict(isolate, v8::Object::New(isolate));
 | 
						|
    dict.Set("size", info.size);
 | 
						|
    dict.Set("unpacked", info.unpacked);
 | 
						|
    dict.Set("offset", info.offset);
 | 
						|
    return dict.GetHandle();
 | 
						|
  }
 | 
						|
 | 
						|
  // Returns a fake result of fs.stat(path).
 | 
						|
  v8::Local<v8::Value> Stat(v8::Isolate* isolate,
 | 
						|
                             const base::FilePath& path) {
 | 
						|
    asar::Archive::Stats stats;
 | 
						|
    if (!archive_ || !archive_->Stat(path, &stats))
 | 
						|
      return v8::False(isolate);
 | 
						|
    mate::Dictionary dict(isolate, v8::Object::New(isolate));
 | 
						|
    dict.Set("size", stats.size);
 | 
						|
    dict.Set("offset", stats.offset);
 | 
						|
    dict.Set("executable", stats.executable);
 | 
						|
    dict.Set("isFile", stats.is_file);
 | 
						|
    dict.Set("isDirectory", stats.is_directory);
 | 
						|
    dict.Set("isLink", stats.is_link);
 | 
						|
    return dict.GetHandle();
 | 
						|
  }
 | 
						|
 | 
						|
  // Returns all files under a directory.
 | 
						|
  v8::Local<v8::Value> Readdir(v8::Isolate* isolate,
 | 
						|
                                const base::FilePath& path) {
 | 
						|
    std::vector<base::FilePath> files;
 | 
						|
    if (!archive_ || !archive_->Readdir(path, &files))
 | 
						|
      return v8::False(isolate);
 | 
						|
    return mate::ConvertToV8(isolate, files);
 | 
						|
  }
 | 
						|
 | 
						|
  // Returns the path of file with symbol link resolved.
 | 
						|
  v8::Local<v8::Value> Realpath(v8::Isolate* isolate,
 | 
						|
                                 const base::FilePath& path) {
 | 
						|
    base::FilePath realpath;
 | 
						|
    if (!archive_ || !archive_->Realpath(path, &realpath))
 | 
						|
      return v8::False(isolate);
 | 
						|
    return mate::ConvertToV8(isolate, realpath);
 | 
						|
  }
 | 
						|
 | 
						|
  // Copy the file out into a temporary file and returns the new path.
 | 
						|
  v8::Local<v8::Value> CopyFileOut(v8::Isolate* isolate,
 | 
						|
                                    const base::FilePath& path) {
 | 
						|
    base::FilePath new_path;
 | 
						|
    if (!archive_ || !archive_->CopyFileOut(path, &new_path))
 | 
						|
      return v8::False(isolate);
 | 
						|
    return mate::ConvertToV8(isolate, new_path);
 | 
						|
  }
 | 
						|
 | 
						|
  // Return the file descriptor.
 | 
						|
  int GetFD() const {
 | 
						|
    if (!archive_)
 | 
						|
      return -1;
 | 
						|
    return archive_->GetFD();
 | 
						|
  }
 | 
						|
 | 
						|
  // Free the resources used by archive.
 | 
						|
  void Destroy() {
 | 
						|
    archive_.reset();
 | 
						|
  }
 | 
						|
 | 
						|
  // mate::Wrappable:
 | 
						|
  mate::ObjectTemplateBuilder GetObjectTemplateBuilder(v8::Isolate* isolate) {
 | 
						|
    return mate::ObjectTemplateBuilder(isolate)
 | 
						|
        .SetValue("path", archive_->path())
 | 
						|
        .SetMethod("getFileInfo", &Archive::GetFileInfo)
 | 
						|
        .SetMethod("stat", &Archive::Stat)
 | 
						|
        .SetMethod("readdir", &Archive::Readdir)
 | 
						|
        .SetMethod("realpath", &Archive::Realpath)
 | 
						|
        .SetMethod("copyFileOut", &Archive::CopyFileOut)
 | 
						|
        .SetMethod("getFd", &Archive::GetFD)
 | 
						|
        .SetMethod("destroy", &Archive::Destroy);
 | 
						|
  }
 | 
						|
 | 
						|
 private:
 | 
						|
  scoped_ptr<asar::Archive> archive_;
 | 
						|
 | 
						|
  DISALLOW_COPY_AND_ASSIGN(Archive);
 | 
						|
};
 | 
						|
 | 
						|
void InitAsarSupport(v8::Isolate* isolate,
 | 
						|
                     v8::Local<v8::Value> process,
 | 
						|
                     v8::Local<v8::Value> require) {
 | 
						|
  // Evaluate asar_init.coffee.
 | 
						|
  v8::Local<v8::Script> asar_init = v8::Script::Compile(v8::String::NewFromUtf8(
 | 
						|
      isolate,
 | 
						|
      node::asar_init_native,
 | 
						|
      v8::String::kNormalString,
 | 
						|
      sizeof(node::asar_init_native) -1));
 | 
						|
  v8::Local<v8::Value> result = asar_init->Run();
 | 
						|
 | 
						|
  // Initialize asar support.
 | 
						|
  base::Callback<void(v8::Local<v8::Value>,
 | 
						|
                      v8::Local<v8::Value>,
 | 
						|
                      std::string)> init;
 | 
						|
  if (mate::ConvertFromV8(isolate, result, &init)) {
 | 
						|
    init.Run(process,
 | 
						|
             require,
 | 
						|
             std::string(node::asar_native, sizeof(node::asar_native) - 1));
 | 
						|
  }
 | 
						|
}
 | 
						|
 | 
						|
void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
 | 
						|
                v8::Local<v8::Context> context, void* priv) {
 | 
						|
  mate::Dictionary dict(context->GetIsolate(), exports);
 | 
						|
  dict.SetMethod("createArchive", &Archive::Create);
 | 
						|
  dict.SetMethod("initAsarSupport", &InitAsarSupport);
 | 
						|
}
 | 
						|
 | 
						|
}  // namespace
 | 
						|
 | 
						|
NODE_MODULE_CONTEXT_AWARE_BUILTIN(atom_common_asar, Initialize)
 |