mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/shell/browser/api
History
trop[bot] be842d6267
perf: avoid redundant calls to GetView() (#43229) 
* perf: avoid double-calls to GetView()

There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:

if (auto* view = foo->GetView())
  view->DoSomething();

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* perf: avoid discarded GetView() call

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-06 13:23:21 -05:00
..
views chore: rename built-in modules to bindings to match naming update in node (#37182) 2023-02-09 10:31:38 +09:00
electron_api_app.cc fix: utilityProcess exit codes (#42397) 2024-06-07 15:44:55 +02:00
electron_api_app.h fix: stop using std::vector<const uint8_t> in ProcessingSingleton (#41832) 2024-04-15 10:32:48 -07:00
electron_api_app_mac.mm chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_app_mas.mm chore: bump chromium to 117.0.5923.0 (main) (#39304) 2023-08-04 10:47:29 +02:00
electron_api_auto_updater.cc fix: gin_helper::MicrotasksScope instantiation (#43209) 2024-08-05 21:46:51 -05:00
electron_api_auto_updater.h feat: add new ElectronSquirrelPreventDowngrades flag (#38625) 2023-09-11 11:54:51 -07:00
electron_api_base_window.cc fix: remove InspectableWebContentsViewMac (#43096) 2024-07-30 14:51:51 -04:00
electron_api_base_window.h chore: remove unused BaseWindow::GetWeakPtr() (#42988) 2024-07-22 10:20:27 -05:00
electron_api_browser_window.cc fix: setTitleBarOverlay should be implemented on BaseWindow (#42150) 2024-05-23 11:08:36 +02:00
electron_api_browser_window.h fix: setTitleBarOverlay should be implemented on BaseWindow (#42150) 2024-05-23 11:08:36 +02:00
electron_api_content_tracing.cc chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_cookies.cc refactor: improve cookie failure rejection messages (#42400) 2024-06-07 13:01:23 -05:00
electron_api_cookies.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
electron_api_crash_reporter.cc chore: bump chromium to 116.0.5829.0 (main) (#38726) 2023-06-13 14:45:48 -04:00
electron_api_crash_reporter.h chore: used nested namespaces (#34737) 2022-06-29 12:55:47 -07:00
electron_api_data_pipe_holder.cc chore: bump chromium to 126.0.6445.0 (31-x-y) (#42119) 2024-05-13 20:19:31 +02:00
electron_api_data_pipe_holder.h chore: add missing gin::Wrappable GetTypeName overrides (#41512) 2024-03-06 12:45:28 +01:00
electron_api_debugger.cc refactor: replace use of deprecated base::JSONWriter::WriteJson() (#41215) 2024-02-02 12:25:58 -06:00
electron_api_debugger.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
electron_api_desktop_capturer.cc fix: desktopCapturer and screen display ids should match (#42890) 2024-07-14 18:30:34 +02:00
electron_api_desktop_capturer.h fix: use StartUpdating method for PipeWire capturer (#38833) 2023-07-11 10:21:11 +02:00
electron_api_dialog.cc refactor: add gin_helper::Dictionary::CreateEmpty() helper (#39547) 2023-08-21 10:43:41 +09:00
electron_api_download_item.cc feat: add getPercentComplete / getCurrentBytesPerSecond / getEndTime to DownloadItem (#42915) 2024-07-17 09:49:05 -07:00
electron_api_download_item.h feat: add getPercentComplete / getCurrentBytesPerSecond / getEndTime to DownloadItem (#42915) 2024-07-17 09:49:05 -07:00
electron_api_event_emitter.cc chore: rename built-in modules to bindings to match naming update in node (#37182) 2023-02-09 10:31:38 +09:00
electron_api_event_emitter.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
electron_api_global_shortcut.cc chore: bump chromium to 117.0.5852.0 (main) (#38891) 2023-07-01 16:22:55 -04:00
electron_api_global_shortcut.h chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
electron_api_in_app_purchase.cc chore: remove obsolete "simple" object annotations for the remote module (#39486) 2023-08-22 13:43:30 +09:00
electron_api_in_app_purchase.h chore: used nested namespaces (#34737) 2022-06-29 12:55:47 -07:00
electron_api_menu.cc fix: set prototype names on gin::Constructible classes (#39006) 2023-07-10 11:49:20 +02:00
electron_api_menu.h refactor: replace remaining NULL with nullptr (#40053) 2023-10-03 12:26:35 -07:00
electron_api_menu_mac.h chore: cleanup arc migration helpers (#39606) 2023-08-23 09:54:21 -04:00
electron_api_menu_mac.mm chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_menu_views.cc perf: use flat_set, flat_map for small, trivially-moved containers (#40817) 2024-01-05 12:18:31 +01:00
electron_api_menu_views.h perf: use flat_set, flat_map for small, trivially-moved containers (#40817) 2024-01-05 12:18:31 +01:00
electron_api_native_theme.cc feat: add transparency checking to nativeTheme (#43137) 2024-08-01 12:14:07 +02:00
electron_api_native_theme.h feat: add transparency checking to nativeTheme (#43137) 2024-08-01 12:14:07 +02:00
electron_api_native_theme_mac.mm chore: cleanup arc migration helpers (#39606) 2023-08-23 09:54:21 -04:00
electron_api_net_log.cc chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_net_log.h chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_notification.cc refactor: inline simple getters (#41125) 2024-01-29 20:43:28 -06:00
electron_api_notification.h refactor: inline simple getters (#41125) 2024-01-29 20:43:28 -06:00
electron_api_power_monitor.cc feat: add thermal states to powerMonitor (#37935) 2023-04-19 11:46:55 +02:00
electron_api_power_monitor.h feat: add thermal states to powerMonitor (#37935) 2023-04-19 11:46:55 +02:00
electron_api_power_monitor_mac.mm fix: user-did-{resign|become}-active events on macOS (#41506) 2024-03-06 12:43:39 +01:00
electron_api_power_monitor_win.cc refactor: replace remaining NULL with nullptr (#40053) 2023-10-03 12:26:35 -07:00
electron_api_power_save_blocker.cc chore: add missing gin::Wrappable GetTypeName overrides (#41512) 2024-03-06 12:45:28 +01:00
electron_api_power_save_blocker.h chore: add missing gin::Wrappable GetTypeName overrides (#41512) 2024-03-06 12:45:28 +01:00
electron_api_printing.cc chore: remove deprecated webContents.getPrinters() (#39663) 2023-09-05 10:16:41 +02:00
electron_api_protocol.cc chore: migrate base::StringPiece to std::string_view (#40915) 2024-01-10 19:00:37 -06:00
electron_api_protocol.h feat: enable code cache for custom protocols (#40544) 2023-12-06 11:22:41 +09:00
electron_api_push_notifications.cc chore: remove unused std includes (#38767) 2023-06-14 11:07:18 -07:00
electron_api_push_notifications.h chore: use nested namespaces (#37855) 2023-04-11 15:30:25 +09:00
electron_api_push_notifications_mac.mm chore: cleanup arc migration helpers (#39606) 2023-08-23 09:54:21 -04:00
electron_api_safe_storage.cc refactor: move safe_storage functions into anonymous namespace (#43051) 2024-07-25 22:32:17 +02:00
electron_api_screen.cc chore: bump chromium to 126.0.6478.36 (31-x-y) (#42167) 2024-06-07 10:22:46 +02:00
electron_api_screen.h chore: bump chromium to 126.0.6478.36 (31-x-y) (#42167) 2024-06-07 10:22:46 +02:00
electron_api_service_worker_context.cc refactor: remove banned std::to_string() calls (#41087) 2024-01-24 16:43:31 -06:00
electron_api_service_worker_context.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
electron_api_session.cc fix: dangling raw_ptr<Session> in UserDataLink (#42852) 2024-07-11 14:53:06 +02:00
electron_api_session.h fix: dangling raw_ptr<Session> in UserDataLink (#42852) 2024-07-11 14:53:06 +02:00
electron_api_system_preferences.cc feat: expose app accessibility transparency settings api (#39631) 2023-09-20 12:48:02 -07:00
electron_api_system_preferences.h feat: expose app accessibility transparency settings api (#39631) 2023-09-20 12:48:02 -07:00
electron_api_system_preferences_mac.mm chore: bump chromium to 123.0.6296.0 (main) (#41204) 2024-02-14 12:33:32 -05:00
electron_api_system_preferences_win.cc feat: expose system preferences to utility process (#42598) 2024-06-20 15:33:21 -04:00
electron_api_tray.cc chore: migrate base::StringPiece to std::string_view (#40915) 2024-01-10 19:00:37 -06:00
electron_api_tray.h chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_utility_process.cc fix: utilityProcess exit codes (#42397) 2024-06-07 15:44:55 +02:00
electron_api_utility_process.h fix: utilityProcess exit codes (#42397) 2024-06-07 15:44:55 +02:00
electron_api_view.cc fix: dangling raw_ptr<views::View> in api::View (#42951) 2024-07-17 23:31:40 -05:00
electron_api_view.h fix: View reordering on re-addition to same parent (#42116) 2024-05-13 11:48:51 +02:00
electron_api_web_contents.cc refactor: remove unused web contents preferences methods (#42969) 2024-07-19 18:55:07 -05:00
electron_api_web_contents.h chore: bump chromium to 126.0.6478.36 (31-x-y) (#42167) 2024-06-07 10:22:46 +02:00
electron_api_web_contents_impl.cc build: remove enable_osr build flag (#38703) 2023-06-13 14:48:53 -04:00
electron_api_web_contents_mac.mm refactor: inline simple getters, pt . 2 (#41254) 2024-02-09 10:29:14 +01:00
electron_api_web_contents_view.cc fix: remove InspectableWebContentsViewMac (#43096) 2024-07-30 14:51:51 -04:00
electron_api_web_contents_view.h chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_web_frame_main.cc fix: account for potentially swapped FrameTreeNodeId in WebFrameMain (#41538) 2024-03-14 09:50:52 +01:00
electron_api_web_frame_main.h chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_web_request.cc fix: use BlockedRequest struct to handle webRequest data (#42751) 2024-07-03 14:46:29 +02:00
electron_api_web_request.h fix: use BlockedRequest struct to handle webRequest data (#42751) 2024-07-03 14:46:29 +02:00
electron_api_web_view_manager.cc chore: rename built-in modules to bindings to match naming update in node (#37182) 2023-02-09 10:31:38 +09:00
frame_subscriber.cc perf: avoid redundant calls to GetView() (#43229) 2024-08-06 13:23:21 -05:00
frame_subscriber.h chore: bump chromium to 120.0.6099.0 (main) (#40316) 2023-11-01 10:02:12 -04:00
gpu_info_enumerator.cc refactor: simplify code by using base::Value::EnsureList() (#41162) 2024-01-30 14:48:09 -06:00
gpu_info_enumerator.h chore: modernize ListValue usage in gpu info (#34663) 2022-06-28 09:52:59 -07:00
gpuinfo_manager.cc chore: bump chromium to 125.0.6412.0 (main) (#41610) 2024-04-15 18:10:32 -04:00
gpuinfo_manager.h chore: bump chromium to 125.0.6412.0 (main) (#41610) 2024-04-15 18:10:32 -04:00
message_port.cc fix: MessagePort closing unexpectedly with non-cloneable objects (#42580) 2024-06-19 16:43:36 -04:00
message_port.h chore: add missing gin::Wrappable GetTypeName overrides (#41512) 2024-03-06 12:45:28 +01:00
process_metric.cc chore: bump chromium to 123.0.6296.0 (main) (#41204) 2024-02-14 12:33:32 -05:00
process_metric.h chore: bump chromium to 100.0.4857.0 (main) (#32419) 2022-02-09 18:58:52 -08:00
save_page_handler.cc chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
save_page_handler.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
ui_event.cc chore: used nested namespaces (#34737) 2022-06-29 12:55:47 -07:00
ui_event.h chore: used nested namespaces (#34737) 2022-06-29 12:55:47 -07:00