6df2680cb6
* refactor: clean up webFrame implementation to use gin wrappers The previous implementation of webFrame in the renderer process leaked sub-frame contexts and global objects across the context boundaries thus making it possible for apps to either maliciously or accidentally violate the contextIsolation boundary. This re-implementation binds all methods in native code directly to content::RenderFrame instances instead of relying on JS to provide a "window" with every method request. This is much more consistent with the rest of the Electron codebase and is substantially safer. * chore: un-re-order for ease of review * chore: pass isolate around instead of ErrorThrower * chore: fix rebase typo * chore: remove unused variables
38 lines
1 KiB
C++
38 lines
1 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef SHELL_COMMON_GIN_HELPER_ERROR_THROWER_H_
|
|
#define SHELL_COMMON_GIN_HELPER_ERROR_THROWER_H_
|
|
|
|
#include "base/strings/string_piece.h"
|
|
#include "v8/include/v8.h"
|
|
|
|
namespace gin_helper {
|
|
|
|
class ErrorThrower {
|
|
public:
|
|
explicit ErrorThrower(v8::Isolate* isolate);
|
|
ErrorThrower();
|
|
|
|
~ErrorThrower();
|
|
|
|
void ThrowError(base::StringPiece err_msg) const;
|
|
void ThrowTypeError(base::StringPiece err_msg) const;
|
|
void ThrowRangeError(base::StringPiece err_msg) const;
|
|
void ThrowReferenceError(base::StringPiece err_msg) const;
|
|
void ThrowSyntaxError(base::StringPiece err_msg) const;
|
|
|
|
v8::Isolate* isolate() const { return isolate_; }
|
|
|
|
private:
|
|
using ErrorGenerator =
|
|
v8::Local<v8::Value> (*)(v8::Local<v8::String> err_msg);
|
|
void Throw(ErrorGenerator gen, base::StringPiece err_msg) const;
|
|
|
|
v8::Isolate* isolate_;
|
|
};
|
|
|
|
} // namespace gin_helper
|
|
|
|
#endif // SHELL_COMMON_GIN_HELPER_ERROR_THROWER_H_
|