186301e126
* feat: enable context isolation by default * chore: set default in ctx iso getter * spec: make all specs work with the new contextIsolation default * spec: fix affinity specs * spec: update tests for new ctx iso default * spec: update tests for new ctx iso default * spec: update tests for new ctx iso default * spec: update tests for new ctx iso default * chore: move stray prod deps to dev deps * spec: update tests for new ctx iso default * turn off contextIsolation for visibility tests * turn off contextIsolation for <webview> tag nodeintegration attribute loads native modules when navigation happens Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
92 lines
2.7 KiB
TypeScript
92 lines
2.7 KiB
TypeScript
import { expect } from 'chai';
|
|
import * as path from 'path';
|
|
import * as cp from 'child_process';
|
|
import { closeAllWindows } from './window-helpers';
|
|
import { emittedOnce } from './events-helpers';
|
|
import { defer } from './spec-helpers';
|
|
import { ipcMain, BrowserWindow } from 'electron/main';
|
|
|
|
describe('ipc main module', () => {
|
|
const fixtures = path.join(__dirname, 'fixtures');
|
|
|
|
afterEach(closeAllWindows);
|
|
|
|
describe('ipc.sendSync', () => {
|
|
afterEach(() => { ipcMain.removeAllListeners('send-sync-message'); });
|
|
|
|
it('does not crash when reply is not sent and browser is destroyed', (done) => {
|
|
const w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
nodeIntegration: true,
|
|
contextIsolation: false
|
|
}
|
|
});
|
|
ipcMain.once('send-sync-message', (event) => {
|
|
event.returnValue = null;
|
|
done();
|
|
});
|
|
w.loadFile(path.join(fixtures, 'api', 'send-sync-message.html'));
|
|
});
|
|
|
|
it('does not crash when reply is sent by multiple listeners', (done) => {
|
|
const w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
nodeIntegration: true,
|
|
contextIsolation: false
|
|
}
|
|
});
|
|
ipcMain.on('send-sync-message', (event) => {
|
|
event.returnValue = null;
|
|
});
|
|
ipcMain.on('send-sync-message', (event) => {
|
|
event.returnValue = null;
|
|
done();
|
|
});
|
|
w.loadFile(path.join(fixtures, 'api', 'send-sync-message.html'));
|
|
});
|
|
});
|
|
|
|
describe('ipcMain.on', () => {
|
|
it('is not used for internals', async () => {
|
|
const appPath = path.join(fixtures, 'api', 'ipc-main-listeners');
|
|
const electronPath = process.execPath;
|
|
const appProcess = cp.spawn(electronPath, [appPath]);
|
|
|
|
let output = '';
|
|
appProcess.stdout.on('data', (data) => { output += data; });
|
|
|
|
await emittedOnce(appProcess.stdout, 'end');
|
|
|
|
output = JSON.parse(output);
|
|
expect(output).to.deep.equal(['error']);
|
|
});
|
|
|
|
it('can be replied to', async () => {
|
|
ipcMain.on('test-echo', (e, arg) => {
|
|
e.reply('test-echo', arg);
|
|
});
|
|
defer(() => {
|
|
ipcMain.removeAllListeners('test-echo');
|
|
});
|
|
|
|
const w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
nodeIntegration: true,
|
|
contextIsolation: false
|
|
}
|
|
});
|
|
w.loadURL('about:blank');
|
|
const v = await w.webContents.executeJavaScript(`new Promise((resolve, reject) => {
|
|
const { ipcRenderer } = require('electron')
|
|
ipcRenderer.send('test-echo', 'hello')
|
|
ipcRenderer.on('test-echo', (e, v) => {
|
|
resolve(v)
|
|
})
|
|
})`);
|
|
expect(v).to.equal('hello');
|
|
});
|
|
});
|
|
});
|