16f459228b
Co-authored-by: Samuel Attard <sattard@salesforce.com> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Jeremy Rose <jeremya@chromium.org>
22 lines
819 B
Diff
22 lines
819 B
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Shelley Vohr <shelley.vohr@gmail.com>
|
|
Date: Mon, 1 Jun 2020 15:30:47 -0800
|
|
Subject: fix: export zlib symbols
|
|
|
|
This patch sets ZLIB_DLL so that we properly export zlib symbols.
|
|
|
|
diff --git a/third_party/zlib/BUILD.gn b/third_party/zlib/BUILD.gn
|
|
index b85067a12bd86d54a751be119ff16c2683984d02..883d31f7264fdc4fa40c7337ec2fb94e9eaa7cb9 100644
|
|
--- a/third_party/zlib/BUILD.gn
|
|
+++ b/third_party/zlib/BUILD.gn
|
|
@@ -316,6 +316,10 @@ component("zlib") {
|
|
defines = []
|
|
deps = []
|
|
|
|
+ if (is_win) {
|
|
+ defines += [ "ZLIB_DLL" ]
|
|
+ }
|
|
+
|
|
if (!use_x86_x64_optimizations && !use_arm_neon_optimizations) {
|
|
# Apparently android_cronet bot builds with NEON disabled and
|
|
# we also should disable optimizations for iOS@x86 (a.k.a. simulator).
|