* chore: bump chromium in DEPS to 94.0.4587.0 * chore: update patches * 2823155: fix GPU video decoding capabilities enumeration Ref: https://chromium-review.googlesource.com/c/chromium/src/+/2823155 * 3041383: Reduce includes in url_request_mojom_traits.h Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3041383 * chore: bump chromium in DEPS to 94.0.4588.0 * chore: update patches * chore: bump chromium in DEPS to 94.0.4589.0 * chore: update patches * 3050633: Rename ScaleFactor to ResourceScaleFactor Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3050633 * 3048296: Create new mojo target to prevent traits header spreading Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3048296 * 3046186: Rename base::ClampToRange Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3046186 * chore: update picture-in-picture patch Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3056037 * chore: bump chromium in DEPS to 94.0.4590.0 * chore: update patches * 3057495: Fix base::NoDestructor usage in Mac KeychainPassword Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3057495 * 3056134: Remove NetworkIsolationKey unused methods Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3056134 * 3035091: [rab/gsab] Fix gsab maxByteLength after transferring to worker Adds a patch to v8 to disable a DCHECK that is also firing on node streams in child processes. Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3035091 * chore: bump chromium in DEPS to 94.0.4590.2 * chore: fix mas_no_private_api.patch Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3049052 * 3049555: [views] Add CHECK to prevent fallthrough to global NativeTheme Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3049555 * chore: empty commit * chore: fix whitespace for lint * chore: cherry-pick chromium woa fix * Revert "chore: cherry-pick chromium woa fix" This reverts commit 64f3082e2d5f93ef0e2ac5d98246532a105fd4a1. * chore: fix the build on Windows on ARM * chore: remove commented code in printing.patch * fixup! chore: remove commented code in printing.patch do not remove the new weak_ptr check * build: sync disable_use_lld_for_macos.patch Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: VerteDinde <khammond@slack-corp.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: VerteDinde <keeleymhammond@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
		
			
				
	
	
		
			146 lines
		
	
	
	
		
			5.3 KiB
			
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			146 lines
		
	
	
	
		
			5.3 KiB
			
		
	
	
	
		
			Diff
		
	
	
	
	
	
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 | 
						|
From: Cheng Zhao <zcbenz@gmail.com>
 | 
						|
Date: Thu, 20 Sep 2018 17:48:49 -0700
 | 
						|
Subject: mas: disable private window-frame APIs
 | 
						|
 | 
						|
Disable private window frame APIs (NSNextStepFrame and NSThemeFrame) for MAS
 | 
						|
build.
 | 
						|
 | 
						|
diff --git a/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm b/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
 | 
						|
index cf88f696a46ff0ac84bcf466b44d1080438426c1..7672eee30a811001a0149edfa4eed9dc6a4b11f6 100644
 | 
						|
--- a/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
 | 
						|
+++ b/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
 | 
						|
@@ -9,6 +9,7 @@
 | 
						|
 #include "components/remote_cocoa/app_shim/native_widget_ns_window_bridge.h"
 | 
						|
 #include "components/remote_cocoa/common/native_widget_ns_window_host.mojom.h"
 | 
						|
 
 | 
						|
+#ifndef MAS_BUILD
 | 
						|
 @interface NSWindow (PrivateBrowserNativeWidgetAPI)
 | 
						|
 + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle;
 | 
						|
 @end
 | 
						|
@@ -63,10 +64,13 @@ - (NSRect)_draggableFrame NS_DEPRECATED_MAC(10_10, 10_11) {
 | 
						|
 
 | 
						|
 @end
 | 
						|
 
 | 
						|
+#endif  // MAS_BUILD
 | 
						|
+
 | 
						|
 @implementation BrowserNativeWidgetWindow
 | 
						|
 
 | 
						|
 // NSWindow (PrivateAPI) overrides.
 | 
						|
 
 | 
						|
+#ifndef MAS_BUILD
 | 
						|
 + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
 | 
						|
   // - NSThemeFrame and its subclasses will be nil if it's missing at runtime.
 | 
						|
   if ([BrowserWindowFrame class])
 | 
						|
@@ -81,6 +85,8 @@ - (BOOL)_usesCustomDrawing {
 | 
						|
   return NO;
 | 
						|
 }
 | 
						|
 
 | 
						|
+#endif  // MAS_BUILD
 | 
						|
+
 | 
						|
 // Handle "Move focus to the window toolbar" configured in System Preferences ->
 | 
						|
 // Keyboard -> Shortcuts -> Keyboard. Usually Ctrl+F5. The argument (|unknown|)
 | 
						|
 // tends to just be nil.
 | 
						|
diff --git a/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm b/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
 | 
						|
index 8416c7c6e052dafb2aad61c0bd3224c36e945d23..cd356beda023ab2409b16d58ca38c70ba3674913 100644
 | 
						|
--- a/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
 | 
						|
+++ b/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
 | 
						|
@@ -4,6 +4,8 @@
 | 
						|
 
 | 
						|
 #import "components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.h"
 | 
						|
 
 | 
						|
+#ifndef MAS_BUILD
 | 
						|
+
 | 
						|
 @interface NSWindow (PrivateAPI)
 | 
						|
 + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle;
 | 
						|
 @end
 | 
						|
@@ -18,8 +20,12 @@ - (CGFloat)_titlebarHeight {
 | 
						|
 }
 | 
						|
 @end
 | 
						|
 
 | 
						|
+#endif  // MAS_BUILD
 | 
						|
+
 | 
						|
 @implementation NativeWidgetMacFramelessNSWindow
 | 
						|
 
 | 
						|
+#ifndef MAS_BUILD
 | 
						|
+
 | 
						|
 + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
 | 
						|
   if ([NativeWidgetMacFramelessNSWindowFrame class]) {
 | 
						|
     return [NativeWidgetMacFramelessNSWindowFrame class];
 | 
						|
@@ -27,4 +33,6 @@ + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
 | 
						|
   return [super frameViewClassForStyleMask:windowStyle];
 | 
						|
 }
 | 
						|
 
 | 
						|
+#endif  // MAS_BUILD
 | 
						|
+
 | 
						|
 @end
 | 
						|
diff --git a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
 | 
						|
index 5a23ea7558814eec59eda349bc7194afcb70d01e..c9147bbe5a225291552082434e5db34239394139 100644
 | 
						|
--- a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
 | 
						|
+++ b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
 | 
						|
@@ -17,6 +17,7 @@ class NativeWidgetNSWindowBridge;
 | 
						|
 
 | 
						|
 @protocol WindowTouchBarDelegate;
 | 
						|
 
 | 
						|
+#ifndef MAS_BUILD
 | 
						|
 // Weak lets Chrome launch even if a future macOS doesn't have the below classes
 | 
						|
 WEAK_IMPORT_ATTRIBUTE
 | 
						|
 @interface NSNextStepFrame : NSView
 | 
						|
@@ -33,6 +34,7 @@ REMOTE_COCOA_APP_SHIM_EXPORT
 | 
						|
 REMOTE_COCOA_APP_SHIM_EXPORT
 | 
						|
 @interface NativeWidgetMacNSWindowTitledFrame : NSThemeFrame
 | 
						|
 @end
 | 
						|
+#endif
 | 
						|
 
 | 
						|
 // The NSWindow used by BridgedNativeWidget. Provides hooks into AppKit that
 | 
						|
 // can only be accomplished by overriding methods.
 | 
						|
diff --git a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
 | 
						|
index 83e08e8e56f8fdfe5c321c33b451b9bde8ee819a..f48d8ac4816e2d775c16758e086eb56ad456bd01 100644
 | 
						|
--- a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
 | 
						|
+++ b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
 | 
						|
@@ -16,7 +16,9 @@
 | 
						|
 #import "ui/base/cocoa/window_size_constants.h"
 | 
						|
 
 | 
						|
 @interface NSWindow (Private)
 | 
						|
+#ifndef MAS_BUILD
 | 
						|
 + (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle;
 | 
						|
+#endif
 | 
						|
 - (BOOL)hasKeyAppearance;
 | 
						|
 - (long long)_resizeDirectionForMouseLocation:(CGPoint)location;
 | 
						|
 - (BOOL)_isConsideredOpenForPersistentState;
 | 
						|
@@ -48,6 +50,8 @@ - (void)cr_mouseDownOnFrameView:(NSEvent*)event {
 | 
						|
 }
 | 
						|
 @end
 | 
						|
 
 | 
						|
+#ifndef MAS_BUILD
 | 
						|
+
 | 
						|
 @implementation NativeWidgetMacNSWindowTitledFrame
 | 
						|
 - (void)mouseDown:(NSEvent*)event {
 | 
						|
   if (self.window.isMovable)
 | 
						|
@@ -74,6 +78,8 @@ - (BOOL)usesCustomDrawing {
 | 
						|
 }
 | 
						|
 @end
 | 
						|
 
 | 
						|
+#endif  // MAS_BUILD
 | 
						|
+
 | 
						|
 @implementation NativeWidgetMacNSWindow {
 | 
						|
  @private
 | 
						|
   base::scoped_nsobject<CommandDispatcher> _commandDispatcher;
 | 
						|
@@ -186,6 +192,8 @@ - (BOOL)hasViewsMenuActive {
 | 
						|
 
 | 
						|
 // NSWindow overrides.
 | 
						|
 
 | 
						|
+#ifndef MAS_BUILD
 | 
						|
+
 | 
						|
 + (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle {
 | 
						|
   if (windowStyle & NSWindowStyleMaskTitled) {
 | 
						|
     if (Class customFrame = [NativeWidgetMacNSWindowTitledFrame class])
 | 
						|
@@ -197,6 +205,8 @@ + (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle {
 | 
						|
   return [super frameViewClassForStyleMask:windowStyle];
 | 
						|
 }
 | 
						|
 
 | 
						|
+#endif
 | 
						|
+
 | 
						|
 - (BOOL)_isTitleHidden {
 | 
						|
   bool shouldShowWindowTitle = YES;
 | 
						|
   if (_bridge)
 |