64ba8feb93
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: Jeremy Rose <jeremya@chromium.org>
41 lines
1.2 KiB
Diff
41 lines
1.2 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jeremy Apthorp <nornagon@nornagon.net>
|
|
Date: Tue, 16 Apr 2019 10:43:04 -0700
|
|
Subject: build_gn.patch
|
|
|
|
We force V8 into 'shared library' mode so that it exports its symbols, which is
|
|
necessary for native modules to load.
|
|
|
|
Also, some fixes relating to mksnapshot on ARM.
|
|
|
|
diff --git a/BUILD.gn b/BUILD.gn
|
|
index d3e7c8378c5d22f1c7c2595fa75c79b13084e6ae..839cd37e41d55a4a63e49b3389a500feae985f39 100644
|
|
--- a/BUILD.gn
|
|
+++ b/BUILD.gn
|
|
@@ -549,7 +549,7 @@ config("internal_config") {
|
|
":cppgc_header_features",
|
|
]
|
|
|
|
- if (is_component_build) {
|
|
+ if (is_component_build || is_electron_build) {
|
|
defines += [ "BUILDING_V8_SHARED" ]
|
|
}
|
|
}
|
|
@@ -5339,7 +5339,7 @@ if (current_toolchain == v8_generator_toolchain) {
|
|
"src/interpreter/bytecodes.h",
|
|
]
|
|
|
|
- configs = [ ":internal_config" ]
|
|
+ configs = [ ":internal_config_base" ]
|
|
|
|
deps = [
|
|
":v8_libbase",
|
|
@@ -5377,6 +5377,8 @@ if (current_toolchain == v8_snapshot_toolchain) {
|
|
|
|
configs = [ ":internal_config" ]
|
|
|
|
+ configs += [ "//electron/build/config:build_time_executable" ]
|
|
+
|
|
deps = [
|
|
":v8_base_without_compiler",
|
|
":v8_compiler_for_mksnapshot",
|