62da00e5c5
* chore: bump chromium in DEPS to 7f366dc6e2f06228b12b021cc1486a1de81a257d * chore: bump chromium in DEPS to d785c1a601f5f33627d23e40b1ed9dd94c63d818 * update patches * Rename an old referrer policy value https://chromium-review.googlesource.com/c/chromium/src/+/2082856 * chore: bump chromium in DEPS to 735e0d2910b2e55c15e0b9cb9fca9431307ac661 * update v8 patches * Update DEPS * update patches * chore: bump chromium in DEPS to b3d09c15c4460680b85218b7b0eb0849c5a6e840 * Replace blink::WebCursorInfo with ui::Cursor https://chromium-review.googlesource.com/c/chromium/src/+/1997138 * chore: bump chromium in DEPS to bf433ad6dcfcaac460512bb45a53d5a2ea5356f9 * chore: bump chromium in DEPS to 38fad190ac908b6977ab271acc82c2fe74f6e85e * chore: bump chromium in DEPS to aa597178119cb37ab54caeda27b2ef30a2f9a003 * update patches * DownloadURLParameters: Remove NetworkIsolationKey parameter. https://chromium-review.googlesource.com/c/chromium/src/+/2050987 * fix pdf viewer tests by binding more mojo things * chore: bump chromium in DEPS to 08835601be331b4a223e6e2bd9d5ce6c37cbdec6 Co-authored-by: Jeremy Apthorp <jeremya@chromium.org> Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
84 lines
3.5 KiB
Diff
84 lines
3.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jeremy Apthorp <nornagon@nornagon.net>
|
|
Date: Wed, 28 Nov 2018 13:20:27 -0800
|
|
Subject: support_mixed_sandbox_with_zygote.patch
|
|
|
|
On Linux, Chromium launches all new renderer processes via a "zygote"
|
|
process which has the sandbox pre-initialized (see
|
|
//docs/linux_zygote.md). In order to support mixed-sandbox mode, in
|
|
which some renderers are launched with the sandbox engaged and others
|
|
without it, we need the option to launch non-sandboxed renderers without
|
|
going through the zygote.
|
|
|
|
Chromium already supports a `--no-zygote` flag, but it turns off the
|
|
zygote completely, and thus also disables sandboxing. This patch allows
|
|
the `--no-zygote` flag to affect renderer processes on a case-by-case
|
|
basis, checking immediately prior to launch whether to go through the
|
|
zygote or not based on the command-line of the to-be-launched renderer.
|
|
|
|
This patch could conceivably be upstreamed, as it does not affect
|
|
production Chromium (which does not use the `--no-zygote` flag).
|
|
However, the patch would need to be reviewed by the security team, as it
|
|
does touch a security-sensitive class.
|
|
|
|
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
|
|
index ab4955c9ccec6653f15a8b358b512f29aa7989a3..c4c55c26bf00373502d319536433485b851af5b0 100644
|
|
--- a/content/browser/renderer_host/render_process_host_impl.cc
|
|
+++ b/content/browser/renderer_host/render_process_host_impl.cc
|
|
@@ -416,6 +416,11 @@ class RendererSandboxedProcessLauncherDelegate
|
|
{
|
|
}
|
|
|
|
+#if BUILDFLAG(USE_ZYGOTE_HANDLE)
|
|
+ RendererSandboxedProcessLauncherDelegate(bool use_zygote):
|
|
+ use_zygote_(use_zygote) {}
|
|
+#endif
|
|
+
|
|
~RendererSandboxedProcessLauncherDelegate() override {}
|
|
|
|
#if defined(OS_WIN)
|
|
@@ -437,6 +442,9 @@ class RendererSandboxedProcessLauncherDelegate
|
|
|
|
#if BUILDFLAG(USE_ZYGOTE_HANDLE)
|
|
service_manager::ZygoteHandle GetZygote() override {
|
|
+ if (!use_zygote_) {
|
|
+ return nullptr;
|
|
+ }
|
|
const base::CommandLine& browser_command_line =
|
|
*base::CommandLine::ForCurrentProcess();
|
|
base::CommandLine::StringType renderer_prefix =
|
|
@@ -451,10 +459,13 @@ class RendererSandboxedProcessLauncherDelegate
|
|
return service_manager::SandboxType::kRenderer;
|
|
}
|
|
|
|
-#if defined(OS_WIN)
|
|
private:
|
|
+#if defined(OS_WIN)
|
|
const bool renderer_code_integrity_enabled_;
|
|
#endif
|
|
+#if BUILDFLAG(USE_ZYGOTE_HANDLE)
|
|
+ bool use_zygote_ = true;
|
|
+#endif
|
|
};
|
|
|
|
const char kSessionStorageHolderKey[] = "kSessionStorageHolderKey";
|
|
@@ -1792,11 +1803,18 @@ bool RenderProcessHostImpl::Init() {
|
|
cmd_line->PrependWrapper(renderer_prefix);
|
|
AppendRendererCommandLine(cmd_line.get());
|
|
|
|
+#if BUILDFLAG(USE_ZYGOTE_HANDLE)
|
|
+ bool use_zygote = !cmd_line->HasSwitch(switches::kNoZygote);
|
|
+ auto delegate = std::make_unique<RendererSandboxedProcessLauncherDelegate>(use_zygote);
|
|
+#else
|
|
+ auto delegate = std::make_unique<RendererSandboxedProcessLauncherDelegate>();
|
|
+#endif
|
|
+
|
|
// Spawn the child process asynchronously to avoid blocking the UI thread.
|
|
// As long as there's no renderer prefix, we can use the zygote process
|
|
// at this stage.
|
|
child_process_launcher_ = std::make_unique<ChildProcessLauncher>(
|
|
- std::make_unique<RendererSandboxedProcessLauncherDelegate>(),
|
|
+ std::move(delegate),
|
|
std::move(cmd_line), GetID(), this, std::move(mojo_invitation_),
|
|
base::BindRepeating(&RenderProcessHostImpl::OnMojoError, id_),
|
|
GetV8SnapshotFilesToPreload());
|