electron/shell/browser/api
Charles Kerr 6293bbced0
perf: avoid redundant calls to GetView() (#43216)
* perf: avoid double-calls to GetView()

There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:

if (auto* view = foo->GetView())
  view->DoSomething();

* perf: avoid discarded GetView() call
2024-08-06 11:25:59 -05:00
..
views chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_app.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_app.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_app_mac.mm chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_api_app_mas.mm chore: bump chromium to 117.0.5923.0 (main) (#39304) 2023-08-04 10:47:29 +02:00
electron_api_auto_updater.cc fix: gin_helper::MicrotasksScope instantiation (#43185) 2024-08-05 08:24:27 -05:00
electron_api_auto_updater.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_base_window.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_base_window.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_browser_window.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_browser_window.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_content_tracing.cc chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_cookies.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_cookies.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_crash_reporter.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_api_crash_reporter.h chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_api_data_pipe_holder.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_data_pipe_holder.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_debugger.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_debugger.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_desktop_capturer.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_desktop_capturer.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_dialog.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_download_item.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_download_item.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_event_emitter.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_api_event_emitter.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
electron_api_global_shortcut.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_global_shortcut.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_in_app_purchase.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_in_app_purchase.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_menu.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_menu.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_menu_mac.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_menu_mac.mm chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_menu_views.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_menu_views.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_native_theme.cc feat: add transparency checking to nativeTheme (#42862) 2024-07-24 14:38:22 +02:00
electron_api_native_theme.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_native_theme_mac.mm chore: cleanup arc migration helpers (#39606) 2023-08-23 09:54:21 -04:00
electron_api_net_log.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_net_log.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_notification.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_notification.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_power_monitor.cc feat: add thermal states to powerMonitor (#37935) 2023-04-19 11:46:55 +02:00
electron_api_power_monitor.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_power_monitor_mac.mm fix: user-did-{resign|become}-active events on macOS (#41506) 2024-03-06 12:43:39 +01:00
electron_api_power_monitor_win.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_api_power_save_blocker.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_power_save_blocker.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_printing.cc chore: remove deprecated webContents.getPrinters() (#39663) 2023-09-05 10:16:41 +02:00
electron_api_protocol.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_protocol.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_push_notifications.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_push_notifications.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_push_notifications_mac.mm chore: cleanup arc migration helpers (#39606) 2023-08-23 09:54:21 -04:00
electron_api_safe_storage.cc refactor: move safe_storage functions into anonymous namespace (#43032) 2024-07-25 13:18:13 -05:00
electron_api_screen.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_screen.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_service_worker_context.cc chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
electron_api_service_worker_context.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_session.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_session.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_system_preferences.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_system_preferences.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_system_preferences_mac.mm chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_system_preferences_win.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_api_tray.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_tray.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_utility_process.cc chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
electron_api_utility_process.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_view.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_view.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_web_contents.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_web_contents.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_web_contents_impl.cc build: remove enable_osr build flag (#38703) 2023-06-13 14:48:53 -04:00
electron_api_web_contents_mac.mm chore: bump chromium to 127.0.6521.0 (main) (#42118) 2024-06-07 17:18:35 -04:00
electron_api_web_contents_view.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_web_contents_view.h feat: customize border radius of Views (#42320) 2024-07-16 20:16:25 -04:00
electron_api_web_frame_main.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_web_frame_main.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_web_request.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_web_request.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_web_view_manager.cc chore: rename built-in modules to bindings to match naming update in node (#37182) 2023-02-09 10:31:38 +09:00
frame_subscriber.cc perf: avoid redundant calls to GetView() (#43216) 2024-08-06 11:25:59 -05:00
frame_subscriber.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
gpu_info_enumerator.cc refactor: simplify code by using base::Value::EnsureList() (#41162) 2024-01-30 14:48:09 -06:00
gpu_info_enumerator.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
gpuinfo_manager.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
gpuinfo_manager.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
message_port.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
message_port.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
process_metric.cc chore: bump chromium to 123.0.6296.0 (main) (#41204) 2024-02-14 12:33:32 -05:00
process_metric.h chore: bump chromium to 100.0.4857.0 (main) (#32419) 2022-02-09 18:58:52 -08:00
save_page_handler.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
save_page_handler.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
ui_event.cc chore: used nested namespaces (#34737) 2022-06-29 12:55:47 -07:00
ui_event.h chore: used nested namespaces (#34737) 2022-06-29 12:55:47 -07:00