aa23198ad8
* chore: in shell/renderer/renderer_client_base.h, remove include media/base/key_systems_support_registration.h
last use removed in c670e38b
(##41610)
* chore: iwyu electron/fuses.h
* chore: iwyu media/base/video_frame.h
* chore: iwyu base/functional/callback.h
* chore: iwyu base/task/cancelable_task_tracker.h
* chore: iwyu shell/browser/draggable_region_provider.h
* chore: iwyu shell/browser/ui/inspectable_web_contents_view.h
* chore: iwyu ui/aura/window.h
* chore: iwyu ui/base/win/shell.h
* chore: iwyu ui/display/win/screen_win.h
* chore: iwyu ui/gfx/geometry/insets.h
* chore: iwyu ui/display/display.h
* chore: iwyu ui/gfx/geometry/skia_conversions.h
* chore: iwyu ui/gfx/geometry/rect_conversions.h
* chore: iwyu ui/gfx/geometry/point.h
* chore: iwyu ui/gfx/scoped_canvas.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu ui/accessibility/ax_node_data.h
* chore: iwyu ui/views/animation/ink_drop_highlight.h
* chore: iwyu ui/gfx/font_list.h
* chore: iwyu ui/linux/nav_button_provider.h
* chore: iwyu shell/browser/ui/views/frameless_view.h
* chore: iwyu services/metrics/public/cpp/ukm_source_id.h
* chore: iwyu net/http/http_util.h
* chore: iwyu net/base/mime_util.h
* chore: iwyu content/public/common/content_client.h
* chore: iwyu <list>
* chore: iwyu <optional>
* chore: iwyu <memory>
* chore: iwyu base/files/file_path.h
* chore: iwyu ui/base/cursor/cursor.h
* chore: iwyu build/build_config.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/hid/hid_chooser_context.h
* chore: iwyu shell/common/platform_util.h
* chore: iwyu base/task/single_thread_task_runner.h
* chore: iwyu content/browser/renderer_host/render_widget_host_impl.h
* chore: iwyu content/public/browser/render_widget_host.h
* chore: iwyu shell/browser/electron_browser_context.h
* chore: iwyu content/public/browser/web_contents_observer.h
* chore: iwyu content/public/browser/render_frame_host.h
* chore: iwyu content/public/browser/media_stream_request.h
* chore: iwyu chrome/common/chrome_paths.h
* chore: iwyu chrome/browser/icon_manager.h
* chore: iwyu printing/print_settings.h
* chore: iwyu renderer/pepper_helper.h
* chore: iwyu shell/browser/api/process_metric.h
* chore: iwyu shell/browser/electron_browser_client.h
* chore: iwyu shell/browser/electron_browser_context.h
* chore: iwyu shell/browser/api/electron_api_session.h
* chore: iwyu shell/browser/api/electron_api_app.h
* chore: iwyu shell/browser/ui/views/client_frame_view_linux.h
* chore: iwyu shell/browser/native_window_views.h
* chore: iwyu base/win/windows_version.h
* chore: iwyu shell/common/electron_paths.h
* chore: iwyu content/public/common/content_switches.h
* chore: iwyu third_party/skia/include/core/SkRRect.h
* chore: iwyu third_party/skia/include/core/SkBitmap.h
* chore: iwyu third_party/skia
* chore: iwyu shell/browser/osr/osr_host_display_client.h
* chore: iwyu shell/browser/login_handler.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu shell/browser/event_emitter_mixin.h
* fix: mac
* fix: mac
* chore: iwyu base/nix/xdg_util.h
* fix: win
* fix: win
* fix: win
* fix: win
150 lines
5.4 KiB
C++
150 lines
5.4 KiB
C++
// Copyright (c) 2021 Slack Technologies, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "shell/common/logging.h"
|
|
|
|
#include <string>
|
|
#include <string_view>
|
|
|
|
#include "base/base_switches.h"
|
|
#include "base/command_line.h"
|
|
#include "base/environment.h"
|
|
#include "base/files/file_path.h"
|
|
#include "base/logging.h"
|
|
#include "base/path_service.h"
|
|
#include "base/strings/string_number_conversions.h"
|
|
#include "chrome/common/chrome_paths.h"
|
|
#include "content/public/common/content_switches.h"
|
|
|
|
namespace logging {
|
|
|
|
constexpr std::string_view kLogFileName{"ELECTRON_LOG_FILE"};
|
|
constexpr std::string_view kElectronEnableLogging{"ELECTRON_ENABLE_LOGGING"};
|
|
|
|
base::FilePath GetLogFileName(const base::CommandLine& command_line) {
|
|
std::string filename = command_line.GetSwitchValueASCII(switches::kLogFile);
|
|
if (filename.empty())
|
|
base::Environment::Create()->GetVar(kLogFileName, &filename);
|
|
if (!filename.empty())
|
|
return base::FilePath::FromUTF8Unsafe(filename);
|
|
|
|
const base::FilePath log_filename(FILE_PATH_LITERAL("electron_debug.log"));
|
|
base::FilePath log_path;
|
|
|
|
if (base::PathService::Get(chrome::DIR_LOGS, &log_path)) {
|
|
log_path = log_path.Append(log_filename);
|
|
return log_path;
|
|
} else {
|
|
// error with path service, just use some default file somewhere
|
|
return log_filename;
|
|
}
|
|
}
|
|
|
|
bool HasExplicitLogFile(const base::CommandLine& command_line) {
|
|
std::string filename = command_line.GetSwitchValueASCII(switches::kLogFile);
|
|
if (filename.empty())
|
|
base::Environment::Create()->GetVar(kLogFileName, &filename);
|
|
return !filename.empty();
|
|
}
|
|
|
|
LoggingDestination DetermineLoggingDestination(
|
|
const base::CommandLine& command_line,
|
|
bool is_preinit) {
|
|
bool enable_logging = false;
|
|
std::string logging_destination;
|
|
if (command_line.HasSwitch(::switches::kEnableLogging)) {
|
|
enable_logging = true;
|
|
logging_destination =
|
|
command_line.GetSwitchValueASCII(switches::kEnableLogging);
|
|
} else {
|
|
auto env = base::Environment::Create();
|
|
if (env->HasVar(kElectronEnableLogging)) {
|
|
enable_logging = true;
|
|
env->GetVar(kElectronEnableLogging, &logging_destination);
|
|
}
|
|
}
|
|
if (!enable_logging)
|
|
return LOG_NONE;
|
|
|
|
bool also_log_to_stderr = false;
|
|
#if !defined(NDEBUG)
|
|
std::string also_log_to_stderr_str;
|
|
if (base::Environment::Create()->GetVar("ELECTRON_ALSO_LOG_TO_STDERR",
|
|
&also_log_to_stderr_str) &&
|
|
!also_log_to_stderr_str.empty())
|
|
also_log_to_stderr = true;
|
|
#endif
|
|
|
|
// --enable-logging logs to stderr, --enable-logging=file logs to a file.
|
|
// NB. this differs from Chromium, in which --enable-logging logs to a file
|
|
// and --enable-logging=stderr logs to stderr, because that's how Electron
|
|
// used to work, so in order to not break anyone who was depending on
|
|
// --enable-logging logging to stderr, we preserve the old behavior by
|
|
// default.
|
|
// If --log-file or ELECTRON_LOG_FILE is specified along with
|
|
// --enable-logging, return LOG_TO_FILE.
|
|
// If we're in the pre-init phase, before JS has run, we want to avoid
|
|
// logging to the default log file, which is inside the user data directory,
|
|
// because we aren't able to accurately determine the user data directory
|
|
// before JS runs. Instead, log to stderr unless there's an explicit filename
|
|
// given.
|
|
if (HasExplicitLogFile(command_line) ||
|
|
(logging_destination == "file" && !is_preinit))
|
|
return LOG_TO_FILE | (also_log_to_stderr ? LOG_TO_STDERR : 0);
|
|
return LOG_TO_SYSTEM_DEBUG_LOG | LOG_TO_STDERR;
|
|
}
|
|
|
|
void InitElectronLogging(const base::CommandLine& command_line,
|
|
bool is_preinit) {
|
|
const std::string process_type =
|
|
command_line.GetSwitchValueASCII(::switches::kProcessType);
|
|
LoggingDestination logging_dest =
|
|
DetermineLoggingDestination(command_line, is_preinit);
|
|
LogLockingState log_locking_state = LOCK_LOG_FILE;
|
|
base::FilePath log_path;
|
|
|
|
if (command_line.HasSwitch(::switches::kLoggingLevel) &&
|
|
GetMinLogLevel() >= 0) {
|
|
std::string log_level =
|
|
command_line.GetSwitchValueASCII(::switches::kLoggingLevel);
|
|
int level = 0;
|
|
if (base::StringToInt(log_level, &level) && level >= 0 &&
|
|
level < LOGGING_NUM_SEVERITIES) {
|
|
SetMinLogLevel(level);
|
|
} else {
|
|
DLOG(WARNING) << "Bad log level: " << log_level;
|
|
}
|
|
}
|
|
|
|
// Don't resolve the log path unless we need to. Otherwise we leave an open
|
|
// ALPC handle after sandbox lockdown on Windows.
|
|
if ((logging_dest & LOG_TO_FILE) != 0) {
|
|
log_path = GetLogFileName(command_line);
|
|
} else {
|
|
log_locking_state = DONT_LOCK_LOG_FILE;
|
|
}
|
|
|
|
// On Windows, having non canonical forward slashes in log file name causes
|
|
// problems with sandbox filters, see https://crbug.com/859676
|
|
log_path = log_path.NormalizePathSeparators();
|
|
|
|
LoggingSettings settings;
|
|
settings.logging_dest = logging_dest;
|
|
settings.log_file_path = log_path.value().c_str();
|
|
settings.lock_log = log_locking_state;
|
|
// If we're logging to an explicit file passed with --log-file, we don't want
|
|
// to delete the log file on our second initialization.
|
|
settings.delete_old =
|
|
process_type.empty() && (is_preinit || !HasExplicitLogFile(command_line))
|
|
? DELETE_OLD_LOG_FILE
|
|
: APPEND_TO_OLD_LOG_FILE;
|
|
bool success = InitLogging(settings);
|
|
if (!success) {
|
|
PLOG(ERROR) << "Failed to init logging";
|
|
}
|
|
|
|
SetLogItems(true /* pid */, false, true /* timestamp */, false);
|
|
}
|
|
|
|
} // namespace logging
|