![John Kleinschmidt](/assets/img/avatar_default.png)
* build: use github actions for windows (#44136)
* build: test windows runner
* build: try build windows on windows?
* build: take win/cross changes
* build: use bash as default shell always
* build: configure git for windows build tools
* build: bash as default
* build: configure windows correctly
* build: use sha1sum
* build: force windows cipd init and python3 existence
* just pain
* build: restore cache on windows
* build: use build-tools gclient
* build: sync gclient vars to build windows job
* build: output depshash for debugging
* build: past sam was a silly goose
* build: depshash logging
* build: force lf endings for lock and DEPS
* build: platform strings are hard
* build: checkout on windows host
* sup
* no check
* idk
* sigh
* ...
* no double checkout
* build: yolo some stuff
* build: run gn-check for windows on linux hosts for speed
* use container...
* cry ?
* build: e d
* e d
* no log
* fix toolchain on windows cross check
* build: use powershell to add mksnapshot_args
* build: enable x86 and arm64 windows builds too
* clean up
* maybe not needed
* build: keep action around for post step
* build: configure git global on win
* build: ia32 zip manifest
* build: no patch depot_tools for tests
* build: get arm64 windows closer to working
* build: windows tar is ass
* 32 bit on 32 bit
* maybe bash
* build: set up nodejs
* correct windows sharding
* fix some spec runner stuff
* fix windows tests
* overwrite -Force
* sigh
* screen res
* wat
* logs
* ... more logs
* line endings will be the death of me
* remove 1080p force thing
* vsctools + logging
* disable some fullscreen tests on GHA
* no progress
* run all CI
* install visual studio on arm64
* windows hax for non windows
* maybe arm sdk
* clean up depshash logic
* build: use single check per platform
* ensure clean args
* fix loop
* remove debug
* update default build image sha for dispatch
* plzzzz
* one more try
* arm64 vctools
* sad
* build: fix non-dispatch windows gn check
* chore: debug datadog-ci location
* chore: update build-tools for newer toolchain
* chore: set path for datadog-ci
* try this
* chore: fixup gn check
* fixup gn-check some more
* fixup windows gn check
* chore: fixup windows gn check
* test: use cmd for Windows testing
* fixup use cmd for testing on Windows
* fixup windows GN check
* fixup npm config arch for x86
* Can we set test files via powershell
* fixup to set test files via powershell
* fixup set test files via powershell
* Don't check cross instance cache disk space on Windows
* Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing
* fixup Use separate step to set env variables for testing (AGAIN)
* use powershell if in powershell
* fixup use powershell if in powershell
* chore: remove no longer needed changes to depot_tools
xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5669094
and https://chromium-review.googlesource.com/c/chromium/src/+/5844046
* chore: try using 7zip on Windows to extract tarball
* Revert "chore: try using 7zip on Windows to extract tarball"
This reverts commit c7432b6a37857fd0746b8f1776fbd1103dba0b85.
* test: debug failing tests on GHA windows
* fix: ftbfs when including simdjson in Node.js
(cherry picked from commit 48e44c40d61b7aa843a990d4e0c8dec676b4ce8f)
* chore: try to track down Windows testing hang
* use correct timeout
* try this
* see if this helps
* try to figure out why node is running
* shard tests to try to narrow down WOA lockup
* try to narrow down problem test
* Narrow down blocking test more
* do we need a combo to repro
* see if this cleans up the tests
* fixup navigator.usb test
* remove logging from problematic tests
* Revert "shard tests to try to narrow down WOA lockup"
This reverts commit a1806583769678491814cb8b008131c32be4e8fb.
* remove logging
* debug keyboard test
* add timeout for Windows since arm64 sometimes hangs
* see if this helps
* put back original timeout
* try to use screenCapture to get screenshots of what is going on on WOA
* try using electron screencapture to debug WOA hang
* chore: turn off privacy experience
* run screenshot on both shards
* fixup screencap
* try to narrow down hanging spec
* chore: cleanup servers left open
* cleanup tests
* Revert "try to narrow down hanging spec"
This reverts commit a0f959f5382f4012a9919ac535d42c5333eb7d5f.
* cleanup test debugging
* fixup extensions spec
* cleanup unneeded items
* run wtf with 2 shards instead of 6
* Revert "run wtf with 2 shards instead of 6"
This reverts commit ca2d282129ee42c535d80f9876d6fa0dc6c08344.
* debug windows version on woa
* dump more info
* Get detailed CPU info
* revert debugging
* use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* fixup use same args as AppVeyor WOA for GHA WOA
* try to track down which tests trigger hang
* one or more of these combinations should hang
* break up web contents spec to find hang
* further break down api-web-contents to find hang
* test: ensure all webContents are closed
* test: fix require is not defined error
* see if api-web-contents spec is now good
* test: ensure all webContents are closed
* Revert "try to track down which tests trigger hang"
This reverts commit 07298d6ffeb4873ef7615a8ec3d1a6696e354ff4.
* chore: use alternate location for windows toolchain
* Reapply "try to track down which tests trigger hang"
This reverts commit 0321f76d01069ef325339b6fe6ed39700eae2b6b.
* try to narrow down problem test
* fix TEST_SHARD env var
* no, really fix TEST_SHARD env var
* see if this fixes it
* test: cleanup any remaining windows and webcontents
* see if new cleanup helps
* dont destroy webcontents for now
* fixup dont destroy webcontents for now
* Only cleanup right before process.exit
* see if this fixes the hang
* actually destroy webcontents
* Revert "Reapply "try to track down which tests trigger hang""
This reverts commit cdee7de049ce6bb5f67bbcc64882c56aa2c73027.
* see if this helps
* Revert "see if this helps"
This reverts commit 9a15a69cf7dbc456db7a61efa5b6870535bae993.
* Is it all about the web contents?
* it is all about the webcontents
but which one?
* Narrow down problem webcontents test
* try to speed up git install on WOA
* disable problematic test on WOA
* remove debugging
* remove debugging from choco installs
* Revert "disable problematic test on WOA"
This reverts commit e060fb0839b73d53cfde1f8acdca634f8e267937.
* Revert "remove debugging"
This reverts commit f18dd8b1a555f56bb06d0ea996a6eff31b424bf1.
* run against all the tests in the failing shard
* don't run visibility tests first
* remove debugging
* 3 is a magic number
* Revert "3 is a magic number"
This reverts commit 36b91ccf9f03a4b34230cd69ceca482f7d8428c1.
* match what Appveyor runs exactly
* Revert "match what Appveyor runs exactly"
This reverts commit 7260dd432216c62696e4bc864930f17c857eabbe.
* chore: sort files alphabetically
* find out what spec is leaving stuff open
* chore: Checkout PR HEAD commit
instead of merge commit
* try using app.exit instead of process.exit
* test: cleanup BrowserWindows and webContents
* Revert "chore: sort files alphabetically"
This reverts commit d9e217ffb1522076e150fce9e43a31bf56716acb.
* chore: use win32 to match process.platform
Needed for build-tools to download from PRs
* chore: cache yarn dir
* fixup cache yarn
* fixup use win32 to match process.platform
* fixup use win32 to match process.platform
* fixup cache yarn
* Add debugging for WOA hang
* Add debugging for failing keyboard lock test
* Revert "Add debugging for WOA hang"
This reverts commit 8df03d568d15a269e4026140d1158e8cdf551dec.
* try using process.kill
* add more debugging to keyboard.lock test
* Revert "Add debugging for failing keyboard lock test"
* remove debugging
* test: disable keyboard.lock on Windows
* test: disable fullscreen tests on Windows
* test: only force test suite exit on WOA
* fixup test: only force test suite exit on WOA
* cleanup tests
* extract yarn caching/install to action
* try using bash to run windows tests
* remove left over debugging
* standardize on 'win' for Windows builds
* use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
* fixup use 'x86' for arch for manifest files
* standardize on 'win' for Windows builds
* fixup use 'x86' for arch for manifest files
* fixup try using bash to run windows tests
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
(cherry picked from commit be1a3dce83
)
* chore: update build tools to correct sha
---------
Co-authored-by: Samuel Attard <sam@electronjs.org>
117 lines
3.7 KiB
Python
117 lines
3.7 KiB
Python
#!/usr/bin/env python3
|
|
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
import zipfile
|
|
|
|
EXTENSIONS_TO_SKIP = [
|
|
'.pdb',
|
|
'.mojom.js',
|
|
'.mojom-lite.js',
|
|
'.info',
|
|
'.m.js',
|
|
|
|
# These are only needed for Chromium tests we don't run. Listed in
|
|
# 'extensions' because the mksnapshot zip has these under a subdirectory, and
|
|
# the PATHS_TO_SKIP is checked with |startswith|.
|
|
'dbgcore.dll',
|
|
'dbghelp.dll',
|
|
]
|
|
|
|
PATHS_TO_SKIP = [
|
|
# Skip because it is an output of //ui/gl that we don't need.
|
|
'angledata',
|
|
# Skip because these are outputs that we don't need.
|
|
'./libVkICD_mock_',
|
|
# Skip because these are outputs that we don't need.
|
|
'./VkICD_mock_',
|
|
# Skip because its an output of create_bundle from
|
|
# //build/config/mac/rules.gni that we don't need
|
|
'Electron.dSYM',
|
|
# Refs https://chromium-review.googlesource.com/c/angle/angle/+/2425197.
|
|
# Remove this when Angle themselves remove the file:
|
|
# https://issuetracker.google.com/issues/168736059
|
|
'gen/angle/angle_commit.h',
|
|
# //chrome/browser:resources depends on this via
|
|
# //chrome/browser/resources/ssl/ssl_error_assistant, but we don't need to
|
|
# ship it.
|
|
'pyproto',
|
|
# Skip because these are outputs that we don't need.
|
|
'resources/inspector',
|
|
'gen/third_party/devtools-frontend/src',
|
|
'gen/ui/webui',
|
|
]
|
|
|
|
def skip_path(dep, dist_zip, target_cpu):
|
|
# Skip specific paths and extensions as well as the following special case:
|
|
# snapshot_blob.bin is a dependency of mksnapshot.zip because
|
|
# v8_context_generator needs it, but this file does not get generated for arm
|
|
# and arm 64 binaries of mksnapshot since they are built on x64 hardware.
|
|
# Consumers of arm and arm64 mksnapshot can generate snapshot_blob.bin
|
|
# themselves by running mksnapshot.
|
|
should_skip = (
|
|
any(dep.startswith(path) for path in PATHS_TO_SKIP) or
|
|
any(dep.endswith(ext) for ext in EXTENSIONS_TO_SKIP) or
|
|
(
|
|
"arm" in target_cpu
|
|
and dist_zip == "mksnapshot.zip"
|
|
and dep == "snapshot_blob.bin"
|
|
)
|
|
)
|
|
if should_skip and os.environ.get('ELECTRON_DEBUG_ZIP_SKIP') == '1':
|
|
print("Skipping {}".format(dep))
|
|
return should_skip
|
|
|
|
def execute(argv):
|
|
try:
|
|
output = subprocess.check_output(argv, stderr=subprocess.STDOUT)
|
|
return output
|
|
except subprocess.CalledProcessError as e:
|
|
print(e.output)
|
|
raise e
|
|
|
|
def main(argv):
|
|
dist_zip, runtime_deps, target_cpu, _, flatten_val, flatten_relative_to = argv
|
|
should_flatten = flatten_val == "true"
|
|
dist_files = set()
|
|
with open(runtime_deps) as f:
|
|
for dep in f.readlines():
|
|
dep = dep.strip()
|
|
if not skip_path(dep, dist_zip, target_cpu):
|
|
dist_files.add(dep)
|
|
if sys.platform == 'darwin' and not should_flatten:
|
|
execute(['zip', '-r', '-y', dist_zip] + list(dist_files))
|
|
else:
|
|
with zipfile.ZipFile(
|
|
dist_zip, 'w', zipfile.ZIP_DEFLATED, allowZip64=True
|
|
) as z:
|
|
for dep in dist_files:
|
|
if os.path.isdir(dep):
|
|
for root, _, files in os.walk(dep):
|
|
for filename in files:
|
|
z.write(os.path.join(root, filename))
|
|
else:
|
|
basename = os.path.basename(dep)
|
|
dirname = os.path.dirname(dep)
|
|
arcname = (
|
|
os.path.join(dirname, 'chrome-sandbox')
|
|
if basename == 'chrome_sandbox'
|
|
else dep
|
|
)
|
|
name_to_write = arcname
|
|
if should_flatten:
|
|
if flatten_relative_to:
|
|
if name_to_write.startswith(flatten_relative_to):
|
|
name_to_write = name_to_write[len(flatten_relative_to):]
|
|
else:
|
|
name_to_write = os.path.basename(arcname)
|
|
else:
|
|
name_to_write = os.path.basename(arcname)
|
|
z.write(
|
|
dep,
|
|
name_to_write,
|
|
)
|
|
|
|
if __name__ == '__main__':
|
|
sys.exit(main(sys.argv[1:]))
|