58a6fe13d6
* feat: add support for node / preloads in subframes This feature has delibrately been built / implemented in such a way that it has minimum impact on existing apps / code-paths. Without enabling the new "nodeSupportInSubFrames" option basically none of this new code will be hit. The things that I believe need extra scrutiny are: * Introduction of `event.reply` for IPC events and usage of `event.reply` instead of `event.sender.send()` * Usage of `node::FreeEnvironment(env)` when the new option is enabled in order to avoid memory leaks. I have tested this quite a bit and haven't managed to cause a crash but it is still feature flagged behind the "nodeSupportInSubFrames" flag to avoid potential impact. Closes #10569 Closes #10401 Closes #11868 Closes #12505 Closes #14035 * feat: add support preloads in subframes for sandboxed renderers * spec: add tests for new nodeSupportInSubFrames option * spec: fix specs for .reply and ._replyInternal for internal messages * chore: revert change to use flag instead of environment set size * chore: clean up subframe impl * chore: apply suggestions from code review Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com> * chore: clean up reply usage * chore: fix TS docs generation * chore: cleanup after rebase * chore: rename wrap to add in event fns
226 lines
8 KiB
C++
226 lines
8 KiB
C++
// Copyright (c) 2013 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "atom/renderer/atom_renderer_client.h"
|
|
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "atom/common/api/atom_bindings.h"
|
|
#include "atom/common/api/event_emitter_caller.h"
|
|
#include "atom/common/asar/asar_util.h"
|
|
#include "atom/common/node_bindings.h"
|
|
#include "atom/common/options_switches.h"
|
|
#include "atom/renderer/atom_render_frame_observer.h"
|
|
#include "atom/renderer/web_worker_observer.h"
|
|
#include "base/command_line.h"
|
|
#include "content/public/renderer/render_frame.h"
|
|
#include "native_mate/dictionary.h"
|
|
#include "third_party/blink/public/web/web_document.h"
|
|
#include "third_party/blink/public/web/web_local_frame.h"
|
|
|
|
#include "atom/common/node_includes.h"
|
|
#include "third_party/electron_node/src/node_native_module.h"
|
|
|
|
namespace atom {
|
|
|
|
namespace {
|
|
|
|
bool IsDevToolsExtension(content::RenderFrame* render_frame) {
|
|
return static_cast<GURL>(render_frame->GetWebFrame()->GetDocument().Url())
|
|
.SchemeIs("chrome-extension");
|
|
}
|
|
|
|
} // namespace
|
|
|
|
AtomRendererClient::AtomRendererClient()
|
|
: node_bindings_(NodeBindings::Create(NodeBindings::RENDERER)),
|
|
atom_bindings_(new AtomBindings(uv_default_loop())) {}
|
|
|
|
AtomRendererClient::~AtomRendererClient() {
|
|
asar::ClearArchives();
|
|
}
|
|
|
|
void AtomRendererClient::RenderThreadStarted() {
|
|
RendererClientBase::RenderThreadStarted();
|
|
}
|
|
|
|
void AtomRendererClient::RenderFrameCreated(
|
|
content::RenderFrame* render_frame) {
|
|
new AtomRenderFrameObserver(render_frame, this);
|
|
RendererClientBase::RenderFrameCreated(render_frame);
|
|
}
|
|
|
|
void AtomRendererClient::RenderViewCreated(content::RenderView* render_view) {
|
|
RendererClientBase::RenderViewCreated(render_view);
|
|
}
|
|
|
|
void AtomRendererClient::RunScriptsAtDocumentStart(
|
|
content::RenderFrame* render_frame) {
|
|
// Inform the document start pharse.
|
|
v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
node::Environment* env = GetEnvironment(render_frame);
|
|
if (env)
|
|
mate::EmitEvent(env->isolate(), env->process_object(), "document-start");
|
|
}
|
|
|
|
void AtomRendererClient::RunScriptsAtDocumentEnd(
|
|
content::RenderFrame* render_frame) {
|
|
// Inform the document end pharse.
|
|
v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
node::Environment* env = GetEnvironment(render_frame);
|
|
if (env)
|
|
mate::EmitEvent(env->isolate(), env->process_object(), "document-end");
|
|
}
|
|
|
|
void AtomRendererClient::DidCreateScriptContext(
|
|
v8::Handle<v8::Context> context,
|
|
content::RenderFrame* render_frame) {
|
|
RendererClientBase::DidCreateScriptContext(context, render_frame);
|
|
|
|
// TODO(zcbenz): Do not create Node environment if node integration is not
|
|
// enabled.
|
|
|
|
// Do not load node if we're aren't a main frame or a devtools extension
|
|
// unless node support has been explicitly enabled for sub frames
|
|
bool is_main_frame =
|
|
render_frame->IsMainFrame() && !render_frame->GetWebFrame()->Opener();
|
|
bool is_devtools = IsDevToolsExtension(render_frame);
|
|
bool allow_node_in_subframes =
|
|
base::CommandLine::ForCurrentProcess()->HasSwitch(
|
|
switches::kNodeIntegrationInSubFrames);
|
|
bool should_load_node =
|
|
is_main_frame || is_devtools || allow_node_in_subframes;
|
|
if (!should_load_node) {
|
|
return;
|
|
}
|
|
|
|
injected_frames_.insert(render_frame);
|
|
|
|
// If this is the first environment we are creating, prepare the node
|
|
// bindings.
|
|
if (!node_integration_initialized_) {
|
|
node_integration_initialized_ = true;
|
|
node_bindings_->Initialize();
|
|
node_bindings_->PrepareMessageLoop();
|
|
}
|
|
|
|
// Setup node tracing controller.
|
|
if (!node::tracing::TraceEventHelper::GetAgent())
|
|
node::tracing::TraceEventHelper::SetAgent(node::CreateAgent());
|
|
|
|
// Setup node environment for each window.
|
|
node::Environment* env = node_bindings_->CreateEnvironment(context);
|
|
environments_.insert(env);
|
|
|
|
// Add Electron extended APIs.
|
|
atom_bindings_->BindTo(env->isolate(), env->process_object());
|
|
AddRenderBindings(env->isolate(), env->process_object());
|
|
mate::Dictionary process_dict(env->isolate(), env->process_object());
|
|
process_dict.SetReadOnly("isMainFrame", render_frame->IsMainFrame());
|
|
|
|
// Load everything.
|
|
node_bindings_->LoadEnvironment(env);
|
|
|
|
if (node_bindings_->uv_env() == nullptr) {
|
|
// Make uv loop being wrapped by window context.
|
|
node_bindings_->set_uv_env(env);
|
|
|
|
// Give the node loop a run to make sure everything is ready.
|
|
node_bindings_->RunMessageLoop();
|
|
}
|
|
}
|
|
|
|
void AtomRendererClient::WillReleaseScriptContext(
|
|
v8::Handle<v8::Context> context,
|
|
content::RenderFrame* render_frame) {
|
|
if (injected_frames_.find(render_frame) == injected_frames_.end())
|
|
return;
|
|
injected_frames_.erase(render_frame);
|
|
|
|
node::Environment* env = node::Environment::GetCurrent(context);
|
|
if (environments_.find(env) == environments_.end())
|
|
return;
|
|
environments_.erase(env);
|
|
|
|
mate::EmitEvent(env->isolate(), env->process_object(), "exit");
|
|
|
|
// The main frame may be replaced.
|
|
if (env == node_bindings_->uv_env())
|
|
node_bindings_->set_uv_env(nullptr);
|
|
|
|
// Destroy the node environment. We only do this if node support has been
|
|
// enabled for sub-frames to avoid a change-of-behavior / introduce crashes
|
|
// for existing users.
|
|
// TODO(MarshallOfSOund): Free the environment regardless of this switch
|
|
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
|
|
switches::kNodeIntegrationInSubFrames))
|
|
node::FreeEnvironment(env);
|
|
|
|
// AtomBindings is tracking node environments.
|
|
atom_bindings_->EnvironmentDestroyed(env);
|
|
}
|
|
|
|
bool AtomRendererClient::ShouldFork(blink::WebLocalFrame* frame,
|
|
const GURL& url,
|
|
const std::string& http_method,
|
|
bool is_initial_navigation,
|
|
bool is_server_redirect) {
|
|
// Handle all the navigations and reloads in browser.
|
|
// FIXME We only support GET here because http method will be ignored when
|
|
// the OpenURLFromTab is triggered, which means form posting would not work,
|
|
// we should solve this by patching Chromium in future.
|
|
return http_method == "GET";
|
|
}
|
|
|
|
void AtomRendererClient::DidInitializeWorkerContextOnWorkerThread(
|
|
v8::Local<v8::Context> context) {
|
|
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
|
|
switches::kNodeIntegrationInWorker)) {
|
|
WebWorkerObserver::GetCurrent()->ContextCreated(context);
|
|
}
|
|
}
|
|
|
|
void AtomRendererClient::WillDestroyWorkerContextOnWorkerThread(
|
|
v8::Local<v8::Context> context) {
|
|
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
|
|
switches::kNodeIntegrationInWorker)) {
|
|
WebWorkerObserver::GetCurrent()->ContextWillDestroy(context);
|
|
}
|
|
}
|
|
|
|
void AtomRendererClient::SetupMainWorldOverrides(
|
|
v8::Handle<v8::Context> context,
|
|
content::RenderFrame* render_frame) {
|
|
// Setup window overrides in the main world context
|
|
// Wrap the bundle into a function that receives the isolatedWorld as
|
|
// an argument.
|
|
auto* isolate = context->GetIsolate();
|
|
std::vector<v8::Local<v8::String>> isolated_bundle_params = {
|
|
node::FIXED_ONE_BYTE_STRING(isolate, "nodeProcess"),
|
|
node::FIXED_ONE_BYTE_STRING(isolate, "isolatedWorld")};
|
|
|
|
std::vector<v8::Local<v8::Value>> isolated_bundle_args = {
|
|
GetEnvironment(render_frame)->process_object(),
|
|
GetContext(render_frame->GetWebFrame(), isolate)->Global()};
|
|
|
|
node::per_process::native_module_loader.CompileAndCall(
|
|
context, "electron/js2c/isolated_bundle", &isolated_bundle_params,
|
|
&isolated_bundle_args, nullptr);
|
|
}
|
|
|
|
node::Environment* AtomRendererClient::GetEnvironment(
|
|
content::RenderFrame* render_frame) const {
|
|
if (injected_frames_.find(render_frame) == injected_frames_.end())
|
|
return nullptr;
|
|
v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
auto context =
|
|
GetContext(render_frame->GetWebFrame(), v8::Isolate::GetCurrent());
|
|
node::Environment* env = node::Environment::GetCurrent(context);
|
|
if (environments_.find(env) == environments_.end())
|
|
return nullptr;
|
|
return env;
|
|
}
|
|
|
|
} // namespace atom
|