![Samuel Attard](/assets/img/avatar_default.png)
* build: test windows runner * build: try build windows on windows? * build: take win/cross changes * build: use bash as default shell always * build: configure git for windows build tools * build: bash as default * build: configure windows correctly * build: use sha1sum * build: force windows cipd init and python3 existence * just pain * build: restore cache on windows * build: use build-tools gclient * build: sync gclient vars to build windows job * build: output depshash for debugging * build: past sam was a silly goose * build: depshash logging * build: force lf endings for lock and DEPS * build: platform strings are hard * build: checkout on windows host * sup * no check * idk * sigh * ... * no double checkout * build: yolo some stuff * build: run gn-check for windows on linux hosts for speed * use container... * cry ? * build: e d * e d * no log * fix toolchain on windows cross check * build: use powershell to add mksnapshot_args * build: enable x86 and arm64 windows builds too * clean up * maybe not needed * build: keep action around for post step * build: configure git global on win * build: ia32 zip manifest * build: no patch depot_tools for tests * build: get arm64 windows closer to working * build: windows tar is ass * 32 bit on 32 bit * maybe bash * build: set up nodejs * correct windows sharding * fix some spec runner stuff * fix windows tests * overwrite -Force * sigh * screen res * wat * logs * ... more logs * line endings will be the death of me * remove 1080p force thing * vsctools + logging * disable some fullscreen tests on GHA * no progress * run all CI * install visual studio on arm64 * windows hax for non windows * maybe arm sdk * clean up depshash logic * build: use single check per platform * ensure clean args * fix loop * remove debug * update default build image sha for dispatch * plzzzz * one more try * arm64 vctools * sad * build: fix non-dispatch windows gn check * chore: debug datadog-ci location * chore: update build-tools for newer toolchain * chore: set path for datadog-ci * try this * chore: fixup gn check * fixup gn-check some more * fixup windows gn check * chore: fixup windows gn check * test: use cmd for Windows testing * fixup use cmd for testing on Windows * fixup windows GN check * fixup npm config arch for x86 * Can we set test files via powershell * fixup to set test files via powershell * fixup set test files via powershell * Don't check cross instance cache disk space on Windows * Use separate step to set env variables for testing * fixup Use separate step to set env variables for testing * fixup Use separate step to set env variables for testing * fixup Use separate step to set env variables for testing (AGAIN) * use powershell if in powershell * fixup use powershell if in powershell * chore: remove no longer needed changes to depot_tools xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5669094 and https://chromium-review.googlesource.com/c/chromium/src/+/5844046 * chore: try using 7zip on Windows to extract tarball * Revert "chore: try using 7zip on Windows to extract tarball" This reverts commit c7432b6a37857fd0746b8f1776fbd1103dba0b85. * test: debug failing tests on GHA windows * fix: ftbfs when including simdjson in Node.js (cherry picked from commit 48e44c40d61b7aa843a990d4e0c8dec676b4ce8f) * chore: try to track down Windows testing hang * use correct timeout * try this * see if this helps * try to figure out why node is running * shard tests to try to narrow down WOA lockup * try to narrow down problem test * Narrow down blocking test more * do we need a combo to repro * see if this cleans up the tests * fixup navigator.usb test * remove logging from problematic tests * Revert "shard tests to try to narrow down WOA lockup" This reverts commit a1806583769678491814cb8b008131c32be4e8fb. * remove logging * debug keyboard test * add timeout for Windows since arm64 sometimes hangs * see if this helps * put back original timeout * try to use screenCapture to get screenshots of what is going on on WOA * try using electron screencapture to debug WOA hang * chore: turn off privacy experience * run screenshot on both shards * fixup screencap * try to narrow down hanging spec * chore: cleanup servers left open * cleanup tests * Revert "try to narrow down hanging spec" This reverts commit a0f959f5382f4012a9919ac535d42c5333eb7d5f. * cleanup test debugging * fixup extensions spec * cleanup unneeded items * run wtf with 2 shards instead of 6 * Revert "run wtf with 2 shards instead of 6" This reverts commit ca2d282129ee42c535d80f9876d6fa0dc6c08344. * debug windows version on woa * dump more info * Get detailed CPU info * revert debugging * use same args as AppVeyor WOA for GHA WOA * fixup use same args as AppVeyor WOA for GHA WOA * fixup use same args as AppVeyor WOA for GHA WOA * try to track down which tests trigger hang * one or more of these combinations should hang * break up web contents spec to find hang * further break down api-web-contents to find hang * test: ensure all webContents are closed * test: fix require is not defined error * see if api-web-contents spec is now good * test: ensure all webContents are closed * Revert "try to track down which tests trigger hang" This reverts commit 07298d6ffeb4873ef7615a8ec3d1a6696e354ff4. * chore: use alternate location for windows toolchain * Reapply "try to track down which tests trigger hang" This reverts commit 0321f76d01069ef325339b6fe6ed39700eae2b6b. * try to narrow down problem test * fix TEST_SHARD env var * no, really fix TEST_SHARD env var * see if this fixes it * test: cleanup any remaining windows and webcontents * see if new cleanup helps * dont destroy webcontents for now * fixup dont destroy webcontents for now * Only cleanup right before process.exit * see if this fixes the hang * actually destroy webcontents * Revert "Reapply "try to track down which tests trigger hang"" This reverts commit cdee7de049ce6bb5f67bbcc64882c56aa2c73027. * see if this helps * Revert "see if this helps" This reverts commit 9a15a69cf7dbc456db7a61efa5b6870535bae993. * Is it all about the web contents? * it is all about the webcontents but which one? * Narrow down problem webcontents test * try to speed up git install on WOA * disable problematic test on WOA * remove debugging * remove debugging from choco installs * Revert "disable problematic test on WOA" This reverts commit e060fb0839b73d53cfde1f8acdca634f8e267937. * Revert "remove debugging" This reverts commit f18dd8b1a555f56bb06d0ea996a6eff31b424bf1. * run against all the tests in the failing shard * don't run visibility tests first * remove debugging * 3 is a magic number * Revert "3 is a magic number" This reverts commit 36b91ccf9f03a4b34230cd69ceca482f7d8428c1. * match what Appveyor runs exactly * Revert "match what Appveyor runs exactly" This reverts commit 7260dd432216c62696e4bc864930f17c857eabbe. * chore: sort files alphabetically * find out what spec is leaving stuff open * chore: Checkout PR HEAD commit instead of merge commit * try using app.exit instead of process.exit * test: cleanup BrowserWindows and webContents * Revert "chore: sort files alphabetically" This reverts commit d9e217ffb1522076e150fce9e43a31bf56716acb. * chore: use win32 to match process.platform Needed for build-tools to download from PRs * chore: cache yarn dir * fixup cache yarn * fixup use win32 to match process.platform * fixup use win32 to match process.platform * fixup cache yarn * Add debugging for WOA hang * Add debugging for failing keyboard lock test * Revert "Add debugging for WOA hang" This reverts commit 8df03d568d15a269e4026140d1158e8cdf551dec. * try using process.kill * add more debugging to keyboard.lock test * Revert "Add debugging for failing keyboard lock test" * remove debugging * test: disable keyboard.lock on Windows * test: disable fullscreen tests on Windows * test: only force test suite exit on WOA * fixup test: only force test suite exit on WOA * cleanup tests * extract yarn caching/install to action * try using bash to run windows tests * remove left over debugging * standardize on 'win' for Windows builds * use 'x86' for arch for manifest files * fixup try using bash to run windows tests * fixup use 'x86' for arch for manifest files * standardize on 'win' for Windows builds * fixup use 'x86' for arch for manifest files * fixup try using bash to run windows tests --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Charles Kerr <charles@charleskerr.com>
181 lines
7.7 KiB
YAML
181 lines
7.7 KiB
YAML
name: 'Checkout'
|
|
description: 'Checks out Electron and stores it in the AKS Cache'
|
|
inputs:
|
|
generate-sas-token:
|
|
description: 'Whether to generate and persist a SAS token for the item in the cache'
|
|
required: false
|
|
default: 'false'
|
|
use-cache:
|
|
description: 'Whether to persist the cache to the shared drive'
|
|
required: false
|
|
default: 'true'
|
|
runs:
|
|
using: "composite"
|
|
steps:
|
|
- name: Set GIT_CACHE_PATH to make gclient to use the cache
|
|
shell: bash
|
|
run: |
|
|
echo "GIT_CACHE_PATH=$(pwd)/git-cache" >> $GITHUB_ENV
|
|
- name: Install Dependencies
|
|
uses: ./src/electron/.github/actions/install-dependencies
|
|
- name: Install Build Tools
|
|
uses: ./src/electron/.github/actions/install-build-tools
|
|
- name: Get Depot Tools
|
|
shell: bash
|
|
run: |
|
|
if [[ ! -d depot_tools ]]; then
|
|
git clone --depth=1 https://chromium.googlesource.com/chromium/tools/depot_tools.git
|
|
|
|
# Ensure depot_tools does not update.
|
|
test -d depot_tools && cd depot_tools
|
|
touch .disable_auto_update
|
|
fi
|
|
- name: Add Depot Tools to PATH
|
|
shell: bash
|
|
run: echo "$(pwd)/depot_tools" >> $GITHUB_PATH
|
|
- name: Generate DEPS Hash
|
|
shell: bash
|
|
run: |
|
|
node src/electron/script/generate-deps-hash.js
|
|
echo "DEPSHASH=v1-src-cache-$(cat src/electron/.depshash)" >> $GITHUB_ENV
|
|
- name: Generate SAS Key
|
|
if: ${{ inputs.generate-sas-token == 'true' }}
|
|
shell: bash
|
|
run: |
|
|
curl --unix-socket /var/run/sas/sas.sock --fail "http://foo/$DEPSHASH.tar" > sas-token
|
|
- name: Save SAS Key
|
|
if: ${{ inputs.generate-sas-token == 'true' }}
|
|
uses: actions/cache/save@v4
|
|
with:
|
|
path: |
|
|
sas-token
|
|
key: sas-key-${{ github.run_number }}-${{ github.run_attempt }}
|
|
- name: Check If Cache Exists
|
|
id: check-cache
|
|
shell: bash
|
|
run: |
|
|
if [[ "${{ inputs.use-cache }}" == "false" ]]; then
|
|
echo "Not using cache this time..."
|
|
echo "cache_exists=false" >> $GITHUB_OUTPUT
|
|
else
|
|
cache_path=/mnt/cross-instance-cache/$DEPSHASH.tar
|
|
echo "Using cache key: $DEPSHASH"
|
|
echo "Checking for cache in: $cache_path"
|
|
if [ ! -f "$cache_path" ] || [ `du $cache_path | cut -f1` = "0" ]; then
|
|
echo "cache_exists=false" >> $GITHUB_OUTPUT
|
|
echo "Cache Does Not Exist for $DEPSHASH"
|
|
else
|
|
echo "cache_exists=true" >> $GITHUB_OUTPUT
|
|
echo "Cache Already Exists for $DEPSHASH, Skipping.."
|
|
fi
|
|
fi
|
|
- name: Check cross instance cache disk space
|
|
if: steps.check-cache.outputs.cache_exists == 'false' && inputs.use-cache == 'true'
|
|
shell: bash
|
|
run: |
|
|
# if there is less than 20 GB free space then creating the cache might fail so exit early
|
|
freespace=`df -m /mnt/cross-instance-cache | grep -w /mnt/cross-instance-cache | awk '{print $4}'`
|
|
freespace_human=`df -h /mnt/cross-instance-cache | grep -w /mnt/cross-instance-cache | awk '{print $4}'`
|
|
if [ $freespace -le 20000 ]; then
|
|
echo "The cross mount cache has $freespace_human free space which is not enough - exiting"
|
|
exit 1
|
|
else
|
|
echo "The cross mount cache has $freespace_human free space - continuing"
|
|
fi
|
|
- name: Gclient Sync
|
|
if: steps.check-cache.outputs.cache_exists == 'false'
|
|
shell: bash
|
|
run: |
|
|
e d gclient config \
|
|
--name "src/electron" \
|
|
--unmanaged \
|
|
${GCLIENT_EXTRA_ARGS} \
|
|
"$GITHUB_SERVER_URL/$GITHUB_REPOSITORY"
|
|
|
|
if [ "$TARGET_OS" != "" ]; then
|
|
echo "target_os=['$TARGET_OS']" >> ./.gclient
|
|
fi
|
|
|
|
ELECTRON_USE_THREE_WAY_MERGE_FOR_PATCHES=1 e d gclient sync --with_branch_heads --with_tags -vv
|
|
if [ "${{ inputs.is-release }}" != "true" && -n "${{ env.PATCH_UP_APP_CREDS }}" ]; then
|
|
# Re-export all the patches to check if there were changes.
|
|
python3 src/electron/script/export_all_patches.py src/electron/patches/config.json
|
|
cd src/electron
|
|
git update-index --refresh || true
|
|
if ! git diff-index --quiet HEAD --; then
|
|
# There are changes to the patches. Make a git commit with the updated patches
|
|
git add patches
|
|
GIT_COMMITTER_NAME="PatchUp" GIT_COMMITTER_EMAIL="73610968+patchup[bot]@users.noreply.github.com" git commit -m "chore: update patches" --author="PatchUp <73610968+patchup[bot]@users.noreply.github.com>"
|
|
# Export it
|
|
mkdir -p ../../patches
|
|
git format-patch -1 --stdout --keep-subject --no-stat --full-index > ../../patches/update-patches.patch
|
|
if node ./script/push-patch.js; then
|
|
echo
|
|
echo "======================================================================"
|
|
echo "Changes to the patches when applying, we have auto-pushed the diff to the current branch"
|
|
echo "A new CI job will kick off shortly"
|
|
echo "======================================================================"
|
|
exit 1
|
|
else
|
|
echo
|
|
echo "======================================================================"
|
|
echo "There were changes to the patches when applying."
|
|
echo "Check the CI artifacts for a patch you can apply to fix it."
|
|
echo "======================================================================"
|
|
echo
|
|
cat ../../patches/update-patches.patch
|
|
exit 1
|
|
fi
|
|
fi
|
|
fi
|
|
|
|
# delete all .git directories under src/ except for
|
|
# third_party/angle/ and third_party/dawn/ because of build time generation of files
|
|
# gen/angle/commit.h depends on third_party/angle/.git/HEAD
|
|
# https://chromium-review.googlesource.com/c/angle/angle/+/2074924
|
|
# and dawn/common/Version_autogen.h depends on third_party/dawn/.git/HEAD
|
|
# https://dawn-review.googlesource.com/c/dawn/+/83901
|
|
# TODO: maybe better to always leave out */.git/HEAD file for all targets ?
|
|
- name: Delete .git directories under src to free space
|
|
if: ${{ steps.check-cache.outputs.cache_exists == 'false' && inputs.use-cache == 'true' }}
|
|
shell: bash
|
|
run: |
|
|
cd src
|
|
( find . -type d -name ".git" -not -path "./third_party/angle/*" -not -path "./third_party/dawn/*" -not -path "./electron/*" ) | xargs rm -rf
|
|
- name: Minimize Cache Size for Upload
|
|
if: ${{ steps.check-cache.outputs.cache_exists == 'false' && inputs.use-cache == 'true' }}
|
|
shell: bash
|
|
run: |
|
|
rm -rf src/android_webview
|
|
rm -rf src/ios/chrome
|
|
rm -rf src/third_party/blink/web_tests
|
|
rm -rf src/third_party/blink/perf_tests
|
|
rm -rf src/chrome/test/data/xr/webvr_info
|
|
rm -rf src/third_party/angle/third_party/VK-GL-CTS/src
|
|
rm -rf src/third_party/swift-toolchain
|
|
rm -rf src/third_party/swiftshader/tests/regres/testlists
|
|
cp src/electron/.github/actions/checkout/action.yml ./
|
|
rm -rf src/electron
|
|
mkdir -p src/electron/.github/actions/checkout
|
|
mv action.yml src/electron/.github/actions/checkout
|
|
- name: Compress Src Directory
|
|
if: ${{ steps.check-cache.outputs.cache_exists == 'false' && inputs.use-cache == 'true' }}
|
|
shell: bash
|
|
run: |
|
|
echo "Uncompressed src size: $(du -sh src | cut -f1 -d' ')"
|
|
tar -cf $DEPSHASH.tar src
|
|
echo "Compressed src to $(du -sh $DEPSHASH.tar | cut -f1 -d' ')"
|
|
cp ./$DEPSHASH.tar /mnt/cross-instance-cache/
|
|
- name: Persist Src Cache
|
|
if: ${{ steps.check-cache.outputs.cache_exists == 'false' && inputs.use-cache == 'true' }}
|
|
shell: bash
|
|
run: |
|
|
final_cache_path=/mnt/cross-instance-cache/$DEPSHASH.tar
|
|
echo "Using cache key: $DEPSHASH"
|
|
echo "Checking path: $final_cache_path"
|
|
if [ ! -f "$final_cache_path" ]; then
|
|
echo "Cache key not found"
|
|
exit 1
|
|
else
|
|
echo "Cache key persisted in $final_cache_path"
|
|
fi
|