mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
electron/spec
History
Samuel Attard 58a6fe13d6
feat: preloads and nodeIntegration in iframes (#16425) 
* feat: add support for node / preloads in subframes

This feature has delibrately been built / implemented in such a way
that it has minimum impact on existing apps / code-paths.
Without enabling the new "nodeSupportInSubFrames" option basically none of this
new code will be hit.

The things that I believe need extra scrutiny are:

* Introduction of `event.reply` for IPC events and usage of `event.reply` instead of `event.sender.send()`
* Usage of `node::FreeEnvironment(env)` when the new option is enabled in order to avoid memory leaks.  I have tested this quite a bit and haven't managed to cause a crash but it is still feature flagged behind the "nodeSupportInSubFrames" flag to avoid potential impact.

Closes #10569
Closes #10401
Closes #11868
Closes #12505
Closes #14035

* feat: add support preloads in subframes for sandboxed renderers

* spec: add tests for new nodeSupportInSubFrames option

* spec: fix specs for .reply and ._replyInternal for internal messages

* chore: revert change to use flag instead of environment set size

* chore: clean up subframe impl

* chore: apply suggestions from code review

Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>

* chore: clean up reply usage

* chore: fix TS docs generation

* chore: cleanup after rebase

* chore: rename wrap to add in event fns
2019-01-22 11:24:46 -08:00
..
configs ci: run more Chromium unit tests (#15363) 2018-10-25 14:28:50 -04:00
fixtures feat: preloads and nodeIntegration in iframes (#16425) 2019-01-22 11:24:46 -08:00
static feat: make ipc-message and ipc-message-sync events public (#16468) 2019-01-22 08:47:58 -08:00
.eslintrc chore: replace standard with eslint-config-standard and add custom rules (#14636) 2018-09-16 03:51:23 +10:00
api-app-spec.js feat: enable mixed-sandbox mode by default (#15894) 2019-01-22 10:44:28 -08:00
api-auto-updater-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-browser-view-spec.js feat: add multi BrowserView support to BrowserWindow (#16148) 2018-12-22 10:49:26 +09:00
api-browser-window-affinity-spec.js test: promisify a bunch of tests (#16051) 2018-12-18 23:44:03 -07:00
api-browser-window-spec.js feat: enable mixed-sandbox mode by default (#15894) 2019-01-22 10:44:28 -08:00
api-callbacks-registry-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-clipboard-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-content-tracing-spec.js fix: extend tracing startRecording API to take a full tracing config (#13914) 2018-12-20 15:11:17 +03:00
api-crash-reporter-spec.js chore: make "nodeIntegration" and "webviewTag" default to false (#16235) 2019-01-07 22:19:27 +03:00
api-debugger-spec.js fix: send null in debugger callback when no error (#14814) 2018-09-27 17:43:45 +10:00
api-deprecations-spec.js chore: simplify promisify helper (#15952) 2018-12-10 08:13:09 -08:00
api-desktop-capturer-spec.js feat: promisify desktopCapturer.getSources (#16427) 2019-01-18 15:29:32 -08:00
api-dialog-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-global-shortcut-spec.js feat: allow registering multiple shortcuts (#15542) 2018-11-07 09:40:38 -08:00
api-in-app-purchase-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-ipc-main-spec.js chore: make "nodeIntegration" and "webviewTag" default to false (#16235) 2019-01-07 22:19:27 +03:00
api-ipc-renderer-spec.js fix: emit IPC event in correct context if isolation and sandbox enabled (#16352) 2019-01-12 14:19:20 +01:00
api-menu-item-spec.js fix: windowmenu did not show the window list on macOS (#16387) 2019-01-14 17:27:52 +01:00
api-menu-spec.js fix: Menu accelerators not working (#15094) 2018-11-09 13:54:16 -08:00
api-native-image-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-net-log-spec.js chore: re-enable failing netlog spec (#15484) 2018-10-30 17:45:05 -05:00
api-net-spec.js refactor: add prefer-const to .eslintrc + fix errors (#14880) 2018-10-02 11:56:31 +10:00
api-notification-dbus-spec.js chore: make "nodeIntegration" and "webviewTag" default to false (#16235) 2019-01-07 22:19:27 +03:00
api-notification-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-power-monitor-spec.js fix: power observer dbus crash (#15030) 2018-10-09 00:32:19 -05:00
api-power-save-blocker-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-process-spec.js feat: Implement process.getProcessMemoryInfo to get the process memory usage (#14847) 2018-11-28 17:57:53 +09:00
api-protocol-spec.js test: ensure legacy callback functions work (#16436) 2019-01-17 14:17:16 -08:00
api-remote-spec.js feat: split openExternal into sync and async (#16176) 2019-01-14 20:35:21 -08:00
api-screen-spec.js feat: deprecate modules internally using remote.require in sandboxed renderer context (#15145) 2018-12-05 10:34:09 +01:00
api-session-spec.js feat: upgrade to Chromium 72.0.3626.52 (#16334) 2019-01-22 10:39:32 -08:00
api-shell-spec.js feat: split openExternal into sync and async (#16176) 2019-01-14 20:35:21 -08:00
api-subframe-spec.js feat: preloads and nodeIntegration in iframes (#16425) 2019-01-22 11:24:46 -08:00
api-system-preferences-spec.js refactor: add prefer-const to .eslintrc + fix errors (#14880) 2018-10-02 11:56:31 +10:00
api-touch-bar-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-tray-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-view-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-web-contents-spec.js feat: upgrade to Chromium 72.0.3626.52 (#16334) 2019-01-22 10:39:32 -08:00
api-web-contents-view-spec.js fix: destroy WebContents synchronously on shutdown (#15541) 2018-11-08 07:57:28 -08:00
api-web-frame-spec.js chore: make "nodeIntegration" and "webviewTag" default to false (#16235) 2019-01-07 22:19:27 +03:00
api-web-request-spec.js spec: fix headers tests to match APIs 2018-09-14 17:05:26 +10:00
asar-spec.js build: fix the build with enable_run_as_node disabled (#15711) 2019-01-11 08:02:06 -08:00
assert-helpers.js spec: fix final node and chromium specs after assert change 2018-09-14 18:32:17 +10:00
BUILD.gn ci: run unittests on clean Chromium (#15125) 2018-10-22 16:12:19 -04:00
chromium-spec.js feat: make ipc-message and ipc-message-sync events public (#16468) 2019-01-22 08:47:58 -08:00
events-helpers.js feat: preloads and nodeIntegration in iframes (#16425) 2019-01-22 11:24:46 -08:00
internal-spec.js fix: make feature strings more robust to whitespace (#15602) 2018-11-06 15:52:06 -08:00
modules-spec.js feat: Upgrade to Chromium 71.0.3578.98 (#15966) 2019-01-11 17:00:43 -08:00
node-spec.js feat: Upgrade to Chromium 71.0.3578.98 (#15966) 2019-01-11 17:00:43 -08:00
package-lock.json feat: split openExternal into sync and async (#16176) 2019-01-14 20:35:21 -08:00
package.json feat: Upgrade to Chromium 71.0.3578.98 (#15966) 2019-01-11 17:00:43 -08:00
security-warnings-spec.js chore: make "nodeIntegration" and "webviewTag" default to false (#16235) 2019-01-07 22:19:27 +03:00
version-bump-spec.js test: add specs to version bump utils (#16315) 2019-01-08 12:04:27 -08:00
webview-spec.js feat: upgrade to Chromium 72.0.3626.52 (#16334) 2019-01-22 10:39:32 -08:00
window-helpers.js chore: update to standard 12 2018-09-14 14:57:01 +10:00