* chore: bump chromium to 134.0.6992.0
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add BrowserProcessImpl::CreateGlobalFeaturesForTesting() stub
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6216193
Remove GlobalFeatures from TestingBrowserProcess::Init
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: bump chromium to 134.0.6994.0
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* 6208630: Mac sandbox: don't use protobuf for policy serialization | https://chromium-review.googlesource.com/c/chromium/src/+/6208630
Co-authored-by: alice <alice@makenotion.com>
* Remove HasUnsupportedFeature Mojo interface
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6220800
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* 6217444: Remove scoped_gdi_object.h type aliases. | https://chromium-review.googlesource.com/c/chromium/src/+/6217444
Co-authored-by: alice <alice@makenotion.com>
* chore: bump chromium to 134.0.6998.10
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* 6221378: Revert [OBC] Exclude Aliasing Cookies in FilterCookiesWithOptions() | https://chromium-review.googlesource.com/c/chromium/src/+/6221378
Co-authored-by: alice <alice@makenotion.com>
* Update ExtensionPrefs::GetDisableReasons to return DisableReasonSet
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6218840
change copied from 6218840 extensions/shell/browser/shell_extension_loader.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* 6218402: Typemap ui.gfx.DXGIHandle <=> gfx::DXGIHandle | https://chromium-review.googlesource.com/c/chromium/src/+/6218402
Co-authored-by: alice <alice@makenotion.com>
* chore: disable flaky contentTracing test
not new to this roll; it is happening in main as well
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! chore: disable flaky contentTracing test
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: update patches
* chore: disable flaky content tracing tests on Linux (#45612)
(cherry picked from commit a1e4550c9e)
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
		
	
			
		
			
				
	
	
		
			76 lines
		
	
	
	
		
			3.8 KiB
			
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			76 lines
		
	
	
	
		
			3.8 KiB
			
		
	
	
	
		
			Diff
		
	
	
	
	
	
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 | 
						|
From: Samuel Attard <marshallofsound@electronjs.org>
 | 
						|
Date: Wed, 8 Mar 2023 13:04:21 -0800
 | 
						|
Subject: refactor: expose HostImportModuleDynamically and
 | 
						|
 HostGetImportMetaProperties to embedders
 | 
						|
 | 
						|
This is so that Electron can blend Blink's and Node's implementations of these isolate handlers.
 | 
						|
 | 
						|
diff --git a/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc b/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
 | 
						|
index 8754ee3db863e6346b891a7491b997d46644f3c2..ed480f47be04d5df18f01d45488537251ef6bcb6 100644
 | 
						|
--- a/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
 | 
						|
+++ b/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
 | 
						|
@@ -638,7 +638,9 @@ bool WasmJSPromiseIntegrationEnabledCallback(v8::Local<v8::Context> context) {
 | 
						|
       execution_context);
 | 
						|
 }
 | 
						|
 
 | 
						|
-v8::MaybeLocal<v8::Promise> HostImportModuleDynamically(
 | 
						|
+}
 | 
						|
+
 | 
						|
+v8::MaybeLocal<v8::Promise> V8Initializer::HostImportModuleDynamically(
 | 
						|
     v8::Local<v8::Context> context,
 | 
						|
     v8::Local<v8::Data> v8_host_defined_options,
 | 
						|
     v8::Local<v8::Value> v8_referrer_resource_url,
 | 
						|
@@ -716,7 +718,7 @@ v8::MaybeLocal<v8::Promise> HostImportModuleDynamically(
 | 
						|
 }
 | 
						|
 
 | 
						|
 // https://html.spec.whatwg.org/C/#hostgetimportmetaproperties
 | 
						|
-void HostGetImportMetaProperties(v8::Local<v8::Context> context,
 | 
						|
+void V8Initializer::HostGetImportMetaProperties(v8::Local<v8::Context> context,
 | 
						|
                                  v8::Local<v8::Module> module,
 | 
						|
                                  v8::Local<v8::Object> meta) {
 | 
						|
   v8::Isolate* isolate = context->GetIsolate();
 | 
						|
@@ -763,9 +765,6 @@ std::ostream& operator<<(std::ostream& os, const PrintV8OOM& oom_details) {
 | 
						|
   return os;
 | 
						|
 }
 | 
						|
 
 | 
						|
-}  // namespace
 | 
						|
-
 | 
						|
-// static
 | 
						|
 void V8Initializer::InitializeV8Common(v8::Isolate* isolate) {
 | 
						|
   // Set up garbage collection before setting up anything else as V8 may trigger
 | 
						|
   // GCs during Blink setup.
 | 
						|
@@ -785,9 +784,9 @@ void V8Initializer::InitializeV8Common(v8::Isolate* isolate) {
 | 
						|
   isolate->SetWasmJSPIEnabledCallback(WasmJSPromiseIntegrationEnabledCallback);
 | 
						|
   isolate->SetSharedArrayBufferConstructorEnabledCallback(
 | 
						|
       SharedArrayBufferConstructorEnabledCallback);
 | 
						|
-  isolate->SetHostImportModuleDynamicallyCallback(HostImportModuleDynamically);
 | 
						|
+  isolate->SetHostImportModuleDynamicallyCallback(V8Initializer::HostImportModuleDynamically);
 | 
						|
   isolate->SetHostInitializeImportMetaObjectCallback(
 | 
						|
-      HostGetImportMetaProperties);
 | 
						|
+      V8Initializer::HostGetImportMetaProperties);
 | 
						|
   isolate->SetIsJSApiWrapperNativeErrorCallback(IsDOMExceptionWrapper);
 | 
						|
   isolate->SetMetricsRecorder(std::make_shared<V8MetricsRecorder>(isolate));
 | 
						|
 
 | 
						|
diff --git a/third_party/blink/renderer/bindings/core/v8/v8_initializer.h b/third_party/blink/renderer/bindings/core/v8/v8_initializer.h
 | 
						|
index be5df8f98c3f7e308d79d43c1811a16c644b6158..5c25a3bb7f04ea74ee8587b158e125f4aa651912 100644
 | 
						|
--- a/third_party/blink/renderer/bindings/core/v8/v8_initializer.h
 | 
						|
+++ b/third_party/blink/renderer/bindings/core/v8/v8_initializer.h
 | 
						|
@@ -85,6 +85,17 @@ class CORE_EXPORT V8Initializer {
 | 
						|
   static void PromiseRejectHandlerInMainThread(v8::PromiseRejectMessage data);
 | 
						|
   static void ExceptionPropagationCallback(v8::ExceptionPropagationMessage);
 | 
						|
 
 | 
						|
+  static v8::MaybeLocal<v8::Promise> HostImportModuleDynamically(
 | 
						|
+    v8::Local<v8::Context> context,
 | 
						|
+    v8::Local<v8::Data> v8_host_defined_options,
 | 
						|
+    v8::Local<v8::Value> v8_referrer_resource_url,
 | 
						|
+    v8::Local<v8::String> v8_specifier,
 | 
						|
+    v8::Local<v8::FixedArray> v8_import_assertions);
 | 
						|
+
 | 
						|
+  static void HostGetImportMetaProperties(v8::Local<v8::Context> context,
 | 
						|
+                                          v8::Local<v8::Module> module,
 | 
						|
+                                          v8::Local<v8::Object> meta);
 | 
						|
+
 | 
						|
   static void WasmAsyncResolvePromiseCallback(
 | 
						|
       v8::Isolate* isolate,
 | 
						|
       v8::Local<v8::Context> context,
 |