d426b92326* refactor: avoid redundant GetIsolate() calls in NodeBindings::CreateEnvironment() Xref: https://chromium-review.googlesource.com/c/v8/v8/+/6563615 Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: use v8::Isolate::GetCurrent() in Initialize() methods Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment() Co-authored-by: Charles Kerr <charles@charleskerr.com> * fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: add v8::Isolate* arg to RendererClientBase::DidCreateScriptContext() Co-authored-by: Charles Kerr <charles@charleskerr.com> * fixup! refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment() Co-authored-by: Charles Kerr <charles@charleskerr.com> * fixup! fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods refactor: prefer JavascriptEnvironment::GetIsolate() in the browser layer Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
52 lines
1.9 KiB
C++
52 lines
1.9 KiB
C++
// Copyright (c) 2015 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "content/public/browser/browser_context.h"
|
|
#include "shell/browser/javascript_environment.h"
|
|
#include "shell/browser/web_contents_preferences.h"
|
|
#include "shell/browser/web_contents_zoom_controller.h"
|
|
#include "shell/browser/web_view_manager.h"
|
|
#include "shell/common/gin_converters/content_converter.h"
|
|
#include "shell/common/gin_helper/dictionary.h"
|
|
#include "shell/common/node_includes.h"
|
|
#include "shell/common/options_switches.h"
|
|
|
|
using electron::WebContentsPreferences;
|
|
|
|
namespace {
|
|
|
|
void AddGuest(int guest_instance_id,
|
|
content::WebContents* embedder,
|
|
content::WebContents* guest_web_contents,
|
|
const gin_helper::Dictionary& options) {
|
|
auto* manager = electron::WebViewManager::GetWebViewManager(embedder);
|
|
if (manager)
|
|
manager->AddGuest(guest_instance_id, embedder, guest_web_contents);
|
|
|
|
double zoom_factor;
|
|
if (options.Get(electron::options::kZoomFactor, &zoom_factor)) {
|
|
electron::WebContentsZoomController::FromWebContents(guest_web_contents)
|
|
->SetDefaultZoomFactor(zoom_factor);
|
|
}
|
|
}
|
|
|
|
void RemoveGuest(content::WebContents* embedder, int guest_instance_id) {
|
|
auto* manager = electron::WebViewManager::GetWebViewManager(embedder);
|
|
if (manager)
|
|
manager->RemoveGuest(guest_instance_id);
|
|
}
|
|
|
|
void Initialize(v8::Local<v8::Object> exports,
|
|
v8::Local<v8::Value> unused,
|
|
v8::Local<v8::Context> context,
|
|
void* priv) {
|
|
v8::Isolate* const isolate = electron::JavascriptEnvironment::GetIsolate();
|
|
gin_helper::Dictionary dict{isolate, exports};
|
|
dict.SetMethod("addGuest", &AddGuest);
|
|
dict.SetMethod("removeGuest", &RemoveGuest);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_browser_web_view_manager, Initialize)
|