46f3491c7d
* chore: bump chromium in DEPS to d5c9bf9e2a18fa508201a88e5803bec1d107b1ae * chore: bump chromium in DEPS to 45f1316afae33e52c92480b34bf4f7fe4a7db898 * update patches * WillCreateURLLoaderFactory now gets a ukm_source_id Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2346803 * ink_drop_visible_opacity -> GetInkDropVisibleOpacity Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415368 * chore: bump chromium in DEPS to ddb5b6db5e35ab1a7b5adbd9f15373af6c35ea2a * 2418471: PDF Viewer update: Add missing aria-labels to various buttons. https://chromium-review.googlesource.com/c/chromium/src/+/2418471 * update printing.patch given print settings mojoification Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2409467 * update patches * content::BluetoothChooser::Event -> content::BluetoothChooserEvent Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2387901 * set_ink_drop_base_color -> SetInkDropBaseColor Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2419388 * chore: bump chromium in DEPS to ecf7c9ee830d4d85f300b461a2fa13aa40c79a4c * update patches * gfx::ConvertPointToPixel -> gfx::ConvertPointToPixels Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2418568 * remove ContentSettingsObserver::AllowStorage() Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2401847 * service_manager::kCrashDumpSignal -> kCrashDumpSignal Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2417073 * chore: bump chromium in DEPS to abdb7ebe5f8c8328b8f435283df90d0a3ecff7bd * chore: bump chromium in DEPS to 2a7e138ab1066534ceb2622e8a9d2c8ebf574215 * chore: bump chromium in DEPS to ab1884e75ced904e4276851eb4e1ad89919ca93b * chore: bump chromium in DEPS to a12413902380dcc2a73ac74d582328280a8af686 * Fixup printing patch https://chromium-review.googlesource.com/c/chromium/src/+/2428623 * Fixup OSR patch https://chromium-review.googlesource.com/c/chromium/src/+/2415128 * Make ExtensionURLLoaderFactory always owned by its |receivers_|. https://chromium-review.googlesource.com/c/chromium/src/+/2357523 * Add deprecated_default_sources_assignment_filter variable https://chromium-review.googlesource.com/c/chromium/src/+/2416496 * Fixup patch indices * Remove several references to BrowserPlugin from content https://chromium-review.googlesource.com/c/chromium/src/+/2401031 * Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation https://chromium-review.googlesource.com/c/chromium/src/+/2415128 * Add DragOperation and AllowedDragOperations Mojo types https://chromium-review.googlesource.com/c/chromium/src/+/2196167 * chore: bump chromium in DEPS to 378450342cf6aa160663d0ce3a178a11b570c25a * Fixup patch indices * Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation https://chromium-review.googlesource.com/c/chromium/src/+/2415128 * Add DragOperation and AllowedDragOperations Mojo types https://chromium-review.googlesource.com/c/chromium/src/+/2196167 * 2426564: Remove global sources assignment filter value https://chromium-review.googlesource.com/c/chromium/src/+/2426564 * Fixup blink_local_frame.patch * [XProto] Remove a subset of ui/gfx/x/x11.h https://chromium-review.googlesource.com/c/chromium/src/+/2430328 * Fixup patch indices * Remove several references to BrowserPlugin from content https://chromium-review.googlesource.com/c/chromium/src/+/2401031 * Remove lossy ConvertSizeToPixel() methods https://chromium-review.googlesource.com/c/chromium/src/+/2419534 * serial: Use USB driver name to disambiguate ports https://chromium-review.googlesource.com/c/chromium/src/+/2413176 * Remove set_sources_filter import * Fix ModMask usage * [XProto] Remove usage of all Xlib headers https://chromium-review.googlesource.com/c/chromium/src/+/2392140 * [XProto] Remove usage of Xlib Visuals https://chromium-review.googlesource.com/c/chromium/src/+/2429933 * Skip Angle manifest file https://chromium-review.googlesource.com/c/angle/angle/+/2425197 * Add whole src\third_party\angle\.git directory This directory is needed in order to properly generate gen/angle/angle_commit.h * [libvpx] Fix HighBD config on Windows ARM64 https://chromium-review.googlesource.com/c/chromium/src/+/2437745 * update patches * fix: correct calling convention for Windows on Arm https://chromium-review.googlesource.com/c/v8/v8/+/2440717 * Add third_party/angle/.git to the archive before adding the rest of the source * fixup source caching on Windows * Fixup erroneous close paren * fixup for goma issues * This should work * chore: bump chromium roll manually https://chromium-review.googlesource.com/c/chromium/src/+/2435142 This landed the day after we paused roller-bot and may resolve the visibility test flakes that we're seeing. h/t to @jkleinsc for finding this with me. * chore: remove obsoleted cherry-pick fix for libvpx https://chromium-review.googlesource.com/c/chromium/src/+/2437745 * chore: remove obsoleted cherry-pick libvpx patch https://chromium-review.googlesource.com/c/chromium/src/+/2437745 * chore: re-export patches * chore: add tracer comment to visibility-stat-spec. The line numbers between the source and the CI runs don't seem to match up, so this temp tracer is to help track the source of that difference. * chore: bump chromium in DEPS to 7c2b8cc3b8638aee8abeb013042a6c1d15b2da6b * update patches * impl SortingLSH service Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2425327 * 2446525: [Flash] Remove some Flash APIs https://chromium-review.googlesource.com/c/chromium/src/+/2446525 * 2440974: Reland "Delete service_manager/embedder/switches.h" https://chromium-review.googlesource.com/c/chromium/src/+/2440974 * 2359402: Remove ContentBrowserClient::NonNetworkURLLoaderFactoryDeprecatedMap. https://chromium-review.googlesource.com/c/chromium/src/+/2359402 * 2250506: Implement tabs.removeCSS https://chromium-review.googlesource.com/c/chromium/src/+/2250506 * 2429143: Remove implicit-conversion-to-integer ConvertRectToPixel() methods. https://chromium-review.googlesource.com/c/chromium/src/+/2429143 * 2444430: Remove DataElementType::kBlob https://chromium-review.googlesource.com/c/chromium/src/+/2444430 * 2441964: Clean up WebView public API https://chromium-review.googlesource.com/c/chromium/src/+/2441964 * 2357523: Make ExtensionURLLoaderFactory always owned by its |receivers_|. https://chromium-review.googlesource.com/c/chromium/src/+/2357523 * 2461606: Use blink::mojom::PreferredColorScheme instead of blink::PreferredColorScheme https://chromium-review.googlesource.com/c/chromium/src/+/2461606 * 2461235: a11y inspect reorg: move PropertyFilter struct to a new location https://chromium-review.googlesource.com/c/chromium/src/+/2461235 * remove flash support * fix frame_host_manager patch * fix lint * remove flash info from docs * fix build * fix osr * chore: bump chromium in DEPS to 9269f9eb1d98d29564c2b2ab97f30c6e148c4e11 * fix visibilityState tests * 2463049: Replace all uses of web_pref::AutoplayPolicy with mojom::AutoplayPolicy https://chromium-review.googlesource.com/c/chromium/src/+/2463049 * update patches * fix tests harder * 2414921: Add Group and Ungroup functions to Tabs extension API https://chromium-review.googlesource.com/c/chromium/src/+/2414921 * more test fix * Remove all keyboard related usage of Xlib Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2436787 * fix linux build * 2453807: [XProto] Remove usage of Xlib error handling https://chromium-review.googlesource.com/c/chromium/src/+/2453807 * lint * fixup! 2453807: [XProto] Remove usage of Xlib error handling * disable CalculateNativeWinOcclusion on win ci * remove UploadBlob from docs * Update appveyor.yml Co-authored-by: Andy Locascio <andy@slack-corp.com> Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Jeremy Rose <nornagon@nornagon.net> Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: Jeremy Rose <jeremya@chromium.org>
183 lines
5.8 KiB
TypeScript
183 lines
5.8 KiB
TypeScript
import { expect } from 'chai';
|
|
import * as cp from 'child_process';
|
|
import { BrowserWindow, BrowserWindowConstructorOptions, ipcMain } from 'electron/main';
|
|
import * as path from 'path';
|
|
|
|
import { emittedOnce } from './events-helpers';
|
|
import { closeWindow } from './window-helpers';
|
|
import { ifdescribe, delay } from './spec-helpers';
|
|
|
|
// visibilityState specs pass on linux with a real window manager but on CI
|
|
// the environment does not let these specs pass
|
|
ifdescribe(process.platform !== 'linux')('document.visibilityState', () => {
|
|
let w: BrowserWindow;
|
|
|
|
afterEach(() => {
|
|
return closeWindow(w);
|
|
});
|
|
|
|
const load = () => w.loadFile(path.resolve(__dirname, 'fixtures', 'chromium', 'visibilitystate.html'));
|
|
|
|
const itWithOptions = (name: string, options: BrowserWindowConstructorOptions, fn: Mocha.Func) => {
|
|
return it(name, async function (...args) {
|
|
w = new BrowserWindow({
|
|
...options,
|
|
paintWhenInitiallyHidden: false,
|
|
webPreferences: {
|
|
...(options.webPreferences || {}),
|
|
nodeIntegration: true
|
|
}
|
|
});
|
|
await Promise.resolve(fn.apply(this, args));
|
|
});
|
|
};
|
|
|
|
itWithOptions('should be visible when the window is initially shown by default', {}, async () => {
|
|
load();
|
|
const [, state] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(state).to.equal('visible');
|
|
});
|
|
|
|
itWithOptions('should be visible when the window is initially shown', {
|
|
show: true
|
|
}, async () => {
|
|
load();
|
|
const [, state] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(state).to.equal('visible');
|
|
});
|
|
|
|
itWithOptions('should be hidden when the window is initially hidden', {
|
|
show: false
|
|
}, async () => {
|
|
load();
|
|
const [, state] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(state).to.equal('hidden');
|
|
});
|
|
|
|
itWithOptions('should be visible when the window is initially hidden but shown before the page is loaded', {
|
|
show: false
|
|
}, async () => {
|
|
w.show();
|
|
load();
|
|
const [, state] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(state).to.equal('visible');
|
|
});
|
|
|
|
itWithOptions('should be hidden when the window is initially shown but hidden before the page is loaded', {
|
|
show: true
|
|
}, async () => {
|
|
// TODO(MarshallOfSound): Figure out if we can work around this 1 tick issue for users
|
|
if (process.platform === 'darwin') {
|
|
// Wait for a tick, the window being "shown" takes 1 tick on macOS
|
|
await delay(0);
|
|
}
|
|
w.hide();
|
|
load();
|
|
const [, state] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(state).to.equal('hidden');
|
|
});
|
|
|
|
itWithOptions('should be toggle between visible and hidden as the window is hidden and shown', {}, async () => {
|
|
load();
|
|
const [, initialState] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(initialState).to.equal('visible');
|
|
w.hide();
|
|
await emittedOnce(ipcMain, 'visibility-change-hidden');
|
|
w.show();
|
|
await emittedOnce(ipcMain, 'visibility-change-visible');
|
|
});
|
|
|
|
itWithOptions('should become hidden when a window is minimized', {}, async () => {
|
|
load();
|
|
const [, initialState] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(initialState).to.equal('visible');
|
|
w.minimize();
|
|
await emittedOnce(ipcMain, 'visibility-change-hidden', () => w.minimize());
|
|
});
|
|
|
|
itWithOptions('should become visible when a window is restored', {}, async () => {
|
|
load();
|
|
const [, initialState] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(initialState).to.equal('visible');
|
|
w.minimize();
|
|
await emittedOnce(ipcMain, 'visibility-change-hidden');
|
|
w.restore();
|
|
await emittedOnce(ipcMain, 'visibility-change-visible');
|
|
});
|
|
|
|
describe('on platforms that support occlusion detection', () => {
|
|
let child: cp.ChildProcess;
|
|
|
|
before(function () {
|
|
if (process.platform !== 'darwin') this.skip();
|
|
});
|
|
|
|
const makeOtherWindow = (opts: { x: number; y: number; width: number; height: number; }) => {
|
|
child = cp.spawn(process.execPath, [path.resolve(__dirname, 'fixtures', 'chromium', 'other-window.js'), `${opts.x}`, `${opts.y}`, `${opts.width}`, `${opts.height}`]);
|
|
return new Promise(resolve => {
|
|
child.stdout!.on('data', (chunk) => {
|
|
if (chunk.toString().includes('__ready__')) resolve();
|
|
});
|
|
});
|
|
};
|
|
|
|
afterEach(() => {
|
|
if (child && !child.killed) {
|
|
child.kill('SIGTERM');
|
|
}
|
|
});
|
|
|
|
itWithOptions('should be visible when two windows are on screen', {
|
|
x: 0,
|
|
y: 0,
|
|
width: 200,
|
|
height: 200
|
|
}, async () => {
|
|
await makeOtherWindow({
|
|
x: 200,
|
|
y: 0,
|
|
width: 200,
|
|
height: 200
|
|
});
|
|
load();
|
|
const [, state] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(state).to.equal('visible');
|
|
});
|
|
|
|
itWithOptions('should be visible when two windows are on screen that overlap partially', {
|
|
x: 50,
|
|
y: 50,
|
|
width: 150,
|
|
height: 150
|
|
}, async () => {
|
|
await makeOtherWindow({
|
|
x: 100,
|
|
y: 0,
|
|
width: 200,
|
|
height: 200
|
|
});
|
|
load();
|
|
const [, state] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(state).to.equal('visible');
|
|
});
|
|
|
|
itWithOptions('should be hidden when a second window completely occludes the current window', {
|
|
x: 50,
|
|
y: 50,
|
|
width: 50,
|
|
height: 50
|
|
}, async function () {
|
|
this.timeout(240000);
|
|
load();
|
|
const [, state] = await emittedOnce(ipcMain, 'initial-visibility-state');
|
|
expect(state).to.equal('visible');
|
|
makeOtherWindow({
|
|
x: 0,
|
|
y: 0,
|
|
width: 300,
|
|
height: 300
|
|
});
|
|
await emittedOnce(ipcMain, 'visibility-change-hidden');
|
|
});
|
|
});
|
|
});
|