mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1
electron/shell/browser/api
History
Samuel Attard 49aba471dc
 feat: add support for associating a Menu with a WebFrameMain (#45138) 
* feat: add support for associating a Menu with a WebFrameMain

This allows certain OS level features to activate such as Writing Tools, Autofill.. and Services.

There appears to be a bug in macOS where the responder chain isn't traversed if the menu is not popped up using an event, as such we spoof a fake mouse event at the write coordinates in the right window and use that to open the menu.

* build: fix build on non-mac

* build: oops missed a header

* fix: safely handle optional T* by checking nullptr too

* build: fix gn check and build errors

* docs: suggested changes

* feat: default `frame` to `window.webContents.mainFrame` when possible

* fix: avoid deref nullptr view

* Revert "feat: default `frame` to `window.webContents.mainFrame` when possible"

This reverts commit 2e888368199317d67f6ad931a7e9eff0295c4b1b.

* fix: lint

* Remove redundant scoped objects

This code, including the comments, matches almost exactly the behavior of this argument to the function.

* Add ScopedPumpMessagesInPrivateModes patch

* More null pointer safety

---------

Co-authored-by: clavin <clavin@electronjs.org>
2025-03-28 11:50:07 -07:00
..
views chore: bump chromium to 135.0.7015.0 (main) (#45500) 2025-02-18 11:51:27 -05:00
electron_api_app.cc fix: NODE_OPTIONS parsing for child processes on macOS (#46209) 2025-03-25 13:01:37 +09:00
electron_api_app.h chore: bump chromium to 133.0.6920.0 (main) (#45055) 2025-01-10 10:52:34 -06:00
electron_api_app_mac.mm chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_api_app_mas.mm chore: bump chromium to 117.0.5923.0 (main) (#39304) 2023-08-04 10:47:29 +02:00
electron_api_auto_updater.cc refactor: only pass v8::Context to gin_helper::MicrotasksScope constructor (#45484) 2025-02-07 10:44:19 +09:00
electron_api_auto_updater.h refactor: declare gin::Wrapper subclasses as final (#43527) 2024-09-04 18:40:02 -05:00
electron_api_base_window.cc feat: add BrowserWindow.isSnapped() (#46079) 2025-03-24 12:09:14 +01:00
electron_api_base_window.h feat: add BrowserWindow.isSnapped() (#46079) 2025-03-24 12:09:14 +01:00
electron_api_browser_window.cc refactor: unfilter unresponsive events (#44629) 2024-11-13 17:59:13 -08:00
electron_api_browser_window.h refactor: unfilter unresponsive events (#44629) 2024-11-13 17:59:13 -08:00
electron_api_content_tracing.cc refactor: in StopTracing(), use string literals instead of optional<string> (#45270) 2025-01-21 17:41:52 -06:00
electron_api_cookies.cc chore: bump chromium to 134.0.6998.10 (main) (#45564) 2025-02-11 17:26:39 -06:00
electron_api_cookies.h chore: remove unused isolate argument from Cookies constructor (#44907) 2024-12-02 11:34:21 -05:00
electron_api_crash_reporter.cc refactor: fix modernize-return-braced-init-list warnings (#44838) 2024-11-27 09:41:46 +09:00
electron_api_crash_reporter.h chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_api_data_pipe_holder.cc refactor: return-braced-init-list pt 2 of 2 (#44870) 2024-11-29 11:44:33 -06:00
electron_api_data_pipe_holder.h refactor: declare gin::Wrapper subclasses as final (#43527) 2024-09-04 18:40:02 -05:00
electron_api_debugger.cc refactor: use base::as_string_view() (#45722) 2025-02-20 18:19:36 -06:00
electron_api_debugger.h refactor: declare gin::Wrapper subclasses as final (#43527) 2024-09-04 18:40:02 -05:00
electron_api_desktop_capturer.cc perf: don't wait for thumbnails if they were not requested on macOS (#46138) 2025-03-25 12:20:38 +01:00
electron_api_desktop_capturer.h feat: add support for system picker in setDisplayMediaRequestHandler (#43581) 2024-09-10 16:05:57 -07:00
electron_api_desktop_capturer_mac.mm feat: add support for system picker in setDisplayMediaRequestHandler (#43581) 2024-09-10 16:05:57 -07:00
electron_api_dialog.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_download_item.cc refactor: return-braced-init-list pt 2 of 2 (#44870) 2024-11-29 11:44:33 -06:00
electron_api_download_item.h refactor: declare gin::Wrapper subclasses as final (#43527) 2024-09-04 18:40:02 -05:00
electron_api_event_emitter.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_api_event_emitter.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
electron_api_extensions.cc refactor: move extension APIs to session.extensions (#45597) 2025-02-21 17:36:51 -06:00
electron_api_extensions.h refactor: move extension APIs to session.extensions (#45597) 2025-02-21 17:36:51 -06:00
electron_api_global_shortcut.cc perf: avoid redundant map lookups in GlobalShortcut (#46229) 2025-03-25 09:46:03 -05:00
electron_api_global_shortcut.h refactor: remove unused v8::Isolate* arg from GlobalShortcut constructor (#45773) 2025-02-24 19:38:20 -06:00
electron_api_in_app_purchase.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_in_app_purchase.h refactor: declare gin::Wrapper subclasses as final (#43527) 2024-09-04 18:40:02 -05:00
electron_api_menu.cc feat: add support for associating a Menu with a WebFrameMain (#45138) 2025-03-28 11:50:07 -07:00
electron_api_menu.h feat: add support for associating a Menu with a WebFrameMain (#45138) 2025-03-28 11:50:07 -07:00
electron_api_menu_mac.h feat: add support for associating a Menu with a WebFrameMain (#45138) 2025-03-28 11:50:07 -07:00
electron_api_menu_mac.mm feat: add support for associating a Menu with a WebFrameMain (#45138) 2025-03-28 11:50:07 -07:00
electron_api_menu_views.cc feat: add support for associating a Menu with a WebFrameMain (#45138) 2025-03-28 11:50:07 -07:00
electron_api_menu_views.h feat: add support for associating a Menu with a WebFrameMain (#45138) 2025-03-28 11:50:07 -07:00
electron_api_native_theme.cc feat: add transparency checking to nativeTheme (#42862) 2024-07-24 14:38:22 +02:00
electron_api_native_theme.h refactor: declare gin::Wrapper subclasses as final (#43527) 2024-09-04 18:40:02 -05:00
electron_api_native_theme_mac.mm chore: cleanup arc migration helpers (#39606) 2023-08-23 09:54:21 -04:00
electron_api_net_log.cc refactor: fix modernize-return-braced-init-list warnings (#44838) 2024-11-27 09:41:46 +09:00
electron_api_net_log.h refactor: declare gin::Wrapper subclasses as final (#43527) 2024-09-04 18:40:02 -05:00
electron_api_notification.cc fix: crash in gin::wrappable::secondweakcallback (#45368) 2025-01-29 10:20:37 -08:00
electron_api_notification.h fix: crash in gin::wrappable::secondweakcallback (#45368) 2025-01-29 10:20:37 -08:00
electron_api_power_monitor.cc chore: bump chromium to 131.0.6734.0 (main) (#43769) 2024-09-25 06:19:39 -05:00
electron_api_power_monitor.h docs: fix spelling errors in code comments (#45842) 2025-02-28 12:24:00 +01:00
electron_api_power_monitor_mac.mm fix: user-did-{resign|become}-active events on macOS (#41506) 2024-03-06 12:43:39 +01:00
electron_api_power_monitor_win.cc chore: iwyu mojom-forward header files (#43741) 2024-09-17 12:58:56 -07:00
electron_api_power_save_blocker.cc refactor: use C++20's contains() method (#45742) 2025-02-21 17:33:43 -06:00
electron_api_power_save_blocker.h refactor: declare gin::Wrapper subclasses as final (#43527) 2024-09-04 18:40:02 -05:00
electron_api_printing.cc chore: bump chromium to 135.0.7015.0 (main) (#45500) 2025-02-18 11:51:27 -05:00
electron_api_protocol.cc refactor: reduce coupling in electron::api::Protocol (#46122) 2025-03-21 07:33:25 -05:00
electron_api_protocol.h refactor: reduce coupling in electron::api::Protocol (#46122) 2025-03-21 07:33:25 -05:00
electron_api_push_notifications.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
electron_api_push_notifications.h refactor: declare gin::Wrapper subclasses as final (#43527) 2024-09-04 18:40:02 -05:00
electron_api_push_notifications_mac.mm fix: APNS token ids are lowercase ASCII (#46101) 2025-03-20 07:57:50 +01:00
electron_api_safe_storage.cc refactor: fix modernize-return-braced-init-list warnings (#44838) 2024-11-27 09:41:46 +09:00
electron_api_screen.cc refactor: fix modernize-return-braced-init-list warnings (#44838) 2024-11-27 09:41:46 +09:00
electron_api_screen.h refactor: declare gin::Wrapper subclasses as final (#43527) 2024-09-04 18:40:02 -05:00
electron_api_service_worker_context.cc feat: ServiceWorkerMain (#45232) 2025-01-24 08:33:44 -05:00
electron_api_service_worker_context.h feat: ServiceWorkerMain (#45232) 2025-01-24 08:33:44 -05:00
electron_api_service_worker_main.cc perf: use absl::flat_hash_map instead of std::unordered_map (#46202) 2025-03-24 10:09:14 +01:00
electron_api_service_worker_main.h refactor: remove unused field ServiceWorkerMain::weak_factory_ (#46171) 2025-03-23 10:14:45 +01:00
electron_api_session.cc perf: avoid redundant map lookups in GetStorageMask() (#46315) 2025-03-28 00:25:25 -05:00
electron_api_session.h refactor: move extension APIs to session.extensions (#45597) 2025-02-21 17:36:51 -06:00
electron_api_system_preferences.cc chore: deprecate systemPreferences.isAeroGlassEnabled() (#45434) 2025-02-10 15:17:07 -05:00
electron_api_system_preferences.h chore: deprecate systemPreferences.isAeroGlassEnabled() (#45434) 2025-02-10 15:17:07 -05:00
electron_api_system_preferences_mac.mm chore: bump chromium to 131.0.6734.0 (main) (#43769) 2024-09-25 06:19:39 -05:00
electron_api_system_preferences_win.cc build: match upstream with unsafe buffer paths (#45853) 2025-03-06 16:04:18 -05:00
electron_api_tray.cc fix: crash in gin::wrappable::secondweakcallback (#45368) 2025-01-29 10:20:37 -08:00
electron_api_tray.h fix: crash in gin::wrappable::secondweakcallback (#45368) 2025-01-29 10:20:37 -08:00
electron_api_utility_process.cc refactor: return-braced-init-list pt 2 of 2 (#44870) 2024-11-29 11:44:33 -06:00
electron_api_utility_process.h refactor: use private inheritance from mojo::MessageReceiver (#45973) 2025-03-12 19:06:41 +01:00
electron_api_view.cc refactor: use = default to define trivial destructors (#46165) 2025-03-21 16:15:34 -05:00
electron_api_view.h feat: view.getVisible() (#44999) 2025-01-31 13:27:16 -05:00
electron_api_web_contents.cc perf: avoid std::map temporaries in WebContents::DevToolsRequestFileSystems() (#46268) 2025-03-26 16:26:56 -05:00
electron_api_web_contents.h fix: build failure when printing is disabled (#46283) 2025-03-26 10:04:39 +01:00
electron_api_web_contents_impl.cc chore: bump chromium to 131.0.6734.0 (main) (#43769) 2024-09-25 06:19:39 -05:00
electron_api_web_contents_mac.mm chore: bump chromium to 127.0.6521.0 (main) (#42118) 2024-06-07 17:18:35 -04:00
electron_api_web_contents_view.cc refactor: remove InspectableWebContentsViewMac in favor of the Views version (#44628) 2025-01-17 10:21:10 -05:00
electron_api_web_contents_view.h feat: customize border radius of Views (#42320) 2024-07-16 20:16:25 -04:00
electron_api_web_frame_main.cc perf: avoid double map lookup in WebFrameMain::UpdateRenderFrameHost() (#46293) 2025-03-27 14:32:01 -05:00
electron_api_web_frame_main.h feat: add support for associating a Menu with a WebFrameMain (#45138) 2025-03-28 11:50:07 -07:00
electron_api_web_request.cc build: match upstream with unsafe buffer paths (#45853) 2025-03-06 16:04:18 -05:00
electron_api_web_request.h feat: add excludeUrls and modify urls in WebRequestFilter for better URL filtering (#44692) 2025-02-17 12:40:47 -08:00
electron_api_web_view_manager.cc chore: rename built-in modules to bindings to match naming update in node (#37182) 2023-02-09 10:31:38 +09:00
frame_subscriber.cc refactor: put empty virtual function definitions in header (#43285) 2024-08-12 09:56:51 +02:00
frame_subscriber.h refactor: put empty virtual function definitions in header (#43285) 2024-08-12 09:56:51 +02:00
gpu_info_enumerator.cc refactor: simplify code by using base::Value::EnsureList() (#41162) 2024-01-30 14:48:09 -06:00
gpu_info_enumerator.h refactor: remove unused system header includes (#46015) 2025-03-14 10:59:15 -05:00
gpuinfo_manager.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
gpuinfo_manager.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
ipc_dispatcher.h refactor: dispatch IPC messages from Session (#45452) 2025-02-17 16:36:28 -05:00
message_port.cc refactor: use C++20's contains() method (#45742) 2025-02-21 17:33:43 -06:00
message_port.h refactor: use private inheritance from mojo::MessageReceiver (#45973) 2025-03-12 19:06:41 +01:00
process_metric.cc build: make is_mas_build a generated header instead of config (#43737) 2024-09-17 01:38:56 -07:00
process_metric.h chore: bump chromium to 100.0.4857.0 (main) (#32419) 2022-02-09 18:58:52 -08:00
save_page_handler.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
save_page_handler.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
ui_event.cc chore: used nested namespaces (#34737) 2022-06-29 12:55:47 -07:00
ui_event.h chore: used nested namespaces (#34737) 2022-06-29 12:55:47 -07:00