electron/shell/browser/ui/views
electron-roller[bot] 458b14b8ed
chore: bump chromium to 136.0.7053.1 (main) (#45906)
* chore: bump chromium in DEPS to 136.0.7052.0

* chore: update mas_avoid_private_macos_api_usage.patch.patch

6318359

patch applied manually due to context shear

* chore: update preconnect_manager.patch

Xref: 6318420

patch applied manually due to context shear

* chore: e patches all

* chore: bump chromium to 136.0.7053.1

* chore: update fix_remove_profiles_from_spellcheck_service.patch

Xref: 6326575

patch applied manually due to context shear

* chore: e patches all

* chore: revert removal of v8 API used by Node.js

* devtools: Remove DevToolsUIBindings::SendJsonRequest() | 6326236

* 6244461: Merge //content/common/user_agent.cc into //components/embedder_support:user_agent | 6244461

* 6313744: Migrate views::Background factory methods to ColorVariant | 6313744

* 6314545: Remove multiple argument support from base::ToString() | 6314545

* 6317362: [Extensions] Inline MessagingDelegate::CreateReceiverForTab() | 6317362

* 6308998: Add SettingAccess structured metrics event for DevTools | 6308998

* 6295214: Remove redundant state field in per-extension preferences | 6295214

NB: this change is copied from the upstream change to extensions/shell/browser/shell_extension_loader.cc

* fix: ui/ linter error

This is showing up in an eslint build step in Electron:

> /__w/electron/electron/src/out/Default/gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts
>   77:23  error  This assertion is unnecessary since the receiver accepts the original type of the expression  @typescript-eslint/no-unnecessary-type-assertion
>
> ✖ 1 problem (1 error, 0 warnings)
>   1 error and 0 warnings potentially fixable with the `--fix` option.

However, removing the assertion causes a typescript build failure:

> gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts:77:23 - error TS2345: Argument of type 'HTMLElement | null' is not assignable to parameter of type 'HTMLElement'.
>   Type 'null' is not assignable to type 'HTMLElement'.
>
> 77         items.indexOf(this.querySelector<HTMLElement>(':focus'));
>                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

So I think the two different steps may be picking up typescript definitions.

This patch should be removed after the issue is tracked down
and fixed in a followup task.

* fix: -Wnonnull warning

Fixes this warning:

> 2025-03-07T01:05:01.8637705Z ../../third_party/electron_node/src/debug_utils.cc(257,12): error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
> 2025-03-07T01:05:01.8638267Z   257 |     return nullptr;
> 2025-03-07T01:05:01.8638481Z       |            ^~~~~~~
> 2025-03-07T01:05:01.8638700Z 1 error generated.

Not sure why this warning was never triggered before; `git blame`
indicates this code hasn't changed in ages:

> c40a8273ef2 (Michaël Zasso    2024-05-10 09:50:20 +0200 255) #endif  // DEBUG
> 8e2d33f1562 (Anna Henningsen  2018-06-07 16:54:29 +0200 256)     }
> 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 257)     return nullptr;
> 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 258)   }

Presumably this is failing in this Chromium roll due to a
clang version bump.

We should remove this patch after upstreaming it.

* docs: add upstream pr link for Node patch

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-03-07 11:35:59 -06:00
..
autofill_popup_view.cc chore: bump chromium to 135.0.7015.0 (main) (#45500) 2025-02-18 11:51:27 -05:00
autofill_popup_view.h chore: bump chromium to 135.0.7015.0 (main) (#45500) 2025-02-18 11:51:27 -05:00
caption_button_placeholder_container.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
caption_button_placeholder_container.h feat: enable Windows Control Overlay on Linux (#41769) 2024-06-27 14:56:36 +02:00
client_frame_view_linux.cc build: match upstream with unsafe buffer paths (#45853) 2025-03-06 16:04:18 -05:00
client_frame_view_linux.h chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_views_delegate.cc chore: bump chromium to 131.0.6744.0 (main) (#43948) 2024-09-30 14:54:44 +02:00
electron_views_delegate.h chore: bump chromium to 131.0.6744.0 (main) (#43948) 2024-09-30 14:54:44 +02:00
electron_views_delegate_win.cc perf: use flat_set, flat_map for small, trivially-moved containers (#40817) 2024-01-05 12:18:31 +01:00
frameless_view.cc refactor: remove InspectableWebContentsViewMac in favor of the Views version (#44628) 2025-01-17 10:21:10 -05:00
frameless_view.h refactor: put empty virtual function definitions in header (#43285) 2024-08-12 09:56:51 +02:00
global_menu_bar_registrar_x11.cc fix: remove unused local variables (#44815) 2024-11-23 17:34:51 -06:00
global_menu_bar_registrar_x11.h chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
global_menu_bar_x11.cc chore: bump chromium to 135.0.7015.0 (main) (#45500) 2025-02-18 11:51:27 -05:00
global_menu_bar_x11.h chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
menu_bar.cc chore: bump chromium to 136.0.7053.1 (main) (#45906) 2025-03-07 11:35:59 -06:00
menu_bar.h chore: bump chromium to 135.0.7015.0 (main) (#45500) 2025-02-18 11:51:27 -05:00
menu_delegate.cc chore: bump chromium to 132.0.6807.0 (main) (#44360) 2024-11-04 09:10:00 -05:00
menu_delegate.h chore: bump chromium to 132.0.6807.0 (main) (#44360) 2024-11-04 09:10:00 -05:00
menu_model_adapter.cc chore: bump chromium to 106.0.5216.0 (main) (#34993) 2022-08-17 11:35:53 -07:00
menu_model_adapter.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
native_frame_view.cc chore: bump chromium to 123.0.6312.5 (main) (#41337) 2024-02-21 15:27:05 -05:00
native_frame_view.h chore: bump chromium to 123.0.6312.5 (main) (#41337) 2024-02-21 15:27:05 -05:00
opaque_frame_view.cc refactor: fix modernize-return-braced-init-list warnings (#44838) 2024-11-27 09:41:46 +09:00
opaque_frame_view.h chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
root_view.cc chore: bump chromium to 127.0.6521.0 (main) (#42118) 2024-06-07 17:18:35 -04:00
root_view.h chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
submenu_button.cc docs: fix spelling errors in code comments (#45842) 2025-02-28 12:24:00 +01:00
submenu_button.h chore: bump chromium to 135.0.7015.0 (main) (#45500) 2025-02-18 11:51:27 -05:00
win_caption_button.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
win_caption_button.h chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
win_caption_button_container.cc fix: WCO not working with some window configurations (#45422) 2025-02-05 12:48:51 +01:00
win_caption_button_container.h fix: tooltips in WCO caption buttons (#44721) 2024-11-20 12:45:08 +01:00
win_frame_view.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
win_frame_view.h chore: remove unused WinFrameView::kInactiveTitlebarFeatureAlpha (#43448) 2024-08-23 20:59:41 -05:00
win_icon_painter.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
win_icon_painter.h chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00