b500294c1d
* feat: add worldSafe flag for executeJS results * chore: do not log warning for webContents.executeJS * Apply suggestions from code review Co-authored-by: Jeremy Rose <jeremya@chromium.org> * chore: apply PR feedback * chore: split logic a bit * chore: allow primitives through the world safe checl * chore: clean up per PR feedback * chore: flip boolean logic * chore: update per PR feedback * chore: fix typo * chore: fix spec Co-authored-by: Jeremy Rose <jeremya@chromium.org>
76 lines
2.8 KiB
TypeScript
76 lines
2.8 KiB
TypeScript
import { expect } from 'chai';
|
|
import * as path from 'path';
|
|
import { BrowserWindow, ipcMain } from 'electron/main';
|
|
import { closeAllWindows } from './window-helpers';
|
|
import { emittedOnce } from './events-helpers';
|
|
|
|
describe('webFrame module', () => {
|
|
const fixtures = path.resolve(__dirname, '..', 'spec', 'fixtures');
|
|
|
|
afterEach(closeAllWindows);
|
|
|
|
for (const worldSafe of [true, false]) {
|
|
it(`can use executeJavaScript with world safe mode ${worldSafe ? 'enabled' : 'disabled'}`, async () => {
|
|
const w = new BrowserWindow({
|
|
show: true,
|
|
webPreferences: {
|
|
nodeIntegration: true,
|
|
contextIsolation: true,
|
|
worldSafeExecuteJavaScript: worldSafe,
|
|
preload: path.join(fixtures, 'pages', 'world-safe-preload.js')
|
|
}
|
|
});
|
|
const isSafe = emittedOnce(ipcMain, 'executejs-safe');
|
|
w.loadURL('about:blank');
|
|
const [, wasSafe] = await isSafe;
|
|
expect(wasSafe).to.equal(worldSafe);
|
|
});
|
|
}
|
|
|
|
it('can use executeJavaScript with world safe mode enabled and catch conversion errors', async () => {
|
|
const w = new BrowserWindow({
|
|
show: true,
|
|
webPreferences: {
|
|
nodeIntegration: true,
|
|
contextIsolation: true,
|
|
worldSafeExecuteJavaScript: true,
|
|
preload: path.join(fixtures, 'pages', 'world-safe-preload-error.js')
|
|
}
|
|
});
|
|
const execError = emittedOnce(ipcMain, 'executejs-safe');
|
|
w.loadURL('about:blank');
|
|
const [, error] = await execError;
|
|
expect(error).to.not.equal(null, 'Error should not be null');
|
|
expect(error).to.have.property('message', 'Uncaught Error: An object could not be cloned.');
|
|
});
|
|
|
|
it('calls a spellcheck provider', async () => {
|
|
const w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
nodeIntegration: true
|
|
}
|
|
});
|
|
await w.loadFile(path.join(fixtures, 'pages', 'webframe-spell-check.html'));
|
|
w.focus();
|
|
await w.webContents.executeJavaScript('document.querySelector("input").focus()', true);
|
|
|
|
const spellCheckerFeedback =
|
|
new Promise<[string[], boolean]>(resolve => {
|
|
ipcMain.on('spec-spell-check', (e, words, callbackDefined) => {
|
|
if (words.length === 5) {
|
|
// The API calls the provider after every completed word.
|
|
// The promise is resolved only after this event is received with all words.
|
|
resolve([words, callbackDefined]);
|
|
}
|
|
});
|
|
});
|
|
const inputText = 'spleling test you\'re ';
|
|
for (const keyCode of inputText) {
|
|
w.webContents.sendInputEvent({ type: 'char', keyCode });
|
|
}
|
|
const [words, callbackDefined] = await spellCheckerFeedback;
|
|
expect(words.sort()).to.deep.equal(['spleling', 'test', 'you\'re', 'you', 're'].sort());
|
|
expect(callbackDefined).to.be.true();
|
|
});
|
|
});
|