585ff9062c
Consider an electron application that uses `execFile` to run a script that lives within the application code base: ```coffee child_process = require 'child_process' child_process.execFile __dirname + '/script.sh', (error) -> throw error if error? ``` An application like this will fail when being packaged in an `asar` with an following error: ``` Error: spawn EACCES ``` Electron overrides certain `fs` functions to make them work within an `asar` package. In the case of `execFile`, the file to be executed is extracted from the `asar` package into a temporary file and ran from there. The problem is that during the extraction, the original permissions of the file are lost. We workaround this by: 1. Extending `asar.stat` to return whether a file is executable or not, which is information that's already saved in the `asar` header. 2. Setting execution permissions on the extracted file if the above property holds true. Fixes: https://github.com/atom/electron/issues/3512
86 lines
2.1 KiB
C++
86 lines
2.1 KiB
C++
// Copyright (c) 2014 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ATOM_COMMON_ASAR_ARCHIVE_H_
|
|
#define ATOM_COMMON_ASAR_ARCHIVE_H_
|
|
|
|
#include <vector>
|
|
|
|
#include "base/containers/scoped_ptr_hash_map.h"
|
|
#include "base/files/file.h"
|
|
#include "base/files/file_path.h"
|
|
#include "base/memory/scoped_ptr.h"
|
|
|
|
namespace base {
|
|
class DictionaryValue;
|
|
}
|
|
|
|
namespace asar {
|
|
|
|
class ScopedTemporaryFile;
|
|
|
|
// This class represents an asar package, and provides methods to read
|
|
// information from it.
|
|
class Archive {
|
|
public:
|
|
struct FileInfo {
|
|
FileInfo() : size(0), offset(0) {}
|
|
bool unpacked;
|
|
bool executable;
|
|
uint32 size;
|
|
uint64 offset;
|
|
};
|
|
|
|
struct Stats : public FileInfo {
|
|
Stats() : is_file(true), is_directory(false), is_link(false) {}
|
|
bool is_file;
|
|
bool is_directory;
|
|
bool is_link;
|
|
};
|
|
|
|
explicit Archive(const base::FilePath& path);
|
|
virtual ~Archive();
|
|
|
|
// Read and parse the header.
|
|
bool Init();
|
|
|
|
// Get the info of a file.
|
|
bool GetFileInfo(const base::FilePath& path, FileInfo* info);
|
|
|
|
// Fs.stat(path).
|
|
bool Stat(const base::FilePath& path, Stats* stats);
|
|
|
|
// Fs.readdir(path).
|
|
bool Readdir(const base::FilePath& path, std::vector<base::FilePath>* files);
|
|
|
|
// Fs.realpath(path).
|
|
bool Realpath(const base::FilePath& path, base::FilePath* realpath);
|
|
|
|
// Copy the file into a temporary file, and return the new path.
|
|
// For unpacked file, this method will return its real path.
|
|
bool CopyFileOut(const base::FilePath& path, base::FilePath* out);
|
|
|
|
// Returns the file's fd.
|
|
int GetFD() const;
|
|
|
|
base::FilePath path() const { return path_; }
|
|
base::DictionaryValue* header() const { return header_.get(); }
|
|
|
|
private:
|
|
base::FilePath path_;
|
|
base::File file_;
|
|
int fd_;
|
|
uint32 header_size_;
|
|
scoped_ptr<base::DictionaryValue> header_;
|
|
|
|
// Cached external temporary files.
|
|
base::ScopedPtrHashMap<base::FilePath, scoped_ptr<ScopedTemporaryFile>>
|
|
external_files_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(Archive);
|
|
};
|
|
|
|
} // namespace asar
|
|
|
|
#endif // ATOM_COMMON_ASAR_ARCHIVE_H_
|