* Don't use JSON to send the result of `ipcRenderer.sendSync`.
- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
to wrap/unwrap return values to/from array, instead of
serializing/deserializing JSON.
This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).
A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory. This difference
tends increases with larger buffers.
* Don't base64 encode Buffers
* Don't allocate V8ValueConverter on the heap
* Replace hidden global.sandbox with NodeBindings::IsInitialized()
* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter
* Refactor problematic test to make it more reliable
* Add tests for NaN and Infinity
71 lines
2.7 KiB
C++
71 lines
2.7 KiB
C++
// Copyright (c) 2013 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Multiply-included file, no traditional include guard.
|
|
|
|
#include "atom/common/draggable_region.h"
|
|
#include "base/strings/string16.h"
|
|
#include "base/values.h"
|
|
#include "content/public/common/common_param_traits.h"
|
|
#include "content/public/common/referrer.h"
|
|
#include "ipc/ipc_message_macros.h"
|
|
#include "ui/gfx/geometry/rect_f.h"
|
|
#include "ui/gfx/ipc/gfx_param_traits.h"
|
|
#include "url/gurl.h"
|
|
|
|
// The message starter should be declared in ipc/ipc_message_start.h. Since
|
|
// we don't want to patch Chromium, we just pretend to be Content Shell.
|
|
|
|
#define IPC_MESSAGE_START ShellMsgStart
|
|
|
|
IPC_STRUCT_TRAITS_BEGIN(atom::DraggableRegion)
|
|
IPC_STRUCT_TRAITS_MEMBER(draggable)
|
|
IPC_STRUCT_TRAITS_MEMBER(bounds)
|
|
IPC_STRUCT_TRAITS_END()
|
|
|
|
IPC_MESSAGE_ROUTED2(AtomFrameHostMsg_Message,
|
|
base::string16 /* channel */,
|
|
base::ListValue /* arguments */)
|
|
|
|
IPC_SYNC_MESSAGE_ROUTED2_1(AtomFrameHostMsg_Message_Sync,
|
|
base::string16 /* channel */,
|
|
base::ListValue /* arguments */,
|
|
base::ListValue /* result */)
|
|
|
|
IPC_MESSAGE_ROUTED3(AtomFrameMsg_Message,
|
|
bool /* send_to_all */,
|
|
base::string16 /* channel */,
|
|
base::ListValue /* arguments */)
|
|
|
|
IPC_MESSAGE_ROUTED0(AtomViewMsg_Offscreen)
|
|
|
|
IPC_MESSAGE_ROUTED3(AtomAutofillFrameHostMsg_ShowPopup,
|
|
gfx::RectF /* bounds */,
|
|
std::vector<base::string16> /* values */,
|
|
std::vector<base::string16> /* labels */)
|
|
|
|
IPC_MESSAGE_ROUTED0(AtomAutofillFrameHostMsg_HidePopup)
|
|
|
|
IPC_MESSAGE_ROUTED1(AtomAutofillFrameMsg_AcceptSuggestion,
|
|
base::string16 /* suggestion */)
|
|
|
|
// Sent by the renderer when the draggable regions are updated.
|
|
IPC_MESSAGE_ROUTED1(AtomFrameHostMsg_UpdateDraggableRegions,
|
|
std::vector<atom::DraggableRegion> /* regions */)
|
|
|
|
// Update renderer process preferences.
|
|
IPC_MESSAGE_CONTROL1(AtomMsg_UpdatePreferences, base::ListValue)
|
|
|
|
// Sent by renderer to set the temporary zoom level.
|
|
IPC_SYNC_MESSAGE_ROUTED1_1(AtomFrameHostMsg_SetTemporaryZoomLevel,
|
|
double /* zoom level */,
|
|
double /* result */)
|
|
|
|
// Sent by renderer to get the zoom level.
|
|
IPC_SYNC_MESSAGE_ROUTED0_1(AtomFrameHostMsg_GetZoomLevel, double /* result */)
|
|
|
|
// Brings up SaveAs... dialog to save specified URL.
|
|
IPC_MESSAGE_ROUTED2(AtomFrameHostMsg_PDFSaveURLAs,
|
|
GURL /* url */,
|
|
content::Referrer /* referrer */)
|