electron/shell
Samuel Maddock 4057e6b56e
fix: DesktopCapturer gc'd prior to capture completion (#28273)
desktopCapture.getSources() returns a promise which should resolve
when capturing finishes. Internally it creates an instance of
DesktopCapturer which is responsible for resolving or rejecting
the promise.

Between the time DesktopCapturer starts capturing frames and when
it finishes, it's possible for its handle to be GC'd leading to
it never resolving.

These changes pin the instance of DesktopCapturer until it either
finishes or errors.

fixes #25595
2021-03-18 13:43:35 -07:00
..
app chore: bump chromium to 90.0.4415.0 (master) (#27694) 2021-03-04 09:27:05 -08:00
browser fix: DesktopCapturer gc'd prior to capture completion (#28273) 2021-03-18 13:43:35 -07:00
common fix: revert "refactor: mmap asar files (#24470)" (#28137) 2021-03-15 11:42:54 -07:00
renderer feat: add process.contextIsolation property (#28030) 2021-03-17 11:23:29 -07:00
utility refactor: use C++11 class member variable initialization (#27477) 2021-01-26 12:16:21 -06:00