electron/shell
trop[bot] 3e95df701a
test: ensure sender-pid hint is set in Linux notifications (#43950)
test: expect a `sender-pid` hint in Linux notifications.

This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.

This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.

By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 12:13:07 -05:00
..
app fix: delete UvTaskRunner's timers only after they're closed (#43599) 2024-09-06 14:18:51 -05:00
browser test: ensure sender-pid hint is set in Linux notifications (#43950) 2024-09-25 12:13:07 -05:00
common fix: -Wunsafe-buffer-usage warning in asar_util's ReadFileToString() (#43931) 2024-09-25 11:22:24 +02:00
renderer perf: use v8::Local<v8::Object> as the key in ObjectCache (#43662) 2024-09-10 09:21:21 -05:00
services/node refactor: declare gin::Wrapper subclasses as final (#43566) 2024-09-04 20:37:51 -05:00
utility refactor: run Windows SelectFileDialog out of process (#42780) 2024-07-08 10:31:10 +02:00