`bringToFront` DevTools message is sent when breakpoint is triggered
or inspect is called and Chromium upon this message activates DevTools
via `DevToolsUIBindings::Delegate::ActivateWindow`:
```
void DevToolsWindow::ActivateWindow() {
if (life_stage_ != kLoadCompleted)
return;
\#if BUILDFLAG(IS_ANDROID)
NOTIMPLEMENTED();
\#else
if (is_docked_ && GetInspectedBrowserWindow())
main_web_contents_->Focus();
else if (!is_docked_ && browser_ && !browser_->window()->IsActive())
browser_->window()->Activate();
\#endif
}
```
which implements: `DevToolsUIBindings::Delegate::ActivateWindow`.
Electron also implements this interface in:
`electron::InspectableWebContents`. However it was only setting
a zoom level, therefore this commit extends it with activation
of the DevTools.
Only supported for DevTools manged by `electron::InspectableWebContents`.
Closes: #37388
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Michał Pichliński <michal.pichlinski@here.io>
88 lines
2.6 KiB
C++
88 lines
2.6 KiB
C++
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
|
|
// Copyright (c) 2013 Adam Roben <adam@roben.org>. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE-CHROMIUM file.
|
|
|
|
#ifndef ELECTRON_SHELL_BROWSER_UI_INSPECTABLE_WEB_CONTENTS_VIEW_H_
|
|
#define ELECTRON_SHELL_BROWSER_UI_INSPECTABLE_WEB_CONTENTS_VIEW_H_
|
|
|
|
#include <string>
|
|
|
|
#include "base/memory/raw_ptr.h"
|
|
#include "chrome/browser/devtools/devtools_contents_resizing_strategy.h"
|
|
#include "ui/gfx/native_widget_types.h"
|
|
#include "ui/views/view.h"
|
|
|
|
class DevToolsContentsResizingStrategy;
|
|
|
|
namespace gfx {
|
|
class RoundedCornersF;
|
|
} // namespace gfx
|
|
|
|
namespace views {
|
|
class WebView;
|
|
class Widget;
|
|
class WidgetDelegate;
|
|
} // namespace views
|
|
|
|
namespace electron {
|
|
|
|
class InspectableWebContents;
|
|
class InspectableWebContentsViewDelegate;
|
|
|
|
class InspectableWebContentsView : public views::View {
|
|
public:
|
|
explicit InspectableWebContentsView(
|
|
InspectableWebContents* inspectable_web_contents);
|
|
~InspectableWebContentsView() override;
|
|
|
|
InspectableWebContents* inspectable_web_contents() {
|
|
return inspectable_web_contents_;
|
|
}
|
|
|
|
// The delegate manages its own life.
|
|
void SetDelegate(InspectableWebContentsViewDelegate* delegate) {
|
|
delegate_ = delegate;
|
|
}
|
|
InspectableWebContentsViewDelegate* GetDelegate() const { return delegate_; }
|
|
|
|
void SetCornerRadii(const gfx::RoundedCornersF& corner_radii);
|
|
|
|
void ShowDevTools(bool activate);
|
|
void ActivateDevTools();
|
|
void CloseDevTools();
|
|
bool IsDevToolsViewShowing();
|
|
bool IsDevToolsViewFocused();
|
|
void SetIsDocked(bool docked, bool activate);
|
|
void SetContentsResizingStrategy(
|
|
const DevToolsContentsResizingStrategy& strategy);
|
|
void SetTitle(const std::u16string& title);
|
|
const std::u16string GetTitle();
|
|
|
|
// views::View:
|
|
void Layout(PassKey) override;
|
|
|
|
private:
|
|
views::View* GetContentsView() const;
|
|
|
|
// Owns us.
|
|
raw_ptr<InspectableWebContents> inspectable_web_contents_;
|
|
|
|
raw_ptr<InspectableWebContentsViewDelegate> delegate_ =
|
|
nullptr; // weak references.
|
|
|
|
std::unique_ptr<views::Widget> devtools_window_;
|
|
raw_ptr<views::WebView> devtools_window_web_view_ = nullptr;
|
|
raw_ptr<views::WebView> contents_web_view_ = nullptr;
|
|
raw_ptr<views::View> no_contents_view_ = nullptr;
|
|
raw_ptr<views::WebView> devtools_web_view_ = nullptr;
|
|
|
|
DevToolsContentsResizingStrategy strategy_;
|
|
bool devtools_visible_ = false;
|
|
raw_ptr<views::WidgetDelegate> devtools_window_delegate_ = nullptr;
|
|
std::u16string title_;
|
|
};
|
|
|
|
} // namespace electron
|
|
|
|
#endif // ELECTRON_SHELL_BROWSER_UI_INSPECTABLE_WEB_CONTENTS_VIEW_H_
|