bc527f6b51
* refactor: bundle the browser and renderer process electron code * Bundles browser/init and renderer/init * Improves load performance of main process by ~40% * Improves load performance of renderer process by ~30% * Prevents users from importing our "requiring" our internal logic such as ipc-main-internal. This makes those message buses safer as they are less accessible, there is still some more work to be done though to lock down those buses completely. * The electron.asar file now only contains 2 files, as a future improvement maybe we can use atom_natives to ship these two files embedded in the binary * This also removes our dependency on browserify which had some strange edge cases that caused us to have to hack around require-order and stopped us using certain ES6/7 features we should have been able to use (async / await in some files in the sandboxed renderer init script) TLDR: Things are faster and better :) * fix: I really do not want to talk about it * chore: add performance improvements from debugging * fix: resolve the provided path so webpack thinks it is absolute * chore: fixup per PR review * fix: use webpacks ProvidePlugin to keep global, process and Buffer alive after deletion from global scope for use in internal code * fix: bundle worker/init as well to make node-in-workers work * chore: update wording as per feedback * chore: make the timers hack work when yarn is not used
281 lines
8.8 KiB
TypeScript
281 lines
8.8 KiB
TypeScript
import { webFrame } from 'electron'
|
|
import { invokeSync } from '@electron/internal/renderer/ipc-renderer-internal-utils'
|
|
|
|
let shouldLog: boolean | null = null
|
|
|
|
const { platform, execPath, env } = process
|
|
|
|
/**
|
|
* This method checks if a security message should be logged.
|
|
* It does so by determining whether we're running as Electron,
|
|
* which indicates that a developer is currently looking at the
|
|
* app.
|
|
*
|
|
* @returns {boolean} - Should we log?
|
|
*/
|
|
const shouldLogSecurityWarnings = function (): boolean {
|
|
if (shouldLog !== null) {
|
|
return shouldLog
|
|
}
|
|
|
|
switch (platform) {
|
|
case 'darwin':
|
|
shouldLog = execPath.endsWith('MacOS/Electron') ||
|
|
execPath.includes('Electron.app/Contents/Frameworks/')
|
|
break
|
|
case 'freebsd':
|
|
case 'linux':
|
|
shouldLog = execPath.endsWith('/electron')
|
|
break
|
|
case 'win32':
|
|
shouldLog = execPath.endsWith('\\electron.exe')
|
|
break
|
|
default:
|
|
shouldLog = false
|
|
}
|
|
|
|
if ((env && env.ELECTRON_DISABLE_SECURITY_WARNINGS) ||
|
|
(window && window.ELECTRON_DISABLE_SECURITY_WARNINGS)) {
|
|
shouldLog = false
|
|
}
|
|
|
|
if ((env && env.ELECTRON_ENABLE_SECURITY_WARNINGS) ||
|
|
(window && window.ELECTRON_ENABLE_SECURITY_WARNINGS)) {
|
|
shouldLog = true
|
|
}
|
|
|
|
return shouldLog
|
|
}
|
|
|
|
/**
|
|
* Checks if the current window is remote.
|
|
*
|
|
* @returns {boolean} - Is this a remote protocol?
|
|
*/
|
|
const getIsRemoteProtocol = function () {
|
|
if (window && window.location && window.location.protocol) {
|
|
return /^(http|ftp)s?/gi.test(window.location.protocol)
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Tries to determine whether a CSP without `unsafe-eval` is set.
|
|
*
|
|
* @returns {boolean} Is a CSP with `unsafe-eval` set?
|
|
*/
|
|
const isUnsafeEvalEnabled = function () {
|
|
return webFrame.executeJavaScript(`(${(() => {
|
|
try {
|
|
new Function('') // eslint-disable-line no-new,no-new-func
|
|
} catch {
|
|
return false
|
|
}
|
|
return true
|
|
}).toString()})()`, false)
|
|
}
|
|
|
|
const moreInformation = `\nFor more information and help, consult
|
|
https://electronjs.org/docs/tutorial/security.\n This warning will not show up
|
|
once the app is packaged.`
|
|
|
|
/**
|
|
* #1 Only load secure content
|
|
*
|
|
* Checks the loaded resources on the current page and logs a
|
|
* message about all resources loaded over HTTP or FTP.
|
|
*/
|
|
const warnAboutInsecureResources = function () {
|
|
if (!window || !window.performance || !window.performance.getEntriesByType) {
|
|
return
|
|
}
|
|
|
|
const resources = window.performance
|
|
.getEntriesByType('resource')
|
|
.filter(({ name }) => /^(http|ftp):/gi.test(name || ''))
|
|
.map(({ name }) => `- ${name}`)
|
|
.join('\n')
|
|
|
|
if (!resources || resources.length === 0) {
|
|
return
|
|
}
|
|
|
|
const warning = `This renderer process loads resources using insecure
|
|
protocols.This exposes users of this app to unnecessary security risks.
|
|
Consider loading the following resources over HTTPS or FTPS. \n ${resources}
|
|
\n ${moreInformation}`
|
|
|
|
console.warn('%cElectron Security Warning (Insecure Resources)',
|
|
'font-weight: bold;', warning)
|
|
}
|
|
|
|
/**
|
|
* #2 on the checklist: Disable the Node.js integration in all renderers that
|
|
* display remote content
|
|
*
|
|
* Logs a warning message about Node integration.
|
|
*/
|
|
const warnAboutNodeWithRemoteContent = function (nodeIntegration: boolean) {
|
|
if (!nodeIntegration) return
|
|
|
|
if (getIsRemoteProtocol()) {
|
|
const warning = `This renderer process has Node.js integration enabled
|
|
and attempted to load remote content from '${window.location}'. This
|
|
exposes users of this app to severe security risks.\n ${moreInformation}`
|
|
|
|
console.warn('%cElectron Security Warning (Node.js Integration with Remote Content)',
|
|
'font-weight: bold;', warning)
|
|
}
|
|
}
|
|
|
|
// Currently missing since it has ramifications and is still experimental:
|
|
// #3 Enable context isolation in all renderers that display remote content
|
|
//
|
|
// Currently missing since we can't easily programmatically check for those cases:
|
|
// #4 Use ses.setPermissionRequestHandler() in all sessions that load remote content
|
|
|
|
/**
|
|
* #5 on the checklist: Do not disable websecurity
|
|
*
|
|
* Logs a warning message about disabled webSecurity.
|
|
*/
|
|
const warnAboutDisabledWebSecurity = function (webPreferences?: Electron.WebPreferences) {
|
|
if (!webPreferences || webPreferences.webSecurity !== false) return
|
|
|
|
const warning = `This renderer process has "webSecurity" disabled. This
|
|
exposes users of this app to severe security risks.\n ${moreInformation}`
|
|
|
|
console.warn('%cElectron Security Warning (Disabled webSecurity)',
|
|
'font-weight: bold;', warning)
|
|
}
|
|
|
|
/**
|
|
* #6 on the checklist: Define a Content-Security-Policy and use restrictive
|
|
* rules (i.e. script-src 'self')
|
|
*
|
|
* #7 on the checklist: Disable eval
|
|
*
|
|
* Logs a warning message about unset or insecure CSP
|
|
*/
|
|
const warnAboutInsecureCSP = function () {
|
|
isUnsafeEvalEnabled().then((enabled) => {
|
|
if (!enabled) return
|
|
|
|
const warning = `This renderer process has either no Content Security
|
|
Policy set or a policy with "unsafe-eval" enabled. This exposes users of
|
|
this app to unnecessary security risks.\n ${moreInformation}`
|
|
|
|
console.warn('%cElectron Security Warning (Insecure Content-Security-Policy)',
|
|
'font-weight: bold;', warning)
|
|
})
|
|
}
|
|
|
|
/**
|
|
* #8 on the checklist: Do not set allowRunningInsecureContent to true
|
|
*
|
|
* Logs a warning message about disabled webSecurity.
|
|
*/
|
|
const warnAboutInsecureContentAllowed = function (webPreferences?: Electron.WebPreferences) {
|
|
if (!webPreferences || !webPreferences.allowRunningInsecureContent) return
|
|
|
|
const warning = `This renderer process has "allowRunningInsecureContent"
|
|
enabled. This exposes users of this app to severe security risks.\n
|
|
${moreInformation}`
|
|
|
|
console.warn('%cElectron Security Warning (allowRunningInsecureContent)',
|
|
'font-weight: bold;', warning)
|
|
}
|
|
|
|
/**
|
|
* #9 on the checklist: Do not enable experimental features
|
|
*
|
|
* Logs a warning message about experimental features.
|
|
*/
|
|
const warnAboutExperimentalFeatures = function (webPreferences?: Electron.WebPreferences) {
|
|
if (!webPreferences || (!webPreferences.experimentalFeatures)) {
|
|
return
|
|
}
|
|
|
|
const warning = `This renderer process has "experimentalFeatures" enabled.
|
|
This exposes users of this app to some security risk. If you do not need
|
|
this feature, you should disable it.\n ${moreInformation}`
|
|
|
|
console.warn('%cElectron Security Warning (experimentalFeatures)',
|
|
'font-weight: bold;', warning)
|
|
}
|
|
|
|
/**
|
|
* #10 on the checklist: Do not use enableBlinkFeatures
|
|
*
|
|
* Logs a warning message about enableBlinkFeatures
|
|
*/
|
|
const warnAboutEnableBlinkFeatures = function (webPreferences?: Electron.WebPreferences) {
|
|
if (!webPreferences ||
|
|
!webPreferences.hasOwnProperty('enableBlinkFeatures') ||
|
|
(webPreferences.enableBlinkFeatures && webPreferences.enableBlinkFeatures.length === 0)) {
|
|
return
|
|
}
|
|
|
|
const warning = `This renderer process has additional "enableBlinkFeatures"
|
|
enabled. This exposes users of this app to some security risk. If you do not
|
|
need this feature, you should disable it.\n ${moreInformation}`
|
|
|
|
console.warn('%cElectron Security Warning (enableBlinkFeatures)',
|
|
'font-weight: bold;', warning)
|
|
}
|
|
|
|
/**
|
|
* #11 on the checklist: Do Not Use allowpopups
|
|
*
|
|
* Logs a warning message about allowed popups
|
|
*/
|
|
const warnAboutAllowedPopups = function () {
|
|
if (document && document.querySelectorAll) {
|
|
const domElements = document.querySelectorAll('[allowpopups]')
|
|
|
|
if (!domElements || domElements.length === 0) {
|
|
return
|
|
}
|
|
|
|
const warning = `A <webview> has "allowpopups" set to true. This exposes
|
|
users of this app to some security risk, since popups are just
|
|
BrowserWindows. If you do not need this feature, you should disable it.\n
|
|
${moreInformation}`
|
|
|
|
console.warn('%cElectron Security Warning (allowpopups)',
|
|
'font-weight: bold;', warning)
|
|
}
|
|
}
|
|
|
|
// Currently missing since we can't easily programmatically check for it:
|
|
// #12WebViews: Verify the options and params of all `<webview>` tags
|
|
|
|
const logSecurityWarnings = function (
|
|
webPreferences: Electron.WebPreferences | undefined, nodeIntegration: boolean
|
|
) {
|
|
warnAboutNodeWithRemoteContent(nodeIntegration)
|
|
warnAboutDisabledWebSecurity(webPreferences)
|
|
warnAboutInsecureResources()
|
|
warnAboutInsecureContentAllowed(webPreferences)
|
|
warnAboutExperimentalFeatures(webPreferences)
|
|
warnAboutEnableBlinkFeatures(webPreferences)
|
|
warnAboutInsecureCSP()
|
|
warnAboutAllowedPopups()
|
|
}
|
|
|
|
const getWebPreferences = function () {
|
|
try {
|
|
return invokeSync('ELECTRON_BROWSER_GET_LAST_WEB_PREFERENCES')
|
|
} catch (error) {
|
|
console.warn(`getLastWebPreferences() failed: ${error}`)
|
|
}
|
|
}
|
|
|
|
export function securityWarnings (nodeIntegration: boolean) {
|
|
const loadHandler = function () {
|
|
if (shouldLogSecurityWarnings()) {
|
|
const webPreferences = getWebPreferences()
|
|
logSecurityWarnings(webPreferences, nodeIntegration)
|
|
}
|
|
}
|
|
window.addEventListener('load', loadHandler, { once: true })
|
|
}
|