19b6ba044b
The RemoteObjectFreer class is keeping the context alive even when the window is closed. For electron applications that use sandbox, this will cause a memory leak every time a new window is created with `window.open`. Close #9191
42 lines
1.1 KiB
C++
42 lines
1.1 KiB
C++
// Copyright (c) 2013 GitHub, Inc.
|
|
// Copyright (c) 2012 Intel Corp. All rights reserved.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "atom/common/api/object_life_monitor.h"
|
|
|
|
#include "base/bind.h"
|
|
#include "base/message_loop/message_loop.h"
|
|
|
|
namespace atom {
|
|
|
|
ObjectLifeMonitor::ObjectLifeMonitor(v8::Isolate* isolate,
|
|
v8::Local<v8::Object> target)
|
|
: target_(isolate, target),
|
|
weak_ptr_factory_(this) {
|
|
target_.SetWeak(this, OnObjectGC, v8::WeakCallbackType::kParameter);
|
|
}
|
|
|
|
ObjectLifeMonitor::~ObjectLifeMonitor() {
|
|
if (target_.IsEmpty())
|
|
return;
|
|
target_.ClearWeak();
|
|
target_.Reset();
|
|
}
|
|
|
|
// static
|
|
void ObjectLifeMonitor::OnObjectGC(
|
|
const v8::WeakCallbackInfo<ObjectLifeMonitor>& data) {
|
|
ObjectLifeMonitor* self = data.GetParameter();
|
|
self->target_.Reset();
|
|
self->RunDestructor();
|
|
data.SetSecondPassCallback(Free);
|
|
}
|
|
|
|
// static
|
|
void ObjectLifeMonitor::Free(
|
|
const v8::WeakCallbackInfo<ObjectLifeMonitor>& data) {
|
|
delete data.GetParameter();
|
|
}
|
|
|
|
} // namespace atom
|