* chore: bump chromium in DEPS to 1e9f9a24aa12bea9cf194a82a7e249bd1242ec4f * chore: update patches * Make WebContents' theme color a base::Optional<SkColor> https://chromium-review.googlesource.com/c/chromium/src/+/1540022 * update autofill patch for incorrect header includes * Move Shell messages to web_test and rename to BlinkTest. https://chromium-review.googlesource.com/c/chromium/src/+/1525181 * Make PlatformNotificationServiceImpl a KeyedService. https://chromium-review.googlesource.com/c/chromium/src/+/1336150 * Move MediaPlayerId to its own file. https://chromium-review.googlesource.com/c/chromium/src/+/1547057 * Remove net/base/completion_callback.h, which is no longer used https://chromium-review.googlesource.com/c/chromium/src/+/1552821 * AW NS: support file scheme cookies https://chromium-review.googlesource.com/c/chromium/src/+/1533486 * Remove SecurityInfo and adapt remaining consumers https://chromium-review.googlesource.com/c/chromium/src/+/1509455 * Remove deprecated type-specific number to string conversion functions https://chromium-review.googlesource.com/c/chromium/src/+/1545881 * DevTools: Adding new performance histograms for launch of top 4 tools https://chromium-review.googlesource.com/c/chromium/src/+/1506388 * Update include paths for //base/hash/hash.h https://chromium-review.googlesource.com/c/chromium/src/+/1544630 * build: Disable ensure_gn_version gclient hook for mac CI checkout * update patches * use maybe version of v8::String::NewFromTwoByte * bump appveyor image version * fix mac ci hopefully * Convert enum to enum class for MenuAnchorPosition https://chromium-review.googlesource.com/c/chromium/src/+/1530508 * use maybe version of ToObject * RenderViewHost::GetProcess is no longer const * Unrefcount AuthChallengeInfo https://chromium-review.googlesource.com/c/chromium/src/+/1550631 * MenuButtonController takes Button rather than MenuButton https://chromium-review.googlesource.com/c/chromium/src/+/1500935 * add //ui/views_bridge_mac to deps to fix link error * forward declare views::Button in atom::MenuDelegate * more v8 patches * base/{=> hash}/md5.h https://chromium-review.googlesource.com/c/chromium/src/+/1535124 * gfx::{PlatformFontWin => win}::* https://chromium-review.googlesource.com/c/chromium/src/+/1534178 * fix v8 patches * [base] Rename TaskScheduler to ThreadPool https://chromium-review.googlesource.com/c/chromium/src/+/1561552 * use internal_config_base for bytecode_builtins_list_generator avoids windows link errors * FIXME: temporarily disable v8/breakpad integration * FIXME: temporarily disable prevent-will-redirect test * FIXME: disable neon on aarch64 pending crbug.com/953815 * update to account for WebCursor refactor https://chromium-review.googlesource.com/c/chromium/src/+/1562755 * enable stack dumping on appveyor * Revert "FIXME: disable neon on aarch64 pending crbug.com/953815" This reverts commit 57f082026be3d83069f2a2814684abf4dc9e7b53. * fix: remove const qualifiers to match upstream * fix: remove const qualifiers to match upstream in cc files as well * don't throw an error when testing if an object is an object * use non-deprecated Buffer constructor * Remove net::CookieSameSite::DEFAULT_MODE enum value https://chromium-review.googlesource.com/c/chromium/src/+/1567955 * depend on modded dbus-native to work around buffer deprecation https://github.com/sidorares/dbus-native/pull/262 * revert clang roll to fix arm build on linux * fixup! depend on modded dbus-native to work around buffer deprecation need more coffee * update coffee-script * robustify verify-mksnapshot w.r.t. command-line parameters * Revert "robustify verify-mksnapshot w.r.t. command-line parameters" This reverts commit a49af01411f684f6025528d604895c3696e0bc57. * fix mksnapshot by matching args * update patches * TMP: enable rdp on appveyor * Changed ContentBrowserClient::CreateQuotaPermissionContext() to return scoped_refptr. https://chromium-review.googlesource.com/c/chromium/src/+/1569376 * Make content::ResourceType an enum class. https://chromium-review.googlesource.com/c/chromium/src/+/1569345 * fixup! Make content::ResourceType an enum class. * turn off rdp * use net::CompletionRepeatingCallback instead of base::Callback<void(int)> * remove disable_ensure_gn_version_gclient_hook.patch * copy repeating callback instead of std::move * fix lint * add completion_repeating_callback.h include
		
			
				
	
	
		
			46 lines
		
	
	
	
		
			1.8 KiB
			
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			46 lines
		
	
	
	
		
			1.8 KiB
			
		
	
	
	
		
			Diff
		
	
	
	
	
	
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 | 
						|
From: Shelley Vohr <shelley.vohr@gmail.com>
 | 
						|
Date: Mon, 22 Oct 2018 10:47:11 -0700
 | 
						|
Subject: add_realloc.patch
 | 
						|
 | 
						|
Blink overrides ArrayBuffer's allocator with its own one, while Node simply
 | 
						|
uses malloc and free, so we need to use v8's allocator in Node. As part of the
 | 
						|
10.6.0 upgrade, we needed to make SerializerDelegate accept an allocator
 | 
						|
argument in its constructor, and override ReallocateBufferMemory and
 | 
						|
FreeBufferMemory to use the allocator. We cannot simply allocate and then memcpy
 | 
						|
when we override ReallocateBufferMemory, so we therefore need to implement
 | 
						|
Realloc on the v8 side.
 | 
						|
 | 
						|
diff --git a/include/v8.h b/include/v8.h
 | 
						|
index 6ea19f43013af0b53dcd673e6175f36f95959e1a..f3ec969c25f121514588f762332c914a22f34527 100644
 | 
						|
--- a/include/v8.h
 | 
						|
+++ b/include/v8.h
 | 
						|
@@ -4694,6 +4694,13 @@ class V8_EXPORT ArrayBuffer : public Object {
 | 
						|
      */
 | 
						|
     virtual void* AllocateUninitialized(size_t length) = 0;
 | 
						|
 
 | 
						|
+    /**
 | 
						|
+     * Free the memory block of size |length|, pointed to by |data|.
 | 
						|
+     * That memory must be previously allocated by |Allocate| and not yet freed
 | 
						|
+     * with a call to |Free| or |Realloc|
 | 
						|
+     */
 | 
						|
+    virtual void* Realloc(void* data, size_t length);
 | 
						|
+
 | 
						|
     /**
 | 
						|
      * Free the memory block of size |length|, pointed to by |data|.
 | 
						|
      * That memory is guaranteed to be previously allocated by |Allocate|.
 | 
						|
diff --git a/src/api.cc b/src/api.cc
 | 
						|
index 64c4ae9bc1d70fa5cdc88ee0d2ea9a9f891ae2c4..3b3e84456431bdff91f32ca856fcc0a939fc47cb 100644
 | 
						|
--- a/src/api.cc
 | 
						|
+++ b/src/api.cc
 | 
						|
@@ -520,6 +520,10 @@ void V8::SetSnapshotDataBlob(StartupData* snapshot_blob) {
 | 
						|
   i::V8::SetSnapshotBlob(snapshot_blob);
 | 
						|
 }
 | 
						|
 
 | 
						|
+void* v8::ArrayBuffer::Allocator::Realloc(void* data, size_t length) {
 | 
						|
+  UNIMPLEMENTED();
 | 
						|
+}
 | 
						|
+
 | 
						|
 namespace {
 | 
						|
 
 | 
						|
 class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
 |