electron/shell/browser
Charles Kerr 30e992dec4
chore: bump chromium to 115.0.5786.0 (main) (#38301)
* chore: bump chromium in DEPS to 115.0.5772.0

* chore: update disable_color_correct_rendering.patch

no manual changes; patch succeeded with fuzz 2.

* chore: update chromium/build_libc_as_static_library.patch

no manual changes; patch succeeded with fuzz 2 (offset 1 line).

* chore: update chromium/feat_configure_launch_options_for_service_process.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4518747

patch manually reapplied due to upstream code shear

* chore: update chromium/chore_patch_out_profile_methods_in_profile_selections_cc.patch

https://chromium-review.googlesource.com/c/chromium/src/+/4502965

patch manually reapplied due to upstream code shear

* chore: update bundle_locations #include location

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355

* chore: Remove `extension_name` from DesktopStreamsRegistry

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4514081

* chore: bump chromium in DEPS to 115.0.5778.0

* chore: add chromium/chore_patch_out_profile_methods_in_chrome_browser_pdf.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4482679

Another instance of patching out upstream references to Profile code

* refactor: add WebViewGuestDelegate::GetGuestDelegateWeakPtr()

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4515455

This approach copied from GuestViewBase::GetGuestDelegateWeakPtr() approach in that same commit.

* fixup! chore: update bundle_locations #include location

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355

Sync namespace use to upstream base::mac -> base::apple changes

* fixup! chore: update bundle_locations #include location

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4525355

Sync namespace use to upstream base::mac -> base::apple changes

* chore: update chromium/mas_disable_remote_accessibility.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4530546

patch manually reapplied due to upstream code shear

* chore: update chromium/printing.patch

no manual changes; patch succeeded with fuzz

* chore: update chromium/build_add_electron_tracing_category.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517872

no manual changes; patch succeeded with fuzz

* chore: update chromium/feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529098

patch manually reapplied due to upstream code shear

* chromium/build_only_use_the_mas_build_config_in_the_required_components.patch

https://chromium-review.googlesource.com/c/chromium/src/+/4529098

patch manually reapplied due to upstream code shear

* chore: update chromium/mas-cgdisplayusesforcetogray.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4529475

no manual changes; patch succeeded with fuzz

* chore: update chromium/build_only_use_the_mas_build_config_in_the_required_components.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4429011

no manual changes; patch succeeded with fuzz

* chore: remove chromium/cherry-pick-48a136e77e6d.patch

already present upstream

* chore: remove chromium/cherry-pick-e6e23ba00379.patch

already present upstream

* [Code Health] Remove value based RegisterPref for Dict and List

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4533537

* Remove `cxx17_backports.h` and adjust unittest file

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534916

Notes: mostly just removing #include and s/base::clamp/std::clamp/

* refactor: add FakeBrowserProcess helper class

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4424072

Used in ElectronBrowserMainParts' fake_browser_process_ field. Previously
this was an BrowserProcessImpl instance, but upstream 4424072 makes that
an abstract base class. `FakeBrowserProcess` is a thin subclass with the
minimum code needed to make it concrete.

`ElectronBrowserMainParts::fake_browser_process_` is now a `shared_ptr`
instead of a `unique_ptr` so we can avoid exposing `FakeBrowserProcess`
in the header.

* fixup! refactor: add FakeBrowserProcess helper class

remove unnecessary unique_ptr

* fix: Browser::SetDockIcon() when !Browser.is_ready()

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4410741

An alternative fix for https://github.com/electron/electron/pull/36279 .
The previous fix was to call `SetSupportedScales()` ourselves (1b1609a),
but upstream has removed this API.

CC @codebytere

* fixup! chore: remove chromium/cherry-pick-e6e23ba00379.patch

* chore: update chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4517404

patch manually reapplied due to upstream code shear

* chore: update patches

* chore: add dep: resource_coordinator:mojo_bindings

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4521464

* fixup! chore: add dep: resource_coordinator:mojo_bindings

chore: make lint happy

* chore: patch out Profile methods in titlebar_config

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4508143 (primary)

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4534461 (followup)

* chore: bump chromium in DEPS to 115.0.5780.0

* chore: update chromium/disable_hidden.patch

no manual changes; patch succeeded with fuzz

* chore: update chromium/sysroot.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4535715

no manual changes; patch succeeded with fuzz

* chore: update chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4403623

patch manually reapplied due to upstream code shear

* chore: update chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4547380

patch manually reapplied due to upstream code shear

* chore: update patches

* fixup! fix: Browser::SetDockIcon() when !Browser.is_ready()

chore: iwyu image.h

* chore: bump chromium in DEPS to 115.0.5782.0

* chore: bump chromium in DEPS to 115.0.5784.0

* 4514181: CR2023: Update filled cr-input styles.

https://chromium-review.googlesource.com/c/chromium/src/+/4514181

* 4521894: Remove SiteInstanceDeleting usage outside of tests.

https://chromium-review.googlesource.com/c/chromium/src/+/4521894

* 4525355: Move backup_util and bundle_locations to base/apple

https://chromium-review.googlesource.com/c/chromium/src/+/4525355

* 4484743: webauthn: add underlying support for calling iCloud Keychain on macOS.

https://chromium-review.googlesource.com/c/chromium/src/+/4484743

* chore: fixup patch indices

* 4546398: Convert /chrome/browser to use ARC

https://chromium-review.googlesource.com/c/chromium/src/+/4546398

* chore: bump chromium in DEPS to 115.0.5786.0

* chore: update patches

* 4540682: Initialize PDF SDK with policy in chrome_pdf::RenderPDFPageToDC()

https://chromium-review.googlesource.com/c/chromium/src/+/4540682

* Don't import ObjC++ fn headers into electron_api_app

* 4535715: Refactor sysroot-creator.sh

https://chromium-review.googlesource.com/c/chromium/src/+/4535715

* fixup! refactor: add FakeBrowserProcess helper class

* 4531903: [string][test] Create/Copy strings to old space before externalization

https://chromium-review.googlesource.com/c/v8/v8/+/4531903

* 59645: Add APIs to support RSA keys with large e.

https://boringssl-review.googlesource.com/c/boringssl/+/59645

---------

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-05-23 21:58:58 +02:00
..
api chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
badging chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
bluetooth chore: eliminate a few uses of base::AdaptCallbackForRepeating() (#38293) 2023-05-18 17:01:44 -04:00
extensions chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
hid chore: eliminate a few uses of base::AdaptCallbackForRepeating() (#38293) 2023-05-18 17:01:44 -04:00
lib chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
linux chore: fix clang-tidy warnings (#38079) 2023-04-26 10:09:54 -04:00
mac chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
media refactor: unduplicate MediaStreamDevicesController (#34895) 2022-07-20 17:09:14 +09:00
net refactor: convert HashAlgorithm to enum class (#38233) 2023-05-12 15:23:42 +02:00
notifications chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
osr chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
plugins chore: bump chromium to 98.0.4706.0 (main) (#31555) 2021-11-24 09:45:59 +01:00
printing chore: bump chromium to 113.0.5651.0 (main) (#37553) 2023-03-15 18:20:32 +09:00
resources chore: strip trailing whitespace (#35969) 2023-02-01 12:59:16 +01:00
serial chore: eliminate a few uses of base::AdaptCallbackForRepeating() (#38293) 2023-05-18 17:01:44 -04:00
ui chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
usb chore: eliminate a few uses of base::AdaptCallbackForRepeating() (#38293) 2023-05-18 17:01:44 -04:00
webauthn fix: WebAuthn Discoverable Credential (Resident Credential) (#35374) 2022-09-20 15:47:42 -07:00
win chore: used nested namespaces (#34737) 2022-06-29 12:55:47 -07:00
auto_updater.cc refactor: change defined(MAS_BUILD) to IS_MAS_BUILD() (#36332) 2022-11-14 12:46:52 -08:00
auto_updater.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
auto_updater_mac.mm chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
browser.cc chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
browser.h chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
browser_linux.cc chore: bump chromium to 113.0.5668.0 (main) (#37646) 2023-03-22 20:09:13 -04:00
browser_mac.mm chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
browser_observer.h feat: add did-resign-active event on app (#37933) 2023-04-18 16:53:39 +02:00
browser_process_impl.cc chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
browser_process_impl.h chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
browser_win.cc fix: Showing the about panel is async on all platforms (#37440) 2023-03-06 09:46:35 -05:00
certificate_manager_model.cc chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
certificate_manager_model.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
child_web_contents_tracker.cc chore: bump chromium to 99.0.4767.0 (main) (#31986) 2022-01-10 17:31:39 -05:00
child_web_contents_tracker.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
cookie_change_notifier.cc chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
cookie_change_notifier.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
draggable_region_provider.h refactor: move draggable regions to WebContents (#36230) 2022-11-07 10:15:57 -08:00
electron_api_ipc_handler_impl.cc fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames (#33323) 2022-03-18 19:50:05 -07:00
electron_api_ipc_handler_impl.h fix: build when pdf component is disabled (#33513) 2022-03-30 11:55:38 -07:00
electron_autofill_driver.cc chore: remove spurious trailing namespace comments (#34732) 2022-06-28 10:08:55 +02:00
electron_autofill_driver.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
electron_autofill_driver_factory.cc chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
electron_autofill_driver_factory.h chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
electron_browser_client.cc chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
electron_browser_client.h chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
electron_browser_context.cc feat: Allow usage of an absolute path for partitions used in a session (#37604) 2023-03-20 10:34:49 -04:00
electron_browser_context.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
electron_browser_main_parts.cc chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
electron_browser_main_parts.h chore: bump chromium to 113.0.5653.0 (main) (#37587) 2023-03-16 19:03:53 +09:00
electron_browser_main_parts_linux.cc chore: bump chromium to 110.0.5415.0 (main) (#36186) 2022-11-17 14:59:23 -05:00
electron_browser_main_parts_mac.mm chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
electron_browser_main_parts_posix.cc chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
electron_download_manager_delegate.cc chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
electron_download_manager_delegate.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
electron_gpu_client.cc chore: bump chromium to 100.0.4857.0 (main) (#32419) 2022-02-09 18:58:52 -08:00
electron_gpu_client.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
electron_javascript_dialog_manager.cc chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
electron_javascript_dialog_manager.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
electron_navigation_throttle.cc feat: add will-frame-navigate event (#34418) 2023-03-28 10:55:41 -04:00
electron_navigation_throttle.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
electron_pdf_web_contents_helper_client.cc chore: bump chromium to 108.0.5329.0 (main) (#35628) 2022-10-03 13:21:00 -07:00
electron_pdf_web_contents_helper_client.h chore: bump chromium to 108.0.5329.0 (main) (#35628) 2022-10-03 13:21:00 -07:00
electron_permission_manager.cc chore: fix clang-tidy warnings (#38079) 2023-04-26 10:09:54 -04:00
electron_permission_manager.h chore: bump chromium to 113.0.5660.0 (main) (#37612) 2023-03-20 07:06:57 -04:00
electron_speech_recognition_manager_delegate.cc chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
electron_speech_recognition_manager_delegate.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
electron_web_contents_utility_handler_impl.cc fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames (#33323) 2022-03-18 19:50:05 -07:00
electron_web_contents_utility_handler_impl.h fix: build when pdf component is disabled (#33513) 2022-03-30 11:55:38 -07:00
electron_web_ui_controller_factory.cc chore: clean up forward declarations (#29904) 2021-07-02 09:51:37 +09:00
electron_web_ui_controller_factory.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
event_emitter_mixin.h refactor: simplify events (#37099) 2023-02-13 13:39:18 -08:00
extended_web_contents_observer.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
fake_location_provider.cc chore: bump chromium to 115.0.5760.0 (main) (#38033) 2023-05-10 10:47:48 -04:00
fake_location_provider.h chore: bump chromium to 115.0.5760.0 (main) (#38033) 2023-05-10 10:47:48 -04:00
feature_list.cc chore: remove unnecessary spellchecker revert patch (#38248) 2023-05-15 16:17:00 -04:00
feature_list.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
file_select_helper.cc chore: stop using a RenderWidgetHost observer in FileSelectHelper (#38168) 2023-05-04 21:43:29 +02:00
file_select_helper.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
file_select_helper_mac.mm chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
font_defaults.cc chore: fix clang-tidy warnings (#38079) 2023-04-26 10:09:54 -04:00
font_defaults.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
javascript_environment.cc fix: avoid using v8 on Isolate termination (#35766) 2023-02-09 09:48:49 +01:00
javascript_environment.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
login_handler.cc chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
login_handler.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
microtasks_runner.cc chore: bump chromium to 107.0.5274.0 (main) (#35375) 2022-09-07 09:46:37 +02:00
microtasks_runner.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
native_browser_view.cc chore: trim unused STL includes (#29414) 2021-06-01 10:34:44 +09:00
native_browser_view.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
native_browser_view_mac.h chore: Move draggable regions implementation from NativeBrowserView into InspectableWebContentsView (#35007) 2022-10-17 11:10:07 -04:00
native_browser_view_mac.mm refactor: move draggable regions to WebContents (#36230) 2022-11-07 10:15:57 -08:00
native_browser_view_views.cc chore: Move draggable regions implementation from NativeBrowserView into InspectableWebContentsView (#35007) 2022-10-17 11:10:07 -04:00
native_browser_view_views.h chore: Move draggable regions implementation from NativeBrowserView into InspectableWebContentsView (#35007) 2022-10-17 11:10:07 -04:00
native_window.cc feat: support Mica/Acrylic on Windows (#38163) 2023-05-15 16:31:57 -04:00
native_window.h feat: support Mica/Acrylic on Windows (#38163) 2023-05-15 16:31:57 -04:00
native_window_features.cc fix: Add support for Wayland window decorations (#29618) 2022-01-26 13:59:09 -08:00
native_window_features.h fix: Add support for Wayland window decorations (#29618) 2022-01-26 13:59:09 -08:00
native_window_mac.h fix: only exit fullscreen conditionally with setKiosk (#38219) 2023-05-09 12:28:37 -04:00
native_window_mac.mm chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
native_window_observer.h feat: replace scroll-touch* with generic input-event (#35531) 2022-09-27 12:47:46 -07:00
native_window_views.cc chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
native_window_views.h feat: support Mica/Acrylic on Windows (#38163) 2023-05-15 16:31:57 -04:00
native_window_views_win.cc fix: add restore event for minimized maximization (#35342) 2022-08-23 10:32:42 +09:00
network_hints_handler_impl.cc chore: bump chromium to 113.0.5636.0 (main) (#37130) 2023-03-10 10:07:42 -06:00
network_hints_handler_impl.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
protocol_registry.cc chore: bump chromium to 100.0.4857.0 (main) (#32419) 2022-02-09 18:58:52 -08:00
protocol_registry.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
relauncher.cc chore: use emplace when possible (#37877) 2023-04-11 15:21:03 +09:00
relauncher.h chore: bump chromium to 100.0.4857.0 (main) (#32419) 2022-02-09 18:58:52 -08:00
relauncher_linux.cc chore: used nested namespaces (#34737) 2022-06-29 12:55:47 -07:00
relauncher_mac.cc chore: use emplace when possible (#37877) 2023-04-11 15:21:03 +09:00
relauncher_win.cc chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
session_preferences.cc chore: clean up forward declarations (#29904) 2021-07-02 09:51:37 +09:00
session_preferences.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
special_storage_policy.cc chore: bump chromium to 111.0.5544.3 (main) (#36820) 2023-02-03 12:43:42 +01:00
special_storage_policy.h chore: bump chromium to 106.0.5216.0 (main) (#34993) 2022-08-17 11:35:53 -07:00
web_contents_permission_helper.cc fix: getUserMedia duplicate permissions call (#36787) 2023-01-11 11:55:31 +01:00
web_contents_permission_helper.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
web_contents_preferences.cc fix: falsy transparent shouldn't affect webContents background (#36914) 2023-05-02 14:44:34 -07:00
web_contents_preferences.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
web_contents_zoom_controller.cc chore: bump chromium to 110.0.5415.0 (main) (#36186) 2022-11-17 14:59:23 -05:00
web_contents_zoom_controller.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
web_view_guest_delegate.cc chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
web_view_guest_delegate.h chore: bump chromium to 115.0.5786.0 (main) (#38301) 2023-05-23 21:58:58 +02:00
web_view_manager.cc chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
web_view_manager.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
window_list.cc fix: DCHECK when calling app.exit() (#33035) 2022-02-23 16:27:54 +01:00
window_list.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
window_list_observer.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
zoom_level_delegate.cc fix: avoid deprecated value apis (#37590) 2023-03-20 10:38:45 -04:00
zoom_level_delegate.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00