electron/shell/browser/notifications/notification.cc
trop[bot] b6e19c5a45
chore: avoid crash while notification removal (#43061)
* avoid crash of operation on an invalid entry while erase set iterator.

Co-authored-by: bill.shen <shenyb32768@gmail.com>

* fix notification removal crash due to the nullptr presenter

Co-authored-by: bill.shen <shenyb32768@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-07-26 16:32:43 -04:00

54 lines
1.3 KiB
C++

// Copyright (c) 2015 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "shell/browser/notifications/notification.h"
#include "shell/browser/notifications/notification_delegate.h"
#include "shell/browser/notifications/notification_presenter.h"
namespace electron {
NotificationOptions::NotificationOptions() = default;
NotificationOptions::~NotificationOptions() = default;
Notification::Notification(NotificationDelegate* delegate,
NotificationPresenter* presenter)
: delegate_(delegate), presenter_(presenter) {}
Notification::~Notification() {
if (delegate())
delegate()->NotificationDestroyed();
}
void Notification::NotificationClicked() {
if (delegate())
delegate()->NotificationClick();
Destroy();
}
void Notification::NotificationDismissed(bool should_destroy) {
if (delegate())
delegate()->NotificationClosed();
set_is_dismissed(true);
if (should_destroy)
Destroy();
}
void Notification::NotificationFailed(const std::string& error) {
if (delegate())
delegate()->NotificationFailed(error);
Destroy();
}
void Notification::Remove() {}
void Notification::Destroy() {
if (presenter()) {
presenter()->RemoveNotification(this);
}
}
} // namespace electron