72ee2622ebrefactor: fix modernize-return-braced-init-list warnings (#44838) * refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list] * refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list] NB: using the braced-initializer list uncovered an error here: the float returned by std::floor() can't be implicitly cast to an int. This is solved by using base::ClampFloor<int>() instead. std::floor()
47 lines
1.6 KiB
C++
47 lines
1.6 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "shell/common/node_util.h"
|
|
|
|
#include "base/logging.h"
|
|
#include "gin/converter.h"
|
|
#include "shell/common/node_includes.h"
|
|
|
|
namespace electron::util {
|
|
|
|
v8::MaybeLocal<v8::Value> CompileAndCall(
|
|
v8::Local<v8::Context> context,
|
|
const char* id,
|
|
std::vector<v8::Local<v8::String>>* parameters,
|
|
std::vector<v8::Local<v8::Value>>* arguments) {
|
|
v8::Isolate* isolate = context->GetIsolate();
|
|
v8::TryCatch try_catch(isolate);
|
|
|
|
thread_local node::builtins::BuiltinLoader builtin_loader;
|
|
v8::MaybeLocal<v8::Function> compiled = builtin_loader.LookupAndCompile(
|
|
context, id, parameters, node::Realm::GetCurrent(context));
|
|
|
|
if (compiled.IsEmpty())
|
|
return {};
|
|
|
|
v8::Local<v8::Function> fn = compiled.ToLocalChecked().As<v8::Function>();
|
|
v8::MaybeLocal<v8::Value> ret = fn->Call(
|
|
context, v8::Null(isolate), arguments->size(), arguments->data());
|
|
|
|
// This will only be caught when something has gone terrible wrong as all
|
|
// electron scripts are wrapped in a try {} catch {} by webpack
|
|
if (try_catch.HasCaught()) {
|
|
std::string msg = "no error message";
|
|
if (!try_catch.Message().IsEmpty()) {
|
|
gin::ConvertFromV8(isolate, try_catch.Message()->Get(), &msg);
|
|
} else if (try_catch.HasTerminated()) {
|
|
msg = "script execution has been terminated";
|
|
}
|
|
LOG(ERROR) << "Failed to CompileAndCall electron script (" << id
|
|
<< "): " << msg;
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
} // namespace electron::util
|