716cb28430
* chore: bump chromium in DEPS to 1e9f9a24aa12bea9cf194a82a7e249bd1242ec4f * chore: update patches * Make WebContents' theme color a base::Optional<SkColor>1540022* update autofill patch for incorrect header includes * Move Shell messages to web_test and rename to BlinkTest.1525181* Make PlatformNotificationServiceImpl a KeyedService.1336150* Move MediaPlayerId to its own file.1547057* Remove net/base/completion_callback.h, which is no longer used1552821* AW NS: support file scheme cookies1533486* Remove SecurityInfo and adapt remaining consumers1509455* Remove deprecated type-specific number to string conversion functions1545881* DevTools: Adding new performance histograms for launch of top 4 tools1506388* Update include paths for //base/hash/hash.h1544630* build: Disable ensure_gn_version gclient hook for mac CI checkout * update patches * use maybe version of v8::String::NewFromTwoByte * bump appveyor image version * fix mac ci hopefully * Convert enum to enum class for MenuAnchorPosition1530508* use maybe version of ToObject * RenderViewHost::GetProcess is no longer const * Unrefcount AuthChallengeInfo1550631* MenuButtonController takes Button rather than MenuButton1500935* add //ui/views_bridge_mac to deps to fix link error * forward declare views::Button in atom::MenuDelegate * more v8 patches * base/{=> hash}/md5.h1535124* gfx::{PlatformFontWin => win}::*1534178* fix v8 patches * [base] Rename TaskScheduler to ThreadPool1561552* use internal_config_base for bytecode_builtins_list_generator avoids windows link errors * FIXME: temporarily disable v8/breakpad integration * FIXME: temporarily disable prevent-will-redirect test * FIXME: disable neon on aarch64 pending crbug.com/953815 * update to account for WebCursor refactor1562755* enable stack dumping on appveyor * Revert "FIXME: disable neon on aarch64 pending crbug.com/953815" This reverts commit 57f082026be3d83069f2a2814684abf4dc9e7b53. * fix: remove const qualifiers to match upstream * fix: remove const qualifiers to match upstream in cc files as well * don't throw an error when testing if an object is an object * use non-deprecated Buffer constructor * Remove net::CookieSameSite::DEFAULT_MODE enum value1567955* depend on modded dbus-native to work around buffer deprecation https://github.com/sidorares/dbus-native/pull/262 * revert clang roll to fix arm build on linux * fixup! depend on modded dbus-native to work around buffer deprecation need more coffee * update coffee-script * robustify verify-mksnapshot w.r.t. command-line parameters * Revert "robustify verify-mksnapshot w.r.t. command-line parameters" This reverts commit a49af01411f684f6025528d604895c3696e0bc57. * fix mksnapshot by matching args * update patches * TMP: enable rdp on appveyor * Changed ContentBrowserClient::CreateQuotaPermissionContext() to return scoped_refptr.1569376* Make content::ResourceType an enum class.1569345* fixup! Make content::ResourceType an enum class. * turn off rdp * use net::CompletionRepeatingCallback instead of base::Callback<void(int)> * remove disable_ensure_gn_version_gclient_hook.patch * copy repeating callback instead of std::move * fix lint * add completion_repeating_callback.h include
43 lines
1.9 KiB
Diff
43 lines
1.9 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Heilig Benedek <benecene@gmail.com>
|
|
Date: Wed, 30 Jan 2019 17:04:33 +0100
|
|
Subject: don't call into chrome internals for autofill popup size calculations
|
|
|
|
The default GetWindowBounds calls into chrome internal functions to
|
|
find out the size of the window - this can be overridden but even
|
|
then some methods call into the original. Let's just return an empty
|
|
gfx::Rect and do the actual job in the subclass.
|
|
|
|
diff --git a/chrome/browser/ui/autofill/popup_view_common.cc b/chrome/browser/ui/autofill/popup_view_common.cc
|
|
index 004e9cb86bee7c10f6a68cdf6ceb60bf39627e1d..a78dc65c413ce72d31a364e1b36dbe067cf579d7 100644
|
|
--- a/chrome/browser/ui/autofill/popup_view_common.cc
|
|
+++ b/chrome/browser/ui/autofill/popup_view_common.cc
|
|
@@ -8,9 +8,11 @@
|
|
#include <utility>
|
|
|
|
#include "build/build_config.h"
|
|
+#if 0
|
|
#include "chrome/browser/platform_util.h"
|
|
#include "chrome/browser/ui/browser_finder.h"
|
|
#include "chrome/browser/ui/browser_window.h"
|
|
+#endif
|
|
#include "ui/gfx/geometry/vector2d.h"
|
|
|
|
#if defined(OS_ANDROID)
|
|
@@ -176,14 +178,14 @@ gfx::Rect PopupViewCommon::GetWindowBounds(gfx::NativeView container_view) {
|
|
views::Widget::GetTopLevelWidgetForNativeView(container_view);
|
|
if (widget)
|
|
return widget->GetWindowBoundsInScreen();
|
|
-
|
|
+#if 0
|
|
// If the widget is null, try to get these bounds from a browser window. This
|
|
// is common on Mac when the window is drawn using Cocoa.
|
|
gfx::NativeWindow window = platform_util::GetTopLevel(container_view);
|
|
Browser* browser = chrome::FindBrowserWithWindow(window);
|
|
if (browser)
|
|
return browser->window()->GetBounds();
|
|
-
|
|
+#endif
|
|
// If the browser is null, simply return an empty rect. The most common reason
|
|
// to end up here is that the NativeView has been destroyed externally, which
|
|
// can happen at any time. This happens fairly commonly on Windows (e.g., at
|