electron/atom/renderer
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
api fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
resources/mac mac: Generate Info.plist from gyp variables 2015-04-14 16:09:34 +08:00
atom_autofill_agent.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
atom_autofill_agent.h The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
atom_render_frame_observer.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
atom_render_frame_observer.h The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
atom_render_view_observer.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
atom_render_view_observer.h [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
atom_renderer_client.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
atom_renderer_client.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_sandboxed_renderer_client.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_sandboxed_renderer_client.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
content_settings_observer.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
content_settings_observer.h The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
guest_view_container.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
guest_view_container.h insertText is deprecated 2017-02-06 10:34:29 -08:00
preferences_manager.cc refactor: remove instances of createDeepCopy (#13703) 2018-08-04 07:23:07 +10:00
preferences_manager.h Update to API changes of Chrome 52 2016-07-04 15:32:43 +09:00
renderer_client_base.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
renderer_client_base.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
web_worker_observer.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
web_worker_observer.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00