mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/atom/browser/ui
History
Charles Kerr 869e0ab14d
fix: honor dialog.showMessageBox()'s Icon argument on Linux (#15326) 
* Don't call gtk_widget_show_all() on popup dialog.

Fixes #15317.

Notes: Fixed incorrect display of some GtkMessageDialog icons.

The issue is caused because GtkMessageDialog contains an icon widget
which is not shown when there's no associated icon. Our call to
`gtk_widget_show_all()` overrides this, showing the uninitialized
icon widget.

This PR fixes the issue by calling `gtk_widget_show()` where needed
and removing use of `gtk_widget_show_all()` in the message dialog.

* use gtk_dialog_set_default_response() for default

* fix: support icons on gtk+ messageboxes.
2018-10-23 12:44:47 -05:00
..
cocoa fix: Native window close crash (#15327) 2018-10-23 10:35:00 -04:00
views refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
webui build: define compile time features with buildflag header (#14840) 2018-10-01 16:00:53 -04:00
win fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
x fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
accelerator_util.cc Remove PlatformAccelerator 2018-10-09 14:38:00 -07:00
accelerator_util.h Remove PlatformAccelerator 2018-10-09 14:38:00 -07:00
atom_menu_model.cc chore: run clang-format 2018-09-19 17:18:10 +02:00
atom_menu_model.h enable chromium style checker plugin for electron and brightray targets 2018-04-19 11:12:58 -07:00
autofill_popup.cc build: define compile time features with buildflag header (#14840) 2018-10-01 16:00:53 -04:00
autofill_popup.h Update OSR code 2018-06-19 11:49:44 +10:00
certificate_trust.h Don't pass the result through 2017-04-04 09:21:15 -04:00
certificate_trust_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
certificate_trust_win.cc chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00
devtools_manager_delegate.cc refactor: eliminate brightray::ContentClient (#15303) 2018-10-22 19:04:23 +02:00
devtools_manager_delegate.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
devtools_ui.cc refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
devtools_ui.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
drag_util.h Support dragging multiple files 2016-07-03 13:58:31 +09:00
drag_util_mac.mm Support dragging multiple files 2016-07-03 13:58:31 +09:00
drag_util_views.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
file_dialog.h chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00
file_dialog_gtk.cc refactoring: use std::make_unique<T> (#13245) 2018-06-18 16:32:55 +09:00
file_dialog_mac.mm refactoring: use std::make_unique<T> (#13245) 2018-06-18 16:32:55 +09:00
file_dialog_win.cc chore: run clang-format 2018-09-19 17:18:10 +02:00
inspectable_web_contents.cc refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_delegate.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_impl.cc refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_impl.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_view.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_view_delegate.cc refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_view_delegate.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_view_mac.h refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
inspectable_web_contents_view_mac.mm refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
message_box.h clang-format atom files 2018-04-18 20:48:45 -04:00
message_box_gtk.cc fix: honor dialog.showMessageBox()'s Icon argument on Linux (#15326) 2018-10-23 12:44:47 -05:00
message_box_mac.mm fix: Dialog does not close on ESCAPE if defaultId is set (#14196) 2018-08-19 13:41:03 -07:00
message_box_win.cc chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00
tray_icon.cc add getter for ignoreDoubleClickEvents field 2018-05-03 13:49:33 -07:00
tray_icon.h add getter for ignoreDoubleClickEvents field 2018-05-03 13:49:33 -07:00
tray_icon_cocoa.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
tray_icon_cocoa.mm fix: allow Tray with title only (without icon) on Mac (#13851) 2018-08-30 21:16:56 +12:00
tray_icon_gtk.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
tray_icon_gtk.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
tray_icon_observer.h clang-format atom files 2018-04-18 20:48:45 -04:00
tray_icon_win.cc Remove All Rights Reserved after GitHub copyright 2014-10-31 11:17:05 -07:00