electron/shell
Charles Kerr 1af9612edf
fix: ElectronBrowserContext::PartitionKey comparisons (#41055)
* fix: ElectronBrowserContext::PartitionKey comparisons

Use c++20 default comparisons to simplify + fix PartitionKey sorting:

- The equality operator is broken. `PartitionKey{"foo", false}` is both
  equal, to and less than, `PartitionKey{"foo", true}`

- For some keys, the same session can be retrieved via both `fromPath()`
  and `fromPartition()`. This use case was discussed and removed from
  the original PR after code review said "always returning different
  sessions feels lower maintenance." The current behavior is a bug that
  comes from the comparison operators not checking the keys' types.

Xref: 3f1aea9af9 (r1099745359)

Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#Default-comparisons-allowed

* fixup! fix: ElectronBrowserContext::PartitionKey comparisons
2024-01-23 09:41:44 -06:00
..
app chore: migrate base::StringPiece to std::string_view (#40915) 2024-01-10 19:00:37 -06:00
browser fix: ElectronBrowserContext::PartitionKey comparisons (#41055) 2024-01-23 09:41:44 -06:00
common feat: Windows integrity check (#40504) 2024-01-19 09:00:49 +13:00
renderer chore: bump chromium to 122.0.6236.2 (main) (#40871) 2024-01-11 19:33:40 +13:00
services/node feat: add net module to utility process (#40017) 2024-01-04 16:20:37 -05:00
utility chore: remove unused std includes (#38767) 2023-06-14 11:07:18 -07:00