electron/atom/common/api
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
api_messages.h feat: add event.senderId property to IPCs sent via ipcRenderer.sendTo (#14395) 2018-08-31 20:13:51 -05:00
atom_api_asar.cc refactoring: use std::make_unique<T> (#13245) 2018-06-18 16:32:55 +09:00
atom_api_clipboard.cc run clang-format 2018-04-16 15:08:17 -04:00
atom_api_clipboard.h remove html/rtf methods marked for 2.0 2018-02-20 08:41:58 -05:00
atom_api_clipboard_mac.mm Add find text support to clipboard 2016-10-25 14:15:54 +09:00
atom_api_crash_reporter.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_key_weak_map.h clang-format atom files 2018-04-18 20:48:45 -04:00
atom_api_native_image.cc fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_native_image.h clang-format atom files 2018-04-18 20:48:45 -04:00
atom_api_native_image_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
atom_api_shell.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_v8_util.cc fix: use context counter as contextId 2018-07-19 11:00:10 -07:00
atom_bindings.cc Remove the 'getProcessMemoryInfo' API 2018-09-11 20:21:32 +02:00
atom_bindings.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
constructor.h Add LayoutManager/BoxLayout APIs 2018-05-24 15:36:29 +09:00
event_emitter_caller.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
event_emitter_caller.h clang-format atom files 2018-04-18 20:48:45 -04:00
features.cc Include the node header at the end to avoid collisions 2018-09-11 20:24:03 +02:00
locker.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
locker.h
object_life_monitor.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
object_life_monitor.h Fix context leak in ObjectLifeMonitor. 2017-04-28 11:21:53 -03:00
remote_callback_freer.cc feat: add event.senderId property to IPCs sent via ipcRenderer.sendTo (#14395) 2018-08-31 20:13:51 -05:00
remote_callback_freer.h fix double-freeing remote references 2018-07-12 10:44:26 +09:00
remote_object_freer.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
remote_object_freer.h fix double-freeing remote references 2018-07-12 10:44:26 +09:00