mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/shell/browser/api
History
Shelley Vohr 1729a9868c
fix: use BlockedRequest struct to handle webRequest data (#42647) 
Fixes an issue where Chromium could crash on a dangling unretained pointer in one of several webRequest functions. This was happening as a result of the fact that we had outstanding blocking requests continue to reference state owned by ProxyingWebsocket and ProxyingURLLoaderFactory after the requests were destroyed.

This had been going on for a few years, and was likely leading to some ongoing memory issues. To fix this, we need to ensure that all state is cleaned up in OnRequestWillBeDestroyed. I chose to create a new BlockedRequest struct to do so, which approximates the approach that upstream takes. The complexities of doing so also made our templated approach more trouble than it felt worth, so i pried that apart into separate handlers.
2024-07-02 14:02:49 +02:00
..
views chore: rename built-in modules to bindings to match naming update in node (#37182) 2023-02-09 10:31:38 +09:00
electron_api_app.cc feat: add cumulativeCPUUsage to AppMetrics and CPUUsage (#41819) 2024-06-11 09:38:03 -05:00
electron_api_app.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_app_mac.mm chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_app_mas.mm chore: bump chromium to 117.0.5923.0 (main) (#39304) 2023-08-04 10:47:29 +02:00
electron_api_auto_updater.cc fix: potential async_hooks crash in NotifyWindowRestore on Windows (#40576) 2024-01-26 12:53:07 -06:00
electron_api_auto_updater.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
electron_api_base_window.cc feat: enable Windows Control Overlay on Linux (#41769) 2024-06-27 14:56:36 +02:00
electron_api_base_window.h feat: enable Windows Control Overlay on Linux (#41769) 2024-06-27 14:56:36 +02:00
electron_api_browser_window.cc fix: setTitleBarOverlay should be implemented on BaseWindow (#41960) 2024-04-29 11:28:24 -04:00
electron_api_browser_window.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_content_tracing.cc chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_cookies.cc refactor: improve cookie failure rejection messages (#42362) 2024-06-07 10:06:37 +02:00
electron_api_cookies.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
electron_api_crash_reporter.cc chore: bump chromium to 116.0.5829.0 (main) (#38726) 2023-06-13 14:45:48 -04:00
electron_api_crash_reporter.h
electron_api_data_pipe_holder.cc chore: bump chromium to 128.0.6558.0 (main) (#42413) 2024-07-02 09:51:33 +02:00
electron_api_data_pipe_holder.h chore: add missing gin::Wrappable GetTypeName overrides (#41512) 2024-03-06 12:45:28 +01:00
electron_api_debugger.cc refactor: replace use of deprecated base::JSONWriter::WriteJson() (#41215) 2024-02-02 12:25:58 -06:00
electron_api_debugger.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_desktop_capturer.cc perf: remove unnecessary .c_str() calls (#41869) 2024-04-16 19:48:54 -04:00
electron_api_desktop_capturer.h refactor: prefer to inherit observer classes privately (#41360) 2024-05-21 14:21:31 -05:00
electron_api_dialog.cc refactor: add gin_helper::Dictionary::CreateEmpty() helper (#39547) 2023-08-21 10:43:41 +09:00
electron_api_download_item.cc chore: bump chromium to 120.0.6099.0 (main) (#40316) 2023-11-01 10:02:12 -04:00
electron_api_download_item.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_event_emitter.cc chore: rename built-in modules to bindings to match naming update in node (#37182) 2023-02-09 10:31:38 +09:00
electron_api_event_emitter.h
electron_api_global_shortcut.cc chore: bump chromium to 127.0.6521.0 (main) (#42118) 2024-06-07 17:18:35 -04:00
electron_api_global_shortcut.h refactor: prefer to inherit observer classes privately (#41360) 2024-05-21 14:21:31 -05:00
electron_api_in_app_purchase.cc chore: remove obsolete "simple" object annotations for the remote module (#39486) 2023-08-22 13:43:30 +09:00
electron_api_in_app_purchase.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_menu.cc fix: set prototype names on gin::Constructible classes (#39006) 2023-07-10 11:49:20 +02:00
electron_api_menu.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_menu_mac.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
electron_api_menu_mac.mm chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_menu_views.cc perf: use flat_set, flat_map for small, trivially-moved containers (#40817) 2024-01-05 12:18:31 +01:00
electron_api_menu_views.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
electron_api_native_theme.cc chore: rename built-in modules to bindings to match naming update in node (#37182) 2023-02-09 10:31:38 +09:00
electron_api_native_theme.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_native_theme_mac.mm chore: cleanup arc migration helpers (#39606) 2023-08-23 09:54:21 -04:00
electron_api_net_log.cc chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_net_log.h chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_notification.cc refactor: inline simple getters (#41125) 2024-01-29 20:43:28 -06:00
electron_api_notification.h refactor: inline simple getters (#41125) 2024-01-29 20:43:28 -06:00
electron_api_power_monitor.cc feat: add thermal states to powerMonitor (#37935) 2023-04-19 11:46:55 +02:00
electron_api_power_monitor.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_power_monitor_mac.mm fix: user-did-{resign|become}-active events on macOS (#41506) 2024-03-06 12:43:39 +01:00
electron_api_power_monitor_win.cc refactor: replace remaining NULL with nullptr (#40053) 2023-10-03 12:26:35 -07:00
electron_api_power_save_blocker.cc chore: add missing gin::Wrappable GetTypeName overrides (#41512) 2024-03-06 12:45:28 +01:00
electron_api_power_save_blocker.h chore: add missing gin::Wrappable GetTypeName overrides (#41512) 2024-03-06 12:45:28 +01:00
electron_api_printing.cc chore: remove deprecated webContents.getPrinters() (#39663) 2023-09-05 10:16:41 +02:00
electron_api_protocol.cc perf: avoid protocol registry redundant lookup (#41991) 2024-05-09 09:53:09 -04:00
electron_api_protocol.h feat: enable code cache for custom protocols (#40544) 2023-12-06 11:22:41 +09:00
electron_api_push_notifications.cc chore: remove unused std includes (#38767) 2023-06-14 11:07:18 -07:00
electron_api_push_notifications.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_push_notifications_mac.mm chore: cleanup arc migration helpers (#39606) 2023-08-23 09:54:21 -04:00
electron_api_safe_storage.cc refactor: inline simple getters, pt . 2 (#41254) 2024-02-09 10:29:14 +01:00
electron_api_safe_storage.h
electron_api_screen.cc chore: bump chromium to 127.0.6521.0 (main) (#42118) 2024-06-07 17:18:35 -04:00
electron_api_screen.h chore: bump chromium to 127.0.6521.0 (main) (#42118) 2024-06-07 17:18:35 -04:00
electron_api_service_worker_context.cc refactor: remove banned std::to_string() calls (#41087) 2024-01-24 16:43:31 -06:00
electron_api_service_worker_context.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_session.cc refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_session.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_system_preferences.cc feat: expose app accessibility transparency settings api (#39631) 2023-09-20 12:48:02 -07:00
electron_api_system_preferences.h feat: expose app accessibility transparency settings api (#39631) 2023-09-20 12:48:02 -07:00
electron_api_system_preferences_mac.mm chore: bump chromium to 123.0.6296.0 (main) (#41204) 2024-02-14 12:33:32 -05:00
electron_api_system_preferences_win.cc feat: expose system preferences to utility process (#42203) 2024-06-20 11:15:57 -04:00
electron_api_tray.cc chore: migrate base::StringPiece to std::string_view (#40915) 2024-01-10 19:00:37 -06:00
electron_api_tray.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_utility_process.cc fix: utilityProcess exit codes (#42297) 2024-06-07 10:06:00 +02:00
electron_api_utility_process.h fix: utilityProcess exit codes (#42297) 2024-06-07 10:06:00 +02:00
electron_api_view.cc chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
electron_api_view.h refactor: prefer to inherit observer classes privately (#41360) 2024-05-21 14:21:31 -05:00
electron_api_web_contents.cc chore: bump chromium to 128.0.6558.0 (main) (#42413) 2024-07-02 09:51:33 +02:00
electron_api_web_contents.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
electron_api_web_contents_impl.cc build: remove enable_osr build flag (#38703) 2023-06-13 14:48:53 -04:00
electron_api_web_contents_mac.mm chore: bump chromium to 127.0.6521.0 (main) (#42118) 2024-06-07 17:18:35 -04:00
electron_api_web_contents_view.cc feat: Allow WebContentsView to accept webContents object. (#42086) 2024-05-30 12:45:35 -07:00
electron_api_web_contents_view.h refactor: inherit Observer classes privately, pt. 2 (#42237) 2024-05-29 13:07:02 -05:00
electron_api_web_frame_main.cc fix: account for potentially swapped FrameTreeNodeId in WebFrameMain (#41538) 2024-03-14 09:50:52 +01:00
electron_api_web_frame_main.h chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
electron_api_web_request.cc fix: use BlockedRequest struct to handle webRequest data (#42647) 2024-07-02 14:02:49 +02:00
electron_api_web_request.h fix: use BlockedRequest struct to handle webRequest data (#42647) 2024-07-02 14:02:49 +02:00
electron_api_web_view_manager.cc chore: rename built-in modules to bindings to match naming update in node (#37182) 2023-02-09 10:31:38 +09:00
frame_subscriber.cc chore: bump chromium to 127.0.6521.0 (main) (#42118) 2024-06-07 17:18:35 -04:00
frame_subscriber.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
gpu_info_enumerator.cc refactor: simplify code by using base::Value::EnsureList() (#41162) 2024-01-30 14:48:09 -06:00
gpu_info_enumerator.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
gpuinfo_manager.cc chore: bump chromium to 128.0.6558.0 (main) (#42413) 2024-07-02 09:51:33 +02:00
gpuinfo_manager.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
message_port.cc fix: MessagePort closing unexpectedly with non-cloneable objects (#42535) 2024-06-19 11:27:07 +02:00
message_port.h chore: add missing gin::Wrappable GetTypeName overrides (#41512) 2024-03-06 12:45:28 +01:00
process_metric.cc chore: bump chromium to 123.0.6296.0 (main) (#41204) 2024-02-14 12:33:32 -05:00
process_metric.h
save_page_handler.cc
save_page_handler.h refactor: prefer to inherit observer classes privately (#41360) 2024-05-21 14:21:31 -05:00
ui_event.cc
ui_event.h