37639b5400
* Remove microtasks_scope.h and microtasks_scope.cc
* Use v8::MicrotasksScope when ignoring browser checkpoint
These call always skip the browser checkpoint, so they are equivalent to using v8::MicrotasksScope directly (modulo the optional wrapper behavior).
* Remove MicrotasksScope from node_bindings.cc
This code seems contradictory: it explicitly specifies "do not run microtasks" yet runs a microtask checkpoint in the browser process.
Looking at its history, it [was introduced][1] with the intention to not run microtasks, but a [subtle C++ language behavior][2] caused it to do the opposite later in the same roll. Since the original intention was to not run microtasks, and since that is also the simplest explanation, we can assume `ignore_browser_checkpoint` should be true and migrate this to `v8::MicrotasksScope` as it is equivalent (modulo the optional wrapper behavior).
[1]: a4ea80dd47 (diff-efe58cf03c97028f37f801db044d396a5f428686da6595d2c692f1c052bbd09c)
[2]: https://github.com/electron/electron/pull/43185
* Migrate gin_helper/promise.h and gin_helper/promise.cc to v8::MicrotasksScope
Restores the [original][1] behavior of running the microtask checkpoint at destruction, but preserves the behavior of running microtasks in the browser process. This had last changed in the migration to gin_helper::MicroTasks.
[1]: https://github.com/electron/electron/pull/16401
43 lines
1.6 KiB
C++
43 lines
1.6 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "shell/common/gin_helper/event_emitter_caller.h"
|
|
|
|
#include "shell/common/node_includes.h"
|
|
|
|
namespace gin_helper::internal {
|
|
|
|
v8::Local<v8::Value> CallMethodWithArgs(
|
|
v8::Isolate* isolate,
|
|
v8::Local<v8::Object> obj,
|
|
const char* method,
|
|
const base::span<v8::Local<v8::Value>> args) {
|
|
v8::EscapableHandleScope handle_scope{isolate};
|
|
|
|
// CallbackScope and MakeCallback both require an active node::Environment
|
|
if (!node::Environment::GetCurrent(isolate))
|
|
return handle_scope.Escape(v8::False(isolate));
|
|
|
|
node::CallbackScope callback_scope{isolate, v8::Object::New(isolate),
|
|
node::async_context{0, 0}};
|
|
|
|
// Perform microtask checkpoint after running JavaScript.
|
|
v8::MicrotasksScope microtasks_scope(obj->GetCreationContextChecked(),
|
|
v8::MicrotasksScope::kRunMicrotasks);
|
|
|
|
// node::MakeCallback will also run pending tasks in Node.js.
|
|
v8::MaybeLocal<v8::Value> ret = node::MakeCallback(
|
|
isolate, obj, method, args.size(), args.data(), {0, 0});
|
|
|
|
// If the JS function throws an exception (doesn't return a value) the result
|
|
// of MakeCallback will be empty and therefore ToLocal will be false, in this
|
|
// case we need to return "false" as that indicates that the event emitter did
|
|
// not handle the event
|
|
if (v8::Local<v8::Value> localRet; ret.ToLocal(&localRet))
|
|
return handle_scope.Escape(localRet);
|
|
|
|
return handle_scope.Escape(v8::False(isolate));
|
|
}
|
|
|
|
} // namespace gin_helper::internal
|