0e4e9dc98c
* chore: bump chromium in DEPS to 121.0.6116.0 * chore: update patches * Update webIDL to support close event. Refs https://chromium-review.googlesource.com/c/chromium/src/+/4970653 * Remove uses of implicit conversion of ScopedTypeRef Refs https://bugs.chromium.org/p/chromium/issues/detail?id=1495439 * Add GlobalRenderFrameHostToken Refs https://chromium-review.googlesource.com/c/chromium/src/+/5001743 * [DevTools] Console Insights: move from build flag to Feature API Refs https://chromium-review.googlesource.com/c/chromium/src/+/5002232 * [Extensions] Use script serialization in scripting API Refs https://chromium-review.googlesource.com/c/chromium/src/+/4968680 Refs https://chromium-review.googlesource.com/c/chromium/src/+/4998265 * [api] Remove AllCan Read/Write https://chromium-review.googlesource.com/c/v8/v8/+/5006387 * chore: update libcxx files * chore: address nan compilation error * spec: use nan dependency from third_party It is easier to get fixes for spec modules depending on nan * ci: publish nan artifact for woa * fix: bad patch update * chore: update nan resolution * Revert "chore: update nan resolution" This reverts commit 786cdb858c9fc8a038a8f3e16068ee5b4a050137. --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>
38 lines
1.8 KiB
Diff
38 lines
1.8 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Cheng Zhao <zcbenz@gmail.com>
|
|
Date: Tue, 4 Jun 2019 11:30:12 +0900
|
|
Subject: crashpad_pid_check.patch
|
|
|
|
When both browser process and renderer process are connecting to the pipe,
|
|
the API may return the PID of browser process as real_pid, which is different
|
|
from the PID of renderer process.
|
|
|
|
This is caused by the crashReporter getting started after the sanbox, after
|
|
we redesign crashReporter's API to make it alwasy start before the
|
|
sanbox, we can remove this patch.
|
|
|
|
See following links for more:
|
|
https://github.com/electron/electron/pull/18483#discussion_r292703588
|
|
https://github.com/electron/electron/pull/18483#issuecomment-501090683
|
|
|
|
diff --git a/third_party/crashpad/crashpad/util/win/exception_handler_server.cc b/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
|
|
index e641c7fb944114efdd376b2b5d6c3791669ab5dd..df252a42078b19e8423e037e1a5b6eb1a44321ec 100644
|
|
--- a/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
|
|
+++ b/third_party/crashpad/crashpad/util/win/exception_handler_server.cc
|
|
@@ -447,9 +447,16 @@ bool ExceptionHandlerServer::ServiceClientConnection(
|
|
DWORD real_pid = 0;
|
|
if (get_named_pipe_client_process_id(service_context.pipe(), &real_pid) &&
|
|
message.registration.client_process_id != real_pid) {
|
|
+ // Electron: When both browser process and renderer process are connecting
|
|
+ // to the pipe, the API may return the PID of browser process as real_pid,
|
|
+ // which is different from the PID of renderer process.
|
|
+ //
|
|
+ // I don't understand why Chromium does not have this issue.
|
|
+#if 0
|
|
LOG(ERROR) << "forged client pid, real pid: " << real_pid
|
|
<< ", got: " << message.registration.client_process_id;
|
|
return false;
|
|
+#endif
|
|
}
|
|
}
|
|
|