electron/shell/browser
mlaurencin 53aaeb7a16
fix: prevent destroyed view references from causing crashes (#25411)
Closes #21666.

This PR is fixing crashes caused by referencing and attempting to modify previously destroyed views.
Before, when a view was destroyed and then the contents were referenced for modification, the system would crash as undefined memory was accessed. This fix explicitly makes the pointer to the destroyed view's contents null, so that this will not happen.
2020-09-16 18:10:49 -06:00
..
api fix: ensure ready-to-show event is fired (#25448) 2020-09-15 12:48:39 -06:00
extensions build: fix build with enable_pdf_viewer=false (#25494) 2020-09-17 01:15:01 +03:00
lib chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) (#24256) 2020-07-13 21:13:34 -04:00
linux chore: bump chromium to f5b345dd470f14eef6e44732ccf23 (master) (#20649) 2019-10-28 15:12:35 -07:00
mac feat: expose currencyCode on Product struct in IAP module (#25058) 2020-08-21 10:41:40 -07:00
media refactor: run clang-tidy (#20231) 2019-09-16 18:12:00 -04:00
net fix: browser contexts live forever (#24964) 2020-08-17 13:21:53 -07:00
notifications revert: "fix: reply notifs sometimes destroyed too early" (#25247) 2020-09-02 10:02:47 +09:00
osr chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
plugins chore: bump chromium to 1a093e6a0cb5e72ba78990fe39824 (master) (#24575) 2020-07-21 22:34:34 -07:00
printing chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) (#24256) 2020-07-13 21:13:34 -04:00
resources Bump v12.0.0-nightly.20200916 2020-09-16 07:31:16 -07:00
ui fix: client area inset calculation when maximized for framless windows (#25052) 2020-08-31 16:55:50 +09:00
win refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
auto_updater.cc chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
auto_updater.h refactor: ginify autoUpdater (#24678) 2020-07-28 11:04:34 -07:00
auto_updater_mac.mm refactor: ginify autoUpdater (#24678) 2020-07-28 11:04:34 -07:00
browser.cc chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
browser.h fix: multiple dock icons when calling dock.show/hide (#25269) 2020-09-03 20:46:24 +09:00
browser_linux.cc refactor: ginify app (#24679) 2020-07-28 16:43:43 -07:00
browser_mac.mm fix: multiple dock icons when calling dock.show/hide (#25269) 2020-09-03 20:46:24 +09:00
browser_observer.h chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
browser_process_impl.cc chore: bump chromium to 1a093e6a0cb5e72ba78990fe39824 (master) (#24575) 2020-07-21 22:34:34 -07:00
browser_process_impl.h chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) (#24256) 2020-07-13 21:13:34 -04:00
browser_win.cc feat: add capabilities to app.getLoginItemSettings() and app.setLoginItemSettings() (#24494) 2020-07-29 10:08:37 -07:00
child_web_contents_tracker.cc feat: enhance native window.open to match the custom implementation's behavior (#19703) 2020-03-26 11:05:45 -07:00
child_web_contents_tracker.h feat: enhance native window.open to match the custom implementation's behavior (#19703) 2020-03-26 11:05:45 -07:00
common_web_contents_delegate.cc fix: browser contexts live forever (#24964) 2020-08-17 13:21:53 -07:00
common_web_contents_delegate.h fix: browser contexts live forever (#24964) 2020-08-17 13:21:53 -07:00
common_web_contents_delegate_mac.mm chore: bump chromium to 580fe983e138952553cd6af11ee8b (master) (#23379) 2020-05-26 13:06:26 -07:00
common_web_contents_delegate_views.cc chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
cookie_change_notifier.cc chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
cookie_change_notifier.h chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_autofill_driver.cc Bump v12.0.0-nightly.20200827 2020-08-27 07:31:51 -07:00
electron_autofill_driver.h Bump v12.0.0-nightly.20200827 2020-08-27 07:31:51 -07:00
electron_autofill_driver_factory.cc Bump v12.0.0-nightly.20200827 2020-08-27 07:31:51 -07:00
electron_autofill_driver_factory.h Bump v12.0.0-nightly.20200827 2020-08-27 07:31:51 -07:00
electron_browser_client.cc fix: disable CORS when webSecurity is disabled (#25463) 2020-09-16 14:55:53 -07:00
electron_browser_client.h chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
electron_browser_context.cc fix: browser contexts live forever (#24964) 2020-08-17 13:21:53 -07:00
electron_browser_context.h fix: browser contexts live forever (#24964) 2020-08-17 13:21:53 -07:00
electron_browser_main_parts.cc fix: call node::Stop on exit (#25430) 2020-09-14 14:08:46 -07:00
electron_browser_main_parts.h chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
electron_browser_main_parts_mac.mm fix: crashReporter incompatible with sandbox on Linux (#23265) 2020-05-07 13:31:26 -07:00
electron_browser_main_parts_posix.cc chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_download_manager_delegate.cc chore: bump chromium to a84d34e372b8fb5e9a94b1b4b447e (master) (#23908) 2020-06-22 10:35:10 -07:00
electron_download_manager_delegate.h chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_gpu_client.cc chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_gpu_client.h chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_javascript_dialog_manager.cc refactor: WebContents::From returns pointer (#24605) 2020-07-16 16:16:05 -07:00
electron_javascript_dialog_manager.h refactor: WebContents::From returns pointer (#24605) 2020-07-16 16:16:05 -07:00
electron_navigation_throttle.cc refactor: wire will-navigate up to a navigation throttle instead of OpenURL (#25065) 2020-08-21 12:34:09 -07:00
electron_navigation_throttle.h refactor: wire will-navigate up to a navigation throttle instead of OpenURL (#25065) 2020-08-21 12:34:09 -07:00
electron_pdf_web_contents_helper_client.cc refactor: remove references to non-existent webui (#20867) 2019-11-04 09:50:31 -08:00
electron_pdf_web_contents_helper_client.h refactor: remove references to non-existent webui (#20867) 2019-11-04 09:50:31 -08:00
electron_permission_manager.cc chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_permission_manager.h chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_quota_permission_context.cc chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_quota_permission_context.h chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_speech_recognition_manager_delegate.cc chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_speech_recognition_manager_delegate.h chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
electron_web_ui_controller_factory.cc fix: chrome://accessibility not loading (#24437) 2020-07-16 10:14:54 -07:00
electron_web_ui_controller_factory.h chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
event_emitter_mixin.cc refactor: EventEmitters without gin_helper (#22726) 2020-03-18 12:57:08 -07:00
event_emitter_mixin.h refactor: ginify WebContents (#24651) 2020-07-30 09:17:57 -07:00
fake_location_provider.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
fake_location_provider.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
feature_list.cc chore: bump chromium to a84d34e372b8fb5e9a94b1b4b447e (master) (#23908) 2020-06-22 10:35:10 -07:00
feature_list.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
font_defaults.cc chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
font_defaults.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
javascript_environment.cc feat: record v8 cpu samples in the main process (#24819) 2020-08-21 09:25:30 -07:00
javascript_environment.h fix: let Node.js perform microtask checkpoint in the main process (#24131) 2020-06-17 10:08:10 -07:00
login_handler.cc refactor: WebContents::From returns pointer (#24605) 2020-07-16 16:16:05 -07:00
login_handler.h fix: implement 'login' event for net.ClientRequest (#21096) 2019-11-14 10:01:18 -08:00
microtasks_runner.cc chore: bump node to v12.18.0 (master) (#23789) 2020-06-17 15:57:12 -07:00
microtasks_runner.h chore: bump chromium to f755b70e34659441e72c1a928a406 (master) (#21000) 2019-12-10 16:22:35 -08:00
native_browser_view.cc fix: prevent destroyed view references from causing crashes (#25411) 2020-09-16 18:10:49 -06:00
native_browser_view.h fix: prevent destroyed view references from causing crashes (#25411) 2020-09-16 18:10:49 -06:00
native_browser_view_mac.h feat: add getBounds() method for BrowserView (#19370) 2019-07-29 19:43:05 -07:00
native_browser_view_mac.mm fix: prevent destroyed view references from causing crashes (#25411) 2020-09-16 18:10:49 -06:00
native_browser_view_views.cc fix: prevent destroyed view references from causing crashes (#25411) 2020-09-16 18:10:49 -06:00
native_browser_view_views.h feat: add getBounds() method for BrowserView (#19370) 2019-07-29 19:43:05 -07:00
native_window.cc chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
native_window.h fix: revert 6ecf729 to fix Linux titlebar dark mode (#25055) 2020-08-20 16:53:06 -04:00
native_window_mac.h feat: make window visual effect state customizable (#25083) 2020-08-24 11:44:48 -04:00
native_window_mac.mm fix: prevent crash if BrowserView webContents was destroyed (#25112) 2020-08-25 20:04:13 -07:00
native_window_observer.h fix: macOS modal focus (#24286) 2020-06-29 13:15:28 -07:00
native_window_views.cc fix: prevent crash if BrowserView webContents was destroyed (#25112) 2020-08-25 20:04:13 -07:00
native_window_views.h fix: revert 6ecf729 to fix Linux titlebar dark mode (#25055) 2020-08-20 16:53:06 -04:00
native_window_views_win.cc fix: save normal window bounds when maximizing (#25051) 2020-08-24 13:32:08 -07:00
network_hints_handler_impl.cc refactor: ginify Session (#23569) 2020-05-19 10:18:12 -07:00
network_hints_handler_impl.h fix: hold browser_context instead of render_frame_host to fix lifetime issues (#23271) 2020-05-01 16:37:01 +09:00
node_debugger.cc fix: Node.js cpu and heap profiling (#24528) 2020-07-14 11:56:57 -04:00
node_debugger.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
pref_store_delegate.cc chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
pref_store_delegate.h chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
protocol_registry.cc fix: webRequest module should work with file:// protocol (#22903) 2020-04-01 16:38:40 +09:00
protocol_registry.h fix: webRequest module should work with file:// protocol (#22903) 2020-04-01 16:38:40 +09:00
relauncher.cc chore: bump chromium to 0f4170320ff37e971064916aed1dc (master) (#23285) 2020-04-30 13:20:44 -07:00
relauncher.h chore: fix linting after shell rename 2019-06-19 17:33:28 -07:00
relauncher_linux.cc refactor: apply some 'clang-tidy -fix' changes (#20172) 2019-09-13 10:26:59 -04:00
relauncher_mac.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
relauncher_win.cc chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) (#24256) 2020-07-13 21:13:34 -04:00
session_preferences.cc chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) (#24256) 2020-07-13 21:13:34 -04:00
session_preferences.h fix: ignore non-absolute session preload script paths when sandboxed (#19066) 2019-07-03 08:05:45 -07:00
special_storage_policy.cc chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) (#24256) 2020-07-13 21:13:34 -04:00
special_storage_policy.h chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) (#24256) 2020-07-13 21:13:34 -04:00
unresponsive_suppressor.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
unresponsive_suppressor.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_contents_permission_helper.cc chore: bump chromium to bc8f70ed4cfe2262ea833750eaddb (master) (#22649) 2020-03-14 16:54:14 -04:00
web_contents_permission_helper.h chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) (#18648) 2019-07-02 18:22:09 -07:00
web_contents_preferences.cc chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
web_contents_preferences.h chore: add deprecation warning for the default of contextIsolation (#23507) 2020-06-25 10:55:17 -07:00
web_contents_zoom_controller.cc chore: bump chromium to e049d599a8332b9b2785b0178be74 (master) (#20314) 2019-10-18 12:57:34 -07:00
web_contents_zoom_controller.h chore: bump chromium to e049d599a8332b9b2785b0178be74 (master) (#20314) 2019-10-18 12:57:34 -07:00
web_dialog_helper.cc chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) (#24256) 2020-07-13 21:13:34 -04:00
web_dialog_helper.h chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) (#24256) 2020-07-13 21:13:34 -04:00
web_view_guest_delegate.cc chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
web_view_guest_delegate.h fix: crash when navigating from a page with webview that has inherited zoom level (#24757) 2020-07-28 13:00:44 -07:00
web_view_manager.cc chore: rename atom -> electron (#21986) 2020-02-04 12:19:40 -08:00
web_view_manager.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
window_list.cc chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) (#24687) 2020-08-12 11:33:58 -07:00
window_list.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
window_list_observer.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
zoom_level_delegate.cc chore: bump chromium to e049d599a8332b9b2785b0178be74 (master) (#20314) 2019-10-18 12:57:34 -07:00
zoom_level_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00