ddd93529d5
This fixes a nasty warning / permission dialog that pops up to end-users when consuming legacy APIs. Chrome has flipped these flags via field trials as have other Electron apps. It should just be the default.
74 lines
2.6 KiB
C++
74 lines
2.6 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "electron/shell/browser/feature_list.h"
|
|
|
|
#include <string>
|
|
|
|
#include "base/base_switches.h"
|
|
#include "base/command_line.h"
|
|
#include "base/feature_list.h"
|
|
#include "base/metrics/field_trial.h"
|
|
#include "components/spellcheck/common/spellcheck_features.h"
|
|
#include "content/public/common/content_features.h"
|
|
#include "electron/buildflags/buildflags.h"
|
|
#include "media/base/media_switches.h"
|
|
#include "net/base/features.h"
|
|
#include "services/network/public/cpp/features.h"
|
|
#include "third_party/blink/public/common/features.h"
|
|
|
|
#if BUILDFLAG(IS_MAC)
|
|
#include "device/base/features.h" // nogncheck
|
|
#endif
|
|
|
|
namespace electron {
|
|
|
|
void InitializeFeatureList() {
|
|
auto* cmd_line = base::CommandLine::ForCurrentProcess();
|
|
auto enable_features =
|
|
cmd_line->GetSwitchValueASCII(::switches::kEnableFeatures);
|
|
auto disable_features =
|
|
cmd_line->GetSwitchValueASCII(::switches::kDisableFeatures);
|
|
// Disable creation of spare renderer process with site-per-process mode,
|
|
// it interferes with our process preference tracking for non sandboxed mode.
|
|
// Can be reenabled when our site instance policy is aligned with chromium
|
|
// when node integration is enabled.
|
|
disable_features +=
|
|
std::string(",") + features::kSpareRendererForSitePerProcess.name;
|
|
|
|
// TODO(codebytere): Remove WebSQL support per crbug.com/695592.
|
|
enable_features += std::string(",") + blink::features::kWebSQLAccess.name;
|
|
|
|
#if BUILDFLAG(IS_WIN)
|
|
disable_features +=
|
|
// Disable async spellchecker suggestions for Windows, which causes
|
|
// an empty suggestions list to be returned
|
|
std::string(",") + spellcheck::kWinRetrieveSuggestionsOnlyOnDemand.name +
|
|
// Delayed spellcheck initialization is causing the
|
|
// 'custom dictionary word list API' spec to crash.
|
|
std::string(",") + spellcheck::kWinDelaySpellcheckServiceInit.name;
|
|
#endif
|
|
std::string platform_specific_enable_features =
|
|
EnablePlatformSpecificFeatures();
|
|
if (platform_specific_enable_features.size() > 0) {
|
|
enable_features += std::string(",") + platform_specific_enable_features;
|
|
}
|
|
base::FeatureList::InitInstance(enable_features, disable_features);
|
|
}
|
|
|
|
void InitializeFieldTrials() {
|
|
auto* cmd_line = base::CommandLine::ForCurrentProcess();
|
|
auto force_fieldtrials =
|
|
cmd_line->GetSwitchValueASCII(::switches::kForceFieldTrials);
|
|
|
|
base::FieldTrialList::CreateTrialsFromString(force_fieldtrials);
|
|
}
|
|
|
|
#if !BUILDFLAG(IS_MAC)
|
|
std::string EnablePlatformSpecificFeatures() {
|
|
return "";
|
|
}
|
|
#endif
|
|
|
|
} // namespace electron
|