electron/shell
Shelley Vohr 1729a9868c
fix: use BlockedRequest struct to handle webRequest data (#42647)
Fixes an issue where Chromium could crash on a dangling unretained pointer in one of several webRequest functions. This was happening as a result of the fact that we had outstanding blocking requests continue to reference state owned by ProxyingWebsocket and ProxyingURLLoaderFactory after the requests were destroyed.

This had been going on for a few years, and was likely leading to some ongoing memory issues. To fix this, we need to ensure that all state is cleaned up in OnRequestWillBeDestroyed. I chose to create a new BlockedRequest struct to do so, which approximates the approach that upstream takes. The complexities of doing so also made our templated approach more trouble than it felt worth, so i pried that apart into separate handlers.
2024-07-02 14:02:49 +02:00
..
app chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
browser fix: use BlockedRequest struct to handle webRequest data (#42647) 2024-07-02 14:02:49 +02:00
common chore: bump chromium to 128.0.6558.0 (main) (#42413) 2024-07-02 09:51:33 +02:00
renderer chore: bump chromium to 128.0.6558.0 (main) (#42413) 2024-07-02 09:51:33 +02:00
services/node fix: MessagePort closing unexpectedly with non-cloneable objects (#42535) 2024-06-19 11:27:07 +02:00
utility chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00