4f69c5835e* chore: bump chromium in DEPS to 140.0.7259.0 * chore: update patches * Add fade in animation to Picture-in-Picture windows https://chromium-review.googlesource.com/c/chromium/src/+/6538268 * [v8] Use V8 Apis that don't return JSGlobalObject Refs https://issues.chromium.org/issues/333672197 * chore: IWYU * chore: bump chromium in DEPS to 140.0.7261.0 * chore: update patches * revert: update to siso-chromium image * [v8] Use v8::Object::WrapGlobal() Refs https://chromium-review.googlesource.com/c/chromium/src/+/6650977 * chore: IWYU * chore: fix --trace-startup spec --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>
25 lines
1.2 KiB
Diff
25 lines
1.2 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: VerteDinde <vertedinde@electronjs.org>
|
|
Date: Tue, 12 Nov 2024 21:16:15 -0800
|
|
Subject: build: disable thin_lto on mac
|
|
|
|
This patch disables thin lto on mac only. After Node 22 was merged into
|
|
main, release builds began failing due to missing symbols, which seem to
|
|
be being stripped out by thin lto.
|
|
|
|
This patch can (and should) be removed when we can prevent those symbols
|
|
from being stripped in the release build.
|
|
|
|
diff --git a/build/config/compiler/compiler.gni b/build/config/compiler/compiler.gni
|
|
index bbe8e5f2cf0d70121a649e0a4897e0643445c57c..3461b5daf6b80b7fe54d03b2e2ba8896780db973 100644
|
|
--- a/build/config/compiler/compiler.gni
|
|
+++ b/build/config/compiler/compiler.gni
|
|
@@ -82,7 +82,7 @@ declare_args() {
|
|
# have the same LLVM revisions as us, making bitcode useless to them.
|
|
use_thin_lto =
|
|
is_cfi || (is_clang && is_official_build && chrome_pgo_phase != 1 &&
|
|
- (is_linux || is_win || is_mac ||
|
|
+ (is_linux || is_win ||
|
|
(is_ios && use_lld && !is_cronet_build) ||
|
|
(is_android && target_os != "chromeos") ||
|
|
(is_chromeos && is_chromeos_device)))
|