49 lines
1.8 KiB
Diff
49 lines
1.8 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jeremy Apthorp <nornagon@nornagon.net>
|
|
Date: Wed, 29 Apr 2020 16:28:35 -0700
|
|
Subject: breakpad: disable upload compression
|
|
|
|
Our prior implementation of breakpad uploading did not compress files on
|
|
upload. In order to maintain that behavior, this disables compression in
|
|
//components/crash.
|
|
|
|
Ideally, this would be made configurable.
|
|
|
|
diff --git a/components/crash/core/app/breakpad_linux.cc b/components/crash/core/app/breakpad_linux.cc
|
|
index 364af690879d79d25d118d5b2fdbaabe21a1c52d..390cca9edc26d3153c8dbc86024cb50097d7ac78 100644
|
|
--- a/components/crash/core/app/breakpad_linux.cc
|
|
+++ b/components/crash/core/app/breakpad_linux.cc
|
|
@@ -1334,6 +1334,7 @@ void ExecUploadProcessOrTerminate(const BreakpadInfo& info,
|
|
|
|
#else // defined(OS_CHROMEOS)
|
|
|
|
+ /*
|
|
// Compress |dumpfile| with gzip.
|
|
const pid_t gzip_child = sys_fork();
|
|
if (gzip_child < 0) {
|
|
@@ -1377,13 +1378,16 @@ void ExecUploadProcessOrTerminate(const BreakpadInfo& info,
|
|
WriteLog(msg, sizeof(msg) - 1);
|
|
sys__exit(1);
|
|
}
|
|
+ */
|
|
|
|
// The --header argument to wget looks like:
|
|
// --header=Content-Encoding: gzip
|
|
// --header=Content-Type: multipart/form-data; boundary=XYZ
|
|
// where the boundary has two fewer leading '-' chars
|
|
+ /*
|
|
static const char header_content_encoding[] =
|
|
"--header=Content-Encoding: gzip";
|
|
+ */
|
|
static const char header_msg[] =
|
|
"--header=Content-Type: multipart/form-data; boundary=";
|
|
const size_t header_content_type_size =
|
|
@@ -1412,7 +1416,7 @@ void ExecUploadProcessOrTerminate(const BreakpadInfo& info,
|
|
static const char kWgetBinary[] = "/usr/bin/wget";
|
|
const char* args[] = {
|
|
kWgetBinary,
|
|
- header_content_encoding,
|
|
+ //header_content_encoding,
|
|
header_content_type,
|
|
post_file,
|
|
upload_url,
|